1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build warning

Chen, Gang C posted 1 patch 1 year, 8 months ago
Failed in applying to current master (apply log)
UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 5 -----
1 file changed, 5 deletions(-)
[edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build warning
Posted by Chen, Gang C 1 year, 8 months ago 
Fix the gcc build warning:
variable PldInfo set but not used [-Wunused-but-set-variable]

Cc: Ray Ni <ray.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Gang Chen <gang.c.chen@intel.com>
---
 UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
index 9a2c3c148d..fba0e6cba5 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
+++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
@@ -48,7 +48,6 @@ PeiLoadFileLoadPayload (
   VOID                           *Elf;
   UNIVERSAL_PAYLOAD_EXTRA_DATA   *ExtraData;
   ELF_IMAGE_CONTEXT              Context;
-  UNIVERSAL_PAYLOAD_INFO_HEADER  *PldInfo;
   UINT32                         Index;
   UINT16                         ExtraDataIndex;
   CHAR8                          *SectionName;
@@ -85,7 +84,6 @@ PeiLoadFileLoadPayload (
   //
   // Get UNIVERSAL_PAYLOAD_INFO_HEADER and number of additional PLD sections.
   //
-  PldInfo        = NULL;
   ExtraDataCount = 0;
   for (Index = 0; Index < Context.ShNum; Index++) {
     Status = GetElfSectionName (&Context, Index, &SectionName);
@@ -96,9 +94,6 @@ PeiLoadFileLoadPayload (
     DEBUG ((DEBUG_INFO, "Payload Section[%d]: %a\n", Index, SectionName));
     if (AsciiStrCmp (SectionName, UNIVERSAL_PAYLOAD_INFO_SEC_NAME) == 0) {
       Status = GetElfSectionPos (&Context, Index, &Offset, &Size);
-      if (!EFI_ERROR (Status)) {
-        PldInfo = (UNIVERSAL_PAYLOAD_INFO_HEADER *)(Context.FileBase + Offset);
-      }
     } else if (AsciiStrnCmp (SectionName, UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX, UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX_LENGTH) == 0) {
       Status = GetElfSectionPos (&Context, Index, &Offset, &Size);
       if (!EFI_ERROR (Status)) {
-- 
2.35.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92759): https://edk2.groups.io/g/devel/message/92759
Mute This Topic: https://groups.io/mt/93227587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build warning
Posted by Zhiguang Liu 1 year, 8 months ago 
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Wednesday, August 24, 2022 10:27 PM
> To: devel@edk2.groups.io
> Cc: Chen, Gang C <gang.c.chen@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build
> warning
> 
> Fix the gcc build warning:
> variable PldInfo set but not used [-Wunused-but-set-variable]
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> index 9a2c3c148d..fba0e6cba5 100644
> --- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> +++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> @@ -48,7 +48,6 @@ PeiLoadFileLoadPayload (
>    VOID                           *Elf;
>    UNIVERSAL_PAYLOAD_EXTRA_DATA   *ExtraData;
>    ELF_IMAGE_CONTEXT              Context;
> -  UNIVERSAL_PAYLOAD_INFO_HEADER  *PldInfo;
>    UINT32                         Index;
>    UINT16                         ExtraDataIndex;
>    CHAR8                          *SectionName;
> @@ -85,7 +84,6 @@ PeiLoadFileLoadPayload (
>    //
>    // Get UNIVERSAL_PAYLOAD_INFO_HEADER and number of additional PLD
> sections.
>    //
> -  PldInfo        = NULL;
>    ExtraDataCount = 0;
>    for (Index = 0; Index < Context.ShNum; Index++) {
>      Status = GetElfSectionName (&Context, Index, &SectionName); @@ -96,9
> +94,6 @@ PeiLoadFileLoadPayload (
>      DEBUG ((DEBUG_INFO, "Payload Section[%d]: %a\n", Index,
> SectionName));
>      if (AsciiStrCmp (SectionName, UNIVERSAL_PAYLOAD_INFO_SEC_NAME)
> == 0) {
>        Status = GetElfSectionPos (&Context, Index, &Offset, &Size);
> -      if (!EFI_ERROR (Status)) {
> -        PldInfo = (UNIVERSAL_PAYLOAD_INFO_HEADER *)(Context.FileBase +
> Offset);
> -      }
>      } else if (AsciiStrnCmp (SectionName,
> UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX,
> UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX_LENGTH) == 0) {
>        Status = GetElfSectionPos (&Context, Index, &Offset, &Size);
>        if (!EFI_ERROR (Status)) {
> --
> 2.35.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92779): https://edk2.groups.io/g/devel/message/92779
Mute This Topic: https://groups.io/mt/93227587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build warning
Posted by Lu, James 1 year, 8 months ago 
Reviewed-by: James Lu <james.lu@intel.com>


Thanks,
James

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhiguang Liu
Sent: Thursday, August 25, 2022 10:21 AM
To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build warning

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Wednesday, August 24, 2022 10:27 PM
> To: devel@edk2.groups.io
> Cc: Chen, Gang C <gang.c.chen@intel.com>; Ni, Ray <ray.ni@intel.com>; 
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build 
> warning
> 
> Fix the gcc build warning:
> variable PldInfo set but not used [-Wunused-but-set-variable]
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> ---
>  UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> index 9a2c3c148d..fba0e6cba5 100644
> --- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> +++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c
> @@ -48,7 +48,6 @@ PeiLoadFileLoadPayload (
>    VOID                           *Elf;
>    UNIVERSAL_PAYLOAD_EXTRA_DATA   *ExtraData;
>    ELF_IMAGE_CONTEXT              Context;
> -  UNIVERSAL_PAYLOAD_INFO_HEADER  *PldInfo;
>    UINT32                         Index;
>    UINT16                         ExtraDataIndex;
>    CHAR8                          *SectionName;
> @@ -85,7 +84,6 @@ PeiLoadFileLoadPayload (
>    //
>    // Get UNIVERSAL_PAYLOAD_INFO_HEADER and number of additional PLD 
> sections.
>    //
> -  PldInfo        = NULL;
>    ExtraDataCount = 0;
>    for (Index = 0; Index < Context.ShNum; Index++) {
>      Status = GetElfSectionName (&Context, Index, &SectionName); @@ 
> -96,9
> +94,6 @@ PeiLoadFileLoadPayload (
>      DEBUG ((DEBUG_INFO, "Payload Section[%d]: %a\n", Index, 
> SectionName));
>      if (AsciiStrCmp (SectionName, UNIVERSAL_PAYLOAD_INFO_SEC_NAME) == 
> 0) {
>        Status = GetElfSectionPos (&Context, Index, &Offset, &Size);
> -      if (!EFI_ERROR (Status)) {
> -        PldInfo = (UNIVERSAL_PAYLOAD_INFO_HEADER *)(Context.FileBase +
> Offset);
> -      }
>      } else if (AsciiStrnCmp (SectionName, 
> UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX,
> UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX_LENGTH) == 0) {
>        Status = GetElfSectionPos (&Context, Index, &Offset, &Size);
>        if (!EFI_ERROR (Status)) {
> --
> 2.35.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92784): https://edk2.groups.io/g/devel/message/92784
Mute This Topic: https://groups.io/mt/93227587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.