From nobody Sun May 19 20:02:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92738+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92738+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1661308289; cv=none; d=zohomail.com; s=zohoarc; b=jWEiI5ljZNJX7UZZxGNgzw9G3NdvNuudqLXIRw4K2X1sEbYrYDTzOPIXWO0xfl+Y1CVFnLxpDAl7b1h6/ePrD7GtBdFcOF3s/fCeHqh7aFAvW2rlIG4lscT9oJP9eRjEgrOMmJXXqIQ5UeyxmboulKeJ41T47dlpue20fzaCACg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661308289; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=cRkSuAU/385YO8hMtQaAT46u1mfGQYThdiyG1HBV/Cg=; b=PYZC6TeF7e92a/OkrCPO9nj7HQAlHXoTgLH0A5qlV+sXBSfvb9V7IQ/3yavJqglVAw8JjgzTMtYXN+MhGIwK7puOoVb+C4MpWJwCmFbqcX7pL1p3ZjEOttH6jgrU0j+u/YfxVcoX3RF9eD+MvFq5sTt7iWmFXXNuZ/UpFeqM4nI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92738+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661308289138126.95145556597674; Tue, 23 Aug 2022 19:31:29 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ANeAYY1788612xqseiFvzmW9; Tue, 23 Aug 2022 19:31:28 -0700 X-Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by mx.groups.io with SMTP id smtpd.web09.6685.1661308288288858274 for ; Tue, 23 Aug 2022 19:31:28 -0700 X-Received: by mail-pl1-f202.google.com with SMTP id q6-20020a17090311c600b0017266460b8fso10081155plh.4 for ; Tue, 23 Aug 2022 19:31:28 -0700 (PDT) X-Gm-Message-State: WMmKph1m5DrqrXVh0jPU4nTGx1787277AA= X-Google-Smtp-Source: AA6agR59eGj7ypT1qa0eXwobPq47krXizmAbaf1BO0hSycKj9hQkSga3/Tzc5dKb6S1TDC9AoU9J+FfN/+4= X-Received: from yuanyu.kir.corp.google.com ([2620:15c:29:204:2db3:282b:550e:d4f]) (user=yuanyu job=sendgmr) by 2002:a05:6a00:1812:b0:536:dde9:8ef2 with SMTP id y18-20020a056a00181200b00536dde98ef2mr8139404pfa.70.1661308287742; Tue, 23 Aug 2022 19:31:27 -0700 (PDT) Date: Tue, 23 Aug 2022 19:31:23 -0700 In-Reply-To: <20220824023123.3060905-1-yuanyu@google.com> Message-Id: <20220824023123.3060905-2-yuanyu@google.com> Mime-Version: 1.0 References: <20220824023123.3060905-1-yuanyu@google.com> Subject: [edk2-devel] [PATCH v1 1/1] OvmfPkg/PlatformDxe: Check RouteConfig arguments for spec compliance From: "Yuan Yu via groups.io" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , Laszlo Ersek , Anthony Perard , Julien Grall Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanyu@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661308288; bh=Amv1crZHqt9wIoWNiCaakXFAQA9UyFtkm6/r5V3VKns=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=EI/TSdo6g4ykcHfZ4mBVIn0C616rPnzeu01Oe+r6vcsmHs0ycRBPhO3mnZHCeXRmmF8 lbhBooatsHZsAPFXv228OqTHSVMekvfLmaMexA8khiuqydzaUbHWE1lnGWF+DOzT3Uhw7 C7axeNjSJfUGYPfnrhdON77vlsAJc9ACs+o= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661308289639100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Per UEFI Spec 2.9, EFI_HII_CONFIG_ROUTING_PROTOCOL.RouteConfig() should return EFI_INVALID_PARAMETERS if caller passes in a NULL for the Configuration parameter (see 35.4 EFI HII Configuration Routing Protocol). Add a check to return EFI_INVALID_PARAMETERS when Configuration is NULL. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Laszlo Ersek Cc: Anthony Perard Cc: Julien Grall Signed-off-by: Yuan Yu --- OvmfPkg/PlatformDxe/Platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c index a6d459f3dfd7..83dcd2216c6d 100644 --- a/OvmfPkg/PlatformDxe/Platform.c +++ b/OvmfPkg/PlatformDxe/Platform.c @@ -344,7 +344,7 @@ RouteConfig ( Configuration )); =20 - if (Progress =3D=3D NULL) { + if (Progress =3D=3D NULL || Configuration =3D=3D NULL) { return EFI_INVALID_PARAMETER; } =20 --=20 2.37.2.672.g94769d06f0-goog -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92738): https://edk2.groups.io/g/devel/message/92738 Mute This Topic: https://groups.io/mt/93219657/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-