[edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules

Kun Qin posted 6 patches 1 year, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 200 ++++++++++++++++----
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 135 +++++++++++++
DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   1 +
DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
5 files changed, 379 insertions(+), 38 deletions(-)
[edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules
Posted by Kun Qin 1 year, 9 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998

Current DynamicTablesPkg provide great support for creating dynamic ACPI
tables during boot time.

However, there are some modules needs minor tweaks to expand support and
compatibility for OS requirements and platform needs.

This patch series proposes a few fixes to resolve minor issues discovered
in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.

Patch v1 branch: https://github.com/kuqin12/edk2/tree/dynamic_update

Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>

Kun Qin (6):
  DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf
  DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
  DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
  DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
    tables
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
    space
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
    config

 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 200 ++++++++++++++++----
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 135 +++++++++++++
 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   1 +
 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
 5 files changed, 379 insertions(+), 38 deletions(-)

-- 
2.36.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91497): https://edk2.groups.io/g/devel/message/91497
Mute This Topic: https://groups.io/mt/92473108/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules
Posted by PierreGondois 1 year, 9 months ago
Except for:
[PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed tables
[PATCH v1 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM space
where I had some remarks,

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Thanks!

On 7/19/22 02:22, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
> 
> Current DynamicTablesPkg provide great support for creating dynamic ACPI
> tables during boot time.
> 
> However, there are some modules needs minor tweaks to expand support and
> compatibility for OS requirements and platform needs.
> 
> This patch series proposes a few fixes to resolve minor issues discovered
> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
> 
> Patch v1 branch: https://github.com/kuqin12/edk2/tree/dynamic_update
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> 
> Kun Qin (6):
>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf
>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>      tables
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>      space
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>      config
> 
>   DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 200 ++++++++++++++++----
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 135 +++++++++++++
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
>   DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   1 +
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
>   5 files changed, 379 insertions(+), 38 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91582): https://edk2.groups.io/g/devel/message/91582
Mute This Topic: https://groups.io/mt/92473108/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules
Posted by Kun Qin 1 year, 9 months ago
Thank you for the review, Pierre! We will update the patches per your 
feedback and send v2 after validation.

Regards,
Kun

On 7/20/2022 6:38 AM, PierreGondois wrote:
> Except for:
> [PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check 
> for installed tables
> [PATCH v1 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to 
> reserve ECAM space
> where I had some remarks,
>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>
> Thanks!
>
> On 7/19/22 02:22, Kun Qin via groups.io wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>>
>> Current DynamicTablesPkg provide great support for creating dynamic ACPI
>> tables during boot time.
>>
>> However, there are some modules needs minor tweaks to expand support and
>> compatibility for OS requirements and platform needs.
>>
>> This patch series proposes a few fixes to resolve minor issues 
>> discovered
>> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>>
>> Patch v1 branch: https://github.com/kuqin12/edk2/tree/dynamic_update
>>
>> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>>
>> Kun Qin (6):
>>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to 
>> inf
>>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>>      tables
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>>      space
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>>      config
>>
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c 
>> | 200 ++++++++++++++++----
>> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
>> | 135 +++++++++++++
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c 
>> |  80 +++++++-
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf 
>> |   1 +
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf 
>> |   1 +
>>   5 files changed, 379 insertions(+), 38 deletions(-)
>>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91611): https://edk2.groups.io/g/devel/message/91611
Mute This Topic: https://groups.io/mt/92473108/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-