BaseTools/VolInfo: Increase define for highest section value

[edk2-devel] [PATCH] BaseTools/VolInfo: Increase define for highest section value

Posted by Konstantin Aladyshev 1 year, 9 months ago

Currently sections with unknown types are displayed as
`EFI_SECTION_SMM_DEPEX` which is wrong.
Increase the highest value for the section type to 0x1C
for correct parsing.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h b/BaseTools/Source/C/VolInfo/VolInfo.h
index 624ac38f0e..377cde80f7 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.h
+++ b/BaseTools/Source/C/VolInfo/VolInfo.h
@@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_DEP_END       0x08
 #define EFI_DEP_SOR       0x09
 
-#define EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1B
-#define EFI_SECTION_LAST_SECTION_TYPE       0x1B
+#define EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1C
+#define EFI_SECTION_LAST_SECTION_TYPE       0x1C
 
 #define OPENSSL_COMMAND_FORMAT_STRING       "%s sha1 -out %s %s"
 #define EXTRACT_COMMAND_FORMAT_STRING       "%s -d -o %s %s"
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91448): https://edk2.groups.io/g/devel/message/91448
Mute This Topic: https://groups.io/mt/92457706/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Increase define for highest section value

Posted by Bob Feng 1 year, 9 months ago

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Konstantin Aladyshev <aladyshev22@gmail.com> 
Sent: Monday, July 18, 2022 8:56 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH] BaseTools/VolInfo: Increase define for highest section value

Currently sections with unknown types are displayed as `EFI_SECTION_SMM_DEPEX` which is wrong.
Increase the highest value for the section type to 0x1C for correct parsing.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h b/BaseTools/Source/C/VolInfo/VolInfo.h
index 624ac38f0e..377cde80f7 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.h
+++ b/BaseTools/Source/C/VolInfo/VolInfo.h
@@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_DEP_END       0x08 #define EFI_DEP_SOR       0x09 -#define EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1B-#define EFI_SECTION_LAST_SECTION_TYPE       0x1B+#define EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1C+#define EFI_SECTION_LAST_SECTION_TYPE       0x1C  #define OPENSSL_COMMAND_FORMAT_STRING       "%s sha1 -out %s %s" #define EXTRACT_COMMAND_FORMAT_STRING       "%s -d -o %s %s"-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91760): https://edk2.groups.io/g/devel/message/91760
Mute This Topic: https://groups.io/mt/92457706/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Increase define for highest section value

Posted by Yuwei Chen 1 year, 9 months ago

Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>

> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Monday, July 18, 2022 8:56 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>;
> Konstantin Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH] BaseTools/VolInfo: Increase define for highest section
> value
> 
> Currently sections with unknown types are displayed as
> `EFI_SECTION_SMM_DEPEX` which is wrong.
> Increase the highest value for the section type to 0x1C for correct parsing.
> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h
> b/BaseTools/Source/C/VolInfo/VolInfo.h
> index 624ac38f0e..377cde80f7 100644
> --- a/BaseTools/Source/C/VolInfo/VolInfo.h
> +++ b/BaseTools/Source/C/VolInfo/VolInfo.h
> @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #define EFI_DEP_END       0x08 #define EFI_DEP_SOR       0x09 -#define
> EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1B-#define
> EFI_SECTION_LAST_SECTION_TYPE       0x1B+#define
> EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1C+#define
> EFI_SECTION_LAST_SECTION_TYPE       0x1C  #define
> OPENSSL_COMMAND_FORMAT_STRING       "%s sha1 -out %s %s" #define
> EXTRACT_COMMAND_FORMAT_STRING       "%s -d -o %s %s"--
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91688): https://edk2.groups.io/g/devel/message/91688
Mute This Topic: https://groups.io/mt/92457706/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-