1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition

Kun Qin posted 3 patches 1 year, 9 months ago
Failed in applying to current master (apply log)
CodeFirst/BZ3966-SpecChange.md   | 59 ++++++++++++++++++++
MdePkg/Include/Pi/PiStatusCode.h |  1 +
SecurityPkg/SecurityPkg.dec      |  6 +-
SecurityPkg/SecurityPkg.uni      |  2 +-
4 files changed, 64 insertions(+), 4 deletions(-)
create mode 100644 CodeFirst/BZ3966-SpecChange.md
[edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition
Posted by Kun Qin 1 year, 9 months ago 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/91075

v2 patch changes include feedback for v1 series:
a. Removed PCD replacement related code change;

From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as
0xD0000 (as well as included in PiStatusCode.h).

However, subclass employed as PCD for TPM peripheral in SecurityPkg is
also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when
reporting error codes.

The collision of subclass definition could cause the parsing of reported
errors being ambiguous.

This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and
removed potential usages in the SecurityPkg.

Patch v2 branch: https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass_v2

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>

Kun Qin (3):
  EDK2 Code First: PI Specification: New peripheral subclass for TPM
  MdePkg: MmCommunication: Add TPM subclass definition to MdePkg
  SecurityPkg: SubClassTpm: Updated default value

 CodeFirst/BZ3966-SpecChange.md   | 59 ++++++++++++++++++++
 MdePkg/Include/Pi/PiStatusCode.h |  1 +
 SecurityPkg/SecurityPkg.dec      |  6 +-
 SecurityPkg/SecurityPkg.uni      |  2 +-
 4 files changed, 64 insertions(+), 4 deletions(-)
 create mode 100644 CodeFirst/BZ3966-SpecChange.md

-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91330): https://edk2.groups.io/g/devel/message/91330
Mute This Topic: https://groups.io/mt/92372090/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition
Posted by Michael D Kinney 1 year, 9 months ago 
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> Sent: Wednesday, July 13, 2022 7:28 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
> Subject: [edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966
> 
> This patch series is a follow up of previous submission:
> https://edk2.groups.io/g/devel/message/91075
> 
> v2 patch changes include feedback for v1 series:
> a. Removed PCD replacement related code change;
> 
> From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as
> 0xD0000 (as well as included in PiStatusCode.h).
> 
> However, subclass employed as PCD for TPM peripheral in SecurityPkg is
> also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when
> reporting error codes.
> 
> The collision of subclass definition could cause the parsing of reported
> errors being ambiguous.
> 
> This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and
> removed potential usages in the SecurityPkg.
> 
> Patch v2 branch: https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass_v2
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> 
> Kun Qin (3):
>   EDK2 Code First: PI Specification: New peripheral subclass for TPM
>   MdePkg: MmCommunication: Add TPM subclass definition to MdePkg
>   SecurityPkg: SubClassTpm: Updated default value
> 
>  CodeFirst/BZ3966-SpecChange.md   | 59 ++++++++++++++++++++
>  MdePkg/Include/Pi/PiStatusCode.h |  1 +
>  SecurityPkg/SecurityPkg.dec      |  6 +-
>  SecurityPkg/SecurityPkg.uni      |  2 +-
>  4 files changed, 64 insertions(+), 4 deletions(-)
>  create mode 100644 CodeFirst/BZ3966-SpecChange.md
> 
> --
> 2.37.0.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91418): https://edk2.groups.io/g/devel/message/91418
Mute This Topic: https://groups.io/mt/92372090/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition
Posted by Yao, Jiewen 1 year, 9 months ago 
Reviewed by Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Saturday, July 16, 2022 12:28 AM
> To: devel@edk2.groups.io; kuqin12@gmail.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
> Subject: RE: [edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass
> definition
> 
> Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> > Sent: Wednesday, July 13, 2022 7:28 PM
> > To: devel@edk2.groups.io
> > Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao,
> > Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul1
> <rahul1.kumar@intel.com>
> > Subject: [edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass
> definition
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966
> >
> > This patch series is a follow up of previous submission:
> > https://edk2.groups.io/g/devel/message/91075
> >
> > v2 patch changes include feedback for v1 series:
> > a. Removed PCD replacement related code change;
> >
> > From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as
> > 0xD0000 (as well as included in PiStatusCode.h).
> >
> > However, subclass employed as PCD for TPM peripheral in SecurityPkg is
> > also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when
> > reporting error codes.
> >
> > The collision of subclass definition could cause the parsing of reported
> > errors being ambiguous.
> >
> > This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and
> > removed potential usages in the SecurityPkg.
> >
> > Patch v2 branch: https://github.com/kuqin12/edk2/tree/BZ3966-
> add_tpm_subclass_v2
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Qi Zhang <qi1.zhang@intel.com>
> > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> >
> > Kun Qin (3):
> >   EDK2 Code First: PI Specification: New peripheral subclass for TPM
> >   MdePkg: MmCommunication: Add TPM subclass definition to MdePkg
> >   SecurityPkg: SubClassTpm: Updated default value
> >
> >  CodeFirst/BZ3966-SpecChange.md   | 59 ++++++++++++++++++++
> >  MdePkg/Include/Pi/PiStatusCode.h |  1 +
> >  SecurityPkg/SecurityPkg.dec      |  6 +-
> >  SecurityPkg/SecurityPkg.uni      |  2 +-
> >  4 files changed, 64 insertions(+), 4 deletions(-)
> >  create mode 100644 CodeFirst/BZ3966-SpecChange.md
> >
> > --
> > 2.37.0.windows.1
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91420): https://edk2.groups.io/g/devel/message/91420
Mute This Topic: https://groups.io/mt/92372090/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.