From nobody Sat May 18 12:30:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91297+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91297+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1657691763; cv=none; d=zohomail.com; s=zohoarc; b=SyCL1Pd/pZmRZPfIdCMYmpVIu0X+s+WIZhMF8A52bUaL19Oj1DcS/Ihieg8m5kqydOB3fVj8liTNVSJ8ldW07TD+STV14GMd7tenk30x4+draYJXBKEz9XZfB7u6k7O6cyPBWj8dKzjTKY4SH/q8fiX4dmpJgib//8ZCfMDtq8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657691763; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=D5ApOnnTbH8d7jXH6a8LKVyLIQF3pz+PtF3cKFAyFH8=; b=C4TxkEmtzFaEo18ScgOzJ27+majdtxAlNVF4QJ1dltttEfLbakNrDElBRqqoVSwAf0BQ6ud6gFV2kBf+NURInvLWYU82NB7knjp+CWTjpjj5WIXr3fon+nbzSUJSPEV6fIEKK7tnAn+AR65gq+r2mLw7szdpFJ1so0+5MYyXDp4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91297+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657691763558318.7336393124185; Tue, 12 Jul 2022 22:56:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id cUY0YY1788612xeFMQQfCTW6; Tue, 12 Jul 2022 22:56:03 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.18925.1657691762325176909 for ; Tue, 12 Jul 2022 22:56:02 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="371430554" X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="371430554" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 22:56:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="772126368" X-Received: from linjaso1-desk1.gar.corp.intel.com ([10.5.215.41]) by orsmga005.jf.intel.com with ESMTP; 12 Jul 2022 22:55:59 -0700 From: "Lin, Jason1" To: devel@edk2.groups.io Cc: Jason1 Lin , Bob Feng , Liming Gao , Yuwei Chen , Isaac W Oram , Rangasai V Chaganty , Dakota Chiang Subject: [edk2-devel] [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0 Date: Wed, 13 Jul 2022 13:55:56 +0800 Message-Id: <20220713055556.2810-1-jason1.lin@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jason1.lin@intel.com X-Gm-Message-State: IxutCxyL9tPz464zWNFSy1LJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657691763; bh=gYsm9fdSmGHd6YFnbQhFaxDUk/SjXtsNo+4GeUlavxw=; h=Cc:Date:From:Reply-To:Subject:To; b=D3oGC7f1NSokmKOzw4smb3XcDlMFlNmZ9wbmYPBRzB3/0UMCu3G4+CqZDalLwyDRp9B jgAKqWbQz0T6RfXhhAiyCaRCMEcI0HtxZ6ArsKYVcQ3GOrN40bbK4/WBhP4uBFtJqzOTu l1ZylToj/wvEVvkDl1hQPjPJ4muB+vd3I78= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657691765330100002 Content-Type: text/plain; charset="utf-8" From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3988 With the change #3958 using the incorrect variable to store the S-ACM entry version. That would cause the value always 0x0. gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Version variable should be corrected to gFitTableContext.StartupAcmVersion[gFitTableContext.StartupAcmNumber]. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Isaac W Oram Cc: Rangasai V Chaganty Cc: Dakota Chiang Reviewed-by: Bob Feng Reviewed-by: Sai Chaganty --- Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitG= en/FitGen.c index 577ce48b10..21dfcf1ebb 100644 --- a/Silicon/Intel/Tools/FitGen/FitGen.c +++ b/Silicon/Intel/Tools/FitGen/FitGen.c @@ -1182,7 +1182,7 @@ Returns: gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].T= ype =3D FIT_TABLE_TYPE_STARTUP_ACM; gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].A= ddress =3D (UINT32)BiosInfoStruct[BiosInfoIndex].Address; gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].S= ize =3D (UINT32)BiosInfoStruct[BiosInfoIndex].Size; - gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].V= ersion =3D BiosInfoStruct[BiosInfoIndex].Version; + gFitTableContext.StartupAcmVersion[gFitTableContext.StartupAcmNu= mber] =3D BiosInfoStruct[BiosInfoIndex].Version; gFitTableContext.StartupAcmNumber ++; gFitTableContext.FitEntryNumber ++; break; --=20 2.37.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91297): https://edk2.groups.io/g/devel/message/91297 Mute This Topic: https://groups.io/mt/92352273/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-