From nobody Tue May 21 02:21:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90438+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90438+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1654850995; cv=none; d=zohomail.com; s=zohoarc; b=AOmZtbnp1M9lS7csS+raXrsjCX9aQp2zGdh1mtwY6b4OimBJrY2bFrP7aAuJzAz3HqpcZJNaCb6u28f3evK4hg7C1RrG4qBhdSAb88AyOc+9qo77K+yY0vBjImiJZuk8hqYE2jDSPAbvLJnFuAqjqK1eUD3K2dTOozTCJBjSksE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654850995; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=uMVDYGam2QovGWNg/PHDgKYKEN4QNqCerCs/pTXTbOE=; b=Oaklcjdfag1px5uMwNBIGx2GFEsjWfqsUhrFYJQG7oo2hfvP8c65lZs0wNhiN5OhiIB/gBw1680dPAEvc1ampZOVI38c1cPov3eE8j4fUGqqXOkDragEQTjDdiC1b7Odn0Or8ASbCj9yY2PXVog6TVRTnzMrJFHrv/FDwmrAXtI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90438+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654850995504635.4814940862922; Fri, 10 Jun 2022 01:49:55 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id iQEJYY1788612xcGfaTjqFxp; Fri, 10 Jun 2022 01:49:55 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.24625.1654850993321265702 for ; Fri, 10 Jun 2022 01:49:54 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="257999173" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="257999173" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 01:49:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="638025576" X-Received: from shwdeopenlab706.ccr.corp.intel.com ([10.239.183.102]) by fmsmga008.fm.intel.com with ESMTP; 10 Jun 2022 01:49:51 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Jian J Wang , Liming Gao Subject: [edk2-devel] [PATCH] DxeMain: Fix the bug that StackGuard is not enabled Date: Fri, 10 Jun 2022 16:49:46 +0800 Message-Id: <20220610084946.853-1-ray.ni@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com X-Gm-Message-State: QtydTxnnzvrN4TXl3SSgLrwKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654850995; bh=7BeHMLtTYnL4HVtvxnOg5pOZccdEDUOs8zDgGID5oE0=; h=Cc:Date:From:Reply-To:Subject:To; b=XTPD3/ZPNJPmuWc61FNnjIE7cmAatG2imezNzQG31TJEg4YR/HmJQN2M1HegLSViYfd sRxwOTvpBCUjd99Kyt/GPztmTQ5Uz4YXHDLcIM7rwhC+UIJfRxTsMz392Rzq2COMSZSXK ZI/ajH4Gix1GFBbEe+bsYBAanvZT6V+lZjY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654850997818100003 Content-Type: text/plain; charset="utf-8" Commit e7abb94d1 removed InitializeCpuExceptionHandlersEx and updated DxeMain to call InitializeCpuExceptionHandlers for exception setup. But the old behavior that calls *Ex() sets up the stack guard as well. To match the old behavior, the patch calls InitializeSeparateExceptionStacks. Signed-off-by: Ray Ni Cc: Jian J Wang Cc: Liming Gao Reviewed-by: Jian J Wang --- MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dx= e/DxeMain/DxeMain.c index 83f49d7c00..0a1f3d79e2 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c @@ -256,6 +256,14 @@ DxeMain ( Status =3D InitializeCpuExceptionHandlers (VectorInfoList); ASSERT_EFI_ERROR (Status); =20 + // + // Setup Stack Guard + // + if (PcdGetBool (PcdCpuStackGuard)) { + Status =3D InitializeSeparateExceptionStacks (NULL); + ASSERT_EFI_ERROR (Status); + } + // // Initialize Debug Agent to support source level debug in DXE phase // --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90438): https://edk2.groups.io/g/devel/message/90438 Mute This Topic: https://groups.io/mt/91664463/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-