From nobody Sat May 18 17:34:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90247+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90247+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1654545239; cv=none; d=zohomail.com; s=zohoarc; b=gU8TBQMtbpS3MgihGG3rbvOQ6XHxJGbjv4xXMb6Gfg/KtD7Fg9op4f1wOX7sQg/+SZ6csIF8O0z/z7/HJt3eQNsXiWhatP24fGHAMTGfjG2xSIhOZT0Xm/u/+jObFxWyAfT8DhXqSbnDs77kI6EJiWn67SWrZrAnuKmz0I6d/vg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654545239; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=x4smGNCXT9GNm+X6/U696Wj+3/MPhlJR0VQT08orD6c=; b=LYYBvdO4KuvCqTReVFNTIdfPjPdb1vasiyI7sVDPEitJPIjIjC9yyrqHCjJa/SqEFTQxm78x+trE6CKXJPKfUctTvjZKbJS0t8Z3yy7meuMSVjp11wmaVeAJH2joD4vsCb9bPVJgHidXW43d9PaYuq2R1Om+JecyXN1POtKnm/Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90247+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654545239458745.2228713864868; Mon, 6 Jun 2022 12:53:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id cxdWYY1788612xTe9VZwzFhp; Mon, 06 Jun 2022 12:53:59 -0700 X-Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web09.3062.1654545238149979493 for ; Mon, 06 Jun 2022 12:53:58 -0700 X-Received: by mail-pg1-f169.google.com with SMTP id s68so13776557pgs.10 for ; Mon, 06 Jun 2022 12:53:58 -0700 (PDT) X-Gm-Message-State: r0UobOp8KYe8PVzQF1eMzlTMx1787277AA= X-Google-Smtp-Source: ABdhPJwRiwqHtjGwcmo3Zlyw0wOfRc5tV2Pu6p00uxvAtVCB43qetMVDjNk3kVzZAxkOSt3bWvZABA== X-Received: by 2002:a62:b60f:0:b0:508:2a61:2c8b with SMTP id j15-20020a62b60f000000b005082a612c8bmr92825369pff.2.1654545237523; Mon, 06 Jun 2022 12:53:57 -0700 (PDT) X-Received: from localhost.localdomain ([50.35.66.9]) by smtp.gmail.com with ESMTPSA id p2-20020a170902c70200b001617541c94fsm10911707plp.60.2022.06.06.12.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 12:53:57 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Michael Kubacki Subject: [edk2-devel] [PATCH V1 1/1] .pytool: UncrustifyCheck: Set IgnoreFiles path relative to package path Date: Mon, 6 Jun 2022 12:52:54 -0700 Message-Id: <20220606195254.348-2-kuqin12@gmail.com> In-Reply-To: <20220606195254.348-1-kuqin12@gmail.com> References: <20220606195254.348-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654545239; bh=kjCuxX44DqzKHvD5uf+MEwAtslaJe4qNBMYU2ceSjc0=; h=Cc:Date:From:Reply-To:Subject:To; b=xGLrHTnRYN7f1RwEqTq+XqUiKjV8DIZOiGPAgVjNiRt4tVosc0iyf54K8VhVEQKgeey ThB8eyrzYfwzHWkk46h6DuvLP0dINInrOJ/WTohAm4HHXQuMyzWS5gQlx2dvz3QP3kPmG xMm/0889IiezNOKmmntodWX7W+j2JIUh2rI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654545240086100004 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3942 `IgnoreFiles` tag is specified in the CI YAML files in each individual packages. The current logic for UncrustifyCheck script bases specified file paths from workspace, which requires the package name to be included in each entry. This change updates the ignore checking logic to be based on current package path in order to reduce redundancy. It also keeps the consistency of `IgnoreFiles` field other pytools such as SpellCheck and EccCheck. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Kun Qin Reviewed-by: Michael Kubacki --- .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Pl= ugin/UncrustifyCheck/UncrustifyCheck.py index 00d78864656f..8dc9ffe6945a 100644 --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py @@ -290,7 +290,7 @@ class UncrustifyCheck(ICiBuildPlugin): # This information is only used for reporting (not used here) and # the ignore lines are being passed directly as they are given to # this plugin. - return parse_gitignore_lines(ignored_files, "Package configuration= file", self._abs_workspace_path) + return parse_gitignore_lines(ignored_files, "Package configuration= file", self._abs_package_path) =20 def _get_git_ignored_paths(self) -> List[str]: """" --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90247): https://edk2.groups.io/g/devel/message/90247 Mute This Topic: https://groups.io/mt/91585839/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-