1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

Michael Kubacki posted 10 patches 2 years ago
Failed in applying to current master (apply log)
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
12 files changed, 12 insertions(+)
[edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Posted by Michael Kubacki 2 years ago 
From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Note that this series is for an upcoming change in MdeModulePkg
and requires that change to be present locally for testing.

https://edk2.groups.io/g/devel/message/88787

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Jeremy Linton <jeremy.linton@arm.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (10):
  OverdriveBoard: Add VariableFlashInfoLib
  BeagleBoardPkg: Add VariableFlashInfoLib
  MinPlatformPkg: Add VariableFlashInfoLib
  CelloBoard: Add VariableFlashInfoLib
  SbsaQemu: Add VariableFlashInfoLib
  RaspberryPi: Add VariableFlashInfoLib
  U5SeriesPkg: Add VariableFlashInfoLib
  Socionext: Add VariableFlashInfoLib
  Softiron: Add VariableFlashInfoLib
  PlatformStandaloneMmPkg: Add VariableFlashInfoLib

 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
 Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
 Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
 Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
 12 files changed, 12 insertions(+)

-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89148): https://edk2.groups.io/g/devel/message/89148
Mute This Topic: https://groups.io/mt/90592905/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Posted by Sami Mujawar 2 years ago 
Hi Michael,

There are other platforms in edk2-platforms that would possibly require 
similar changes.

e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc, 
Platform\ARM\JunoPkg\ArmJuno.dsc, etc.

Do you plan to submit patches to update these platforms as well?

Regards,

Sami Mujawar

On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
>
> Note that this series is for an upcoming change in MdeModulePkg
> and requires that change to be present locally for testing.
>
> https://edk2.groups.io/g/devel/message/88787
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (10):
>    OverdriveBoard: Add VariableFlashInfoLib
>    BeagleBoardPkg: Add VariableFlashInfoLib
>    MinPlatformPkg: Add VariableFlashInfoLib
>    CelloBoard: Add VariableFlashInfoLib
>    SbsaQemu: Add VariableFlashInfoLib
>    RaspberryPi: Add VariableFlashInfoLib
>    U5SeriesPkg: Add VariableFlashInfoLib
>    Socionext: Add VariableFlashInfoLib
>    Softiron: Add VariableFlashInfoLib
>    PlatformStandaloneMmPkg: Add VariableFlashInfoLib
>
>   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
>   Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
>   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
>   Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
>   Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
>   Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
>   Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
>   Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
>   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>   12 files changed, 12 insertions(+)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89279): https://edk2.groups.io/g/devel/message/89279
Mute This Topic: https://groups.io/mt/90592905/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Posted by Michael Kubacki 2 years ago 
Thanks for pointing those out. It looks like ArmVExpress.dsc.inc can 
include it for both of those platforms. I'll add that in a V2.

Regards,
Michael

On 4/25/2022 12:06 PM, Sami Mujawar wrote:
> Hi Michael,
> 
> There are other platforms in edk2-platforms that would possibly require 
> similar changes.
> 
> e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc, 
> Platform\ARM\JunoPkg\ArmJuno.dsc, etc.
> 
> Do you plan to submit patches to update these platforms as well?
> 
> Regards,
> 
> Sami Mujawar
> 
> On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Adds an instance for the library class VariableFlashInfoLib that
>> was recently introduced in MdeModulePkg. This change is made to
>> allow the new variable driver to build that has a dependency on
>> this library class and does not require any further platform
>> changes.
>>
>> Note that this series is for an upcoming change in MdeModulePkg
>> and requires that change to be present locally for testing.
>>
>> https://edk2.groups.io/g/devel/message/88787
>>
>> Cc: Abner Chang <abner.chang@hpe.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Gilbert Chen <gilbert.chen@hpe.com>
>> Cc: Graeme Gregory <graeme@nuviainc.com>
>> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>> Cc: Jeremy Linton <jeremy.linton@arm.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Radoslaw Biernacki <rad@semihalf.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (10):
>>    OverdriveBoard: Add VariableFlashInfoLib
>>    BeagleBoardPkg: Add VariableFlashInfoLib
>>    MinPlatformPkg: Add VariableFlashInfoLib
>>    CelloBoard: Add VariableFlashInfoLib
>>    SbsaQemu: Add VariableFlashInfoLib
>>    RaspberryPi: Add VariableFlashInfoLib
>>    U5SeriesPkg: Add VariableFlashInfoLib
>>    Socionext: Add VariableFlashInfoLib
>>    Softiron: Add VariableFlashInfoLib
>>    PlatformStandaloneMmPkg: Add VariableFlashInfoLib
>>
>>   
>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             
>> | 1 +
>>   
>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     
>> | 1 +
>>   
>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                
>> | 1 +
>>   
>> Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 
>> | 1 +
>>   
>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        
>> | 1 +
>>   
>> Platform/RaspberryPi/RPi3/RPi3.dsc                                         
>> | 1 +
>>   
>> Platform/RaspberryPi/RPi4/RPi4.dsc                                         
>> | 1 +
>>   
>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 
>> | 1 +
>>   
>> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       
>> | 1 +
>>   
>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               
>> | 1 +
>>   
>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                
>> | 1 +
>>   
>> Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc 
>> | 1 +
>>   12 files changed, 12 insertions(+)
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89290): https://edk2.groups.io/g/devel/message/89290
Mute This Topic: https://groups.io/mt/90592905/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Posted by Michael D Kinney 2 years ago 
Hi Michael,

1) This patch series is dependent on the edk2 repo patch series that adds the 
   VariableFlashInfoLib.  This patch series cannot be committed until the 
   edk2 changes are committed because it will break all the edk2-platforms
   if this one is committed first.

2) The related edk2 changes are a breaking change for all downstream platforms
   that also need to add VariableFlashInfoLib to their DSC files.

   Should breaking changes like this also require a separate email that
   is sent to devel@edk2.groups.io, announce@edk2.groups.io, and discuss@edk2.groups.io
   to increase the visibility of breaking changes?


Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


Best regards,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Wednesday, April 20, 2022 1:44 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <abner.chang@hpe.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chiu, Chasel <chasel.chiu@intel.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; Dong, Eric <eric.dong@intel.com>; Gilbert Chen <gilbert.chen@hpe.com>; Graeme Gregory
> <graeme@nuviainc.com>; Ilias Apalodimas <ilias.apalodimas@linaro.org>; Jeremy Linton <jeremy.linton@arm.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Masami Hiramatsu <masami.hiramatsu@linaro.org>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Radoslaw Biernacki <rad@semihalf.com>; Sami Mujawar <sami.mujawar@arm.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
> 
> Note that this series is for an upcoming change in MdeModulePkg
> and requires that change to be present locally for testing.
> 
> https://edk2.groups.io/g/devel/message/88787
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (10):
>   OverdriveBoard: Add VariableFlashInfoLib
>   BeagleBoardPkg: Add VariableFlashInfoLib
>   MinPlatformPkg: Add VariableFlashInfoLib
>   CelloBoard: Add VariableFlashInfoLib
>   SbsaQemu: Add VariableFlashInfoLib
>   RaspberryPi: Add VariableFlashInfoLib
>   U5SeriesPkg: Add VariableFlashInfoLib
>   Socionext: Add VariableFlashInfoLib
>   Softiron: Add VariableFlashInfoLib
>   PlatformStandaloneMmPkg: Add VariableFlashInfoLib
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
>  Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
>  Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>  12 files changed, 12 insertions(+)
> 
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#89148): https://edk2.groups.io/g/devel/message/89148
> Mute This Topic: https://groups.io/mt/90592905/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89240): https://edk2.groups.io/g/devel/message/89240
Mute This Topic: https://groups.io/mt/90592905/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.