1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

Michael Kubacki posted 3 patches 2 years ago
Failed in applying to current master (apply log)
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
7 files changed, 29 insertions(+), 4 deletions(-)
[edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Posted by Michael Kubacki 2 years ago 
From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
(board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (3):
  MinPlatformPkg: Add FADT duty offset and duty width PCDs
  MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
  SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
 7 files changed, 29 insertions(+), 4 deletions(-)

-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88721): https://edk2.groups.io/g/devel/message/88721
Mute This Topic: https://groups.io/mt/90405218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Posted by Sinha, Ankit 2 years ago 
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Monday, April 11, 2022 1:58 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add
> FADT duty offset and width PCDs
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in
> their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the
> change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>   MinPlatformPkg: Add FADT duty offset and duty width PCDs
>   MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>   SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> |  3 +++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |
> 4 ++--
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Acp
> iPlatform.c   |  3 +++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fad
> t/Fadt.c      |  4 ++--
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> |  2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15
> +++++++++++++++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Acp
> iPlatform.inf |  2 ++
>  7 files changed, 29 insertions(+), 4 deletions(-)
> 
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#88721): https://edk2.groups.io/g/devel/message/88721
> Mute This Topic: https://groups.io/mt/90405218/1772825
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88747): https://edk2.groups.io/g/devel/message/88747
Mute This Topic: https://groups.io/mt/90405218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Posted by Nate DeSimone 1 year, 10 months ago 
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> 
Sent: Monday, April 11, 2022 1:58 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (3):
  MinPlatformPkg: Add FADT duty offset and duty width PCDs
  MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
  SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
 7 files changed, 29 insertions(+), 4 deletions(-)

--
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90249): https://edk2.groups.io/g/devel/message/90249
Mute This Topic: https://groups.io/mt/90405218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Posted by Chiu, Chasel 2 years ago 
Thanks Michael!
For this patch series: Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, April 12, 2022 4:58 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty
> offset and width PCDs
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values
> in their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep
> the change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>   MinPlatformPkg: Add FADT duty offset and duty width PCDs
>   MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>   SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> |  3 +++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
> |  4 ++--
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
> piPlatform.c   |  3 +++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa
> dt/Fadt.c      |  4 ++--
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> |  2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    |
> 15 +++++++++++++++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
> piPlatform.inf |  2 ++
>  7 files changed, 29 insertions(+), 4 deletions(-)
> 
> --
> 2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89251): https://edk2.groups.io/g/devel/message/89251
Mute This Topic: https://groups.io/mt/90405218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Posted by Michael Kubacki 2 years ago 
Thanks Chasel. I pushed a branch rebased on the latest master branch 
with R-b tags here in case that helps with merging:

https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Regards,
Michael

On 4/25/2022 12:08 AM, Chiu, Chasel wrote:
> 
> Thanks Michael!
> For this patch series: Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> 
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Tuesday, April 12, 2022 4:58 AM
>> To: devel@edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>> Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty
>> offset and width PCDs
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>
>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values
>> in their build files.
>>
>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep
>> the change in sync with the source MinPlatformPkg module.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (3):
>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>
>>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
>> |  3 +++
>>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
>> |  4 ++--
>>
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
>> piPlatform.c   |  3 +++
>>
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa
>> dt/Fadt.c      |  4 ++--
>>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
>> |  2 ++
>>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    |
>> 15 +++++++++++++++
>>
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
>> piPlatform.inf |  2 ++
>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>
>> --
>> 2.28.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89323): https://edk2.groups.io/g/devel/message/89323
Mute This Topic: https://groups.io/mt/90405218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Posted by Nate DeSimone 1 year, 10 months ago 
The series has been pushed as ~3018b1f..61af470

-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> 
Sent: Monday, April 11, 2022 1:58 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (3):
  MinPlatformPkg: Add FADT duty offset and duty width PCDs
  MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
  SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
 7 files changed, 29 insertions(+), 4 deletions(-)

--
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90250): https://edk2.groups.io/g/devel/message/90250
Mute This Topic: https://groups.io/mt/90405218/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.