From nobody Thu May 16 11:50:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88692+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88692+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1649672051; cv=none; d=zohomail.com; s=zohoarc; b=DQ9hPG6YUUcUXIKk7MezqeeieNwP9e+qpizkruk5/Ww5+srgqsRfINmS4qH/vwP5377EUGsymEq2YWLp81aS+DdL7CVJ8OinwWNuZ3q7udezkB85JfqId2p4vzoNpdvo11s8/lM3LtXcrXiN4vhDaf8bGr04P5vWJQeXrpVaymw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649672051; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=/G2/z3iIBxqyI3GtrLayd4adlrILRM5xxbpfdsFKpZk=; b=GBFD12n0xMa7i+RCZNhbnw4Osn9hu4azFOlb9SIwVJi1XgrBNeQhoF36aOHDWLBkoolpVdUTywr9UaS65QJlIA6sBhlCCbK33rHVqR/LlxDai4rCfEq96RvazXyDqdL84tQVo4/vSysoPnHKQrOH43Kst/F7BYaxJmIWk6MMMak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88692+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1649672051456882.5590890733614; Mon, 11 Apr 2022 03:14:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id H9b0YY1788612x3oFQqfRHHD; Mon, 11 Apr 2022 03:14:08 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.27850.1649672047375397921 for ; Mon, 11 Apr 2022 03:14:08 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="259677092" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="259677092" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:14:06 -0700 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="572060693" X-Received: from gchen29.sh.intel.com ([10.239.154.135]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:14:04 -0700 From: "Chen, Gang C" To: devel@edk2.groups.io Cc: guomin.jiang@intel.com, dandan.bi@intel.com, di.zhang@intel.com, Jian J Wang , Liming Gao Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property Date: Mon, 11 Apr 2022 18:13:49 +0800 Message-Id: <20220411101350.697997-2-gang.c.chen@intel.com> In-Reply-To: <20220411101350.697997-1-gang.c.chen@intel.com> References: <20220411101350.697997-1-gang.c.chen@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gang.c.chen@intel.com X-Gm-Message-State: QojHEtejjSVviN3Aex3pjZVtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1649672048; bh=rgZ2x1SMxxQVHCWIbc9SyXYLEeRRNq+aOUUx0Aq/ZXM=; h=Cc:Date:From:Reply-To:Subject:To; b=UiKpBGYrbnhs8KyxeAX2Mw7wT2N3yQu17KEpE10ONlTxA4w+IbFrbMCtVUY6jgciWZr YUihmMJe4roEF2cdGJ9RDCkvl6GYSUadNKKXSISGHzvfWBcCotPQxvCPgGDHps8q3kREg BRUx7czANVPqiPXEqrsHpLec4NkD2y0QWBw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1649672052021100002 Content-Type: text/plain; charset="utf-8" Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx for the requirement to set different value in FSP API mode and FSP Dispatch mode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3897 Cc: Jian J Wang Cc: Liming Gao Cc: devel@edk2.groups.io Signed-off-by: Gang Chen --- MdeModulePkg/MdeModulePkg.dec | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 463e889e9a..72e7e2eced 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1070,13 +1070,6 @@ # @Prompt The Heap Guard feature mask gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0|UINT8|0x3000= 1054 =20 - ## Indicates if UEFI Stack Guard will be enabled. - # If enabled, stack overflow in UEFI can be caught, preventing chaotic = consequences.

- # TRUE - UEFI Stack Guard will be enabled.
- # FALSE - UEFI Stack Guard will be disabled.
- # @Prompt Enable UEFI Stack Guard. - gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x30001055 - [PcdsFixedAtBuild, PcdsPatchableInModule] ## Dynamic type PCD can be registered callback function for Pcd setting = action. # PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum number of= callback function @@ -2079,6 +2072,13 @@ # @Prompt Enable PCIe Resizable BAR Capability support. gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEAN|= 0x10000024 =20 + ## Indicates if UEFI Stack Guard will be enabled. + # If enabled, stack overflow in UEFI can be caught, preventing chaotic = consequences.

+ # TRUE - UEFI Stack Guard will be enabled.
+ # FALSE - UEFI Stack Guard will be disabled.
+ # @Prompt Enable UEFI Stack Guard. + gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x00010025 + [PcdsPatchableInModule] ## Specify memory size with page number for PEI code when # Loading Module at Fixed Address feature is enabled. --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88692): https://edk2.groups.io/g/devel/message/88692 Mute This Topic: https://groups.io/mt/90391665/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 16 11:50:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88693+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88693+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1649672052; cv=none; d=zohomail.com; s=zohoarc; b=fekDOokUUKNttoBMzMsPbBO5Yij3x5K18B9DQIPhm0eplvjWlzrtVhz8my6SCbAB3zJr9a1cDafWlDgzLYMqdtCtKKNeKfT3zaU54PW0ATkCEt+um2ojo25wq4iQy7XtCOj/cot9hIGxG3WksY1Hl5UntKJwv32tsBL/sq/kJ3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649672052; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=A9wAq5PpB4cXenrHPxskmHSwvO88phrfCaqCWx+3OB0=; b=Yg0SOven+IPqm9CY68LH47oJAiR+BQ8FVwEZ3I4lIxWrNroqZuFRIwcsXbB7uTagKekGDjdtG61YfSc0EUw7ODgzDd+ZLwnnC8tu0WJSHA2INFHIGbHwBOEPdRuccg4Ya5DjF7207j/eESw87L5LktViEjHISca5G/uJ/ASN4uo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88693+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1649672052956218.52185168758785; Mon, 11 Apr 2022 03:14:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id JsVWYY1788612xCiw6SfhTA1; Mon, 11 Apr 2022 03:14:11 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.27850.1649672047375397921 for ; Mon, 11 Apr 2022 03:14:11 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="259677117" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="259677117" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:14:10 -0700 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="572060737" X-Received: from gchen29.sh.intel.com ([10.239.154.135]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:14:08 -0700 From: "Chen, Gang C" To: devel@edk2.groups.io Cc: guomin.jiang@intel.com, dandan.bi@intel.com, di.zhang@intel.com, Eric Dong , Ray Ni , Rahul Kumar Subject: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: remove duplicated pcd check Date: Mon, 11 Apr 2022 18:13:50 +0800 Message-Id: <20220411101350.697997-3-gang.c.chen@intel.com> In-Reply-To: <20220411101350.697997-1-gang.c.chen@intel.com> References: <20220411101350.697997-1-gang.c.chen@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gang.c.chen@intel.com X-Gm-Message-State: W7VwJEKIZ5LU4FiJSyyoGj3ux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1649672051; bh=cd+br7IVvuZnyhnGkaoYsVfrK9DiYQ1ymNf9UBsstV0=; h=Cc:Date:From:Reply-To:Subject:To; b=uWFq0pnqzRDtVFO5o2qJyndCSfIBsgwTaRUyiK08zweyG0jJEO38/c9IWgIHcTnO5tw inKGGU4fLoro0gWGoe1ax0HIhKozhvQU5RoEHSXlV5ayryUJ0uGQHS7MbHxMjVvEICO7e 9lmtVF2EnmLefs88u2lzCtUbFIeVJFOvEwk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1649672054356100007 Content-Type: text/plain; charset="utf-8" Remove the duplicated PcdCpuStackGuard check for it has been checked at the entry of InitializeMpExceptionStackSwitchHandlers, which will invoke the current function. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3897 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: devel@edk2.groups.io Signed-off-by: Gang Chen --- UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/= UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c index 687fc4177f..bcd4175ffa 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c @@ -254,7 +254,7 @@ InitializeCpuExceptionHandlersEx ( // // Initializing stack switch is only necessary for Stack Guard functio= nality. // - if (PcdGetBool (PcdCpuStackGuard) && (InitData !=3D NULL)) { + if (InitData !=3D NULL) { Status =3D ArchSetupExceptionStack (InitData); } } --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88693): https://edk2.groups.io/g/devel/message/88693 Mute This Topic: https://groups.io/mt/90391666/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-