[edk2-devel] [PATCH edk2-platforms 0/2] Replace individual CRC implementations with BaseLib

Pedro Falcato posted 2 patches 2 years, 1 month ago
Failed in applying to current master (apply log)
Features/Ext4Pkg/Ext4Dxe/Crc16.c              | 75 -----------------
Features/Ext4Pkg/Ext4Dxe/Crc32c.c             | 84 -------------------
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h            | 34 +-------
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf          |  2 -
.../Include/Library/CrcLib.h                  | 42 ----------
.../AcpiPlatformLibBdat.c                     | 46 +++-------
.../Library/BaseCrcLib/BaseCrcLib.c           | 71 ----------------
.../Library/BaseCrcLib/BaseCrcLib.inf         | 23 -----
.../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc |  1 -
9 files changed, 13 insertions(+), 365 deletions(-)
delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c
delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h
delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.c
delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.inf
[edk2-devel] [PATCH edk2-platforms 0/2] Replace individual CRC implementations with BaseLib
Posted by Pedro Falcato 2 years, 1 month ago
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871

This patch-set replaces the individual CRC16 implementations in Ext4Pkg and WhitleyOpenBoardPkg
with the soon-to-be-merged BaseLib implementation of CalculateCrc16().

These patches should not be merged before the BaseLib one, but also not too long after,
as the BaseLib changes will certainly break these packages' builds.
I encourage the platform maintainers to build and test my changes as I couldn't build them nor
test them (although everything looks good from a bird's eye view).

Also CC'ing the platforms maintainers as I can't review my own patches :)

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>

Pedro Falcato (2):
  Ext4Pkg: Replace the CRC implementations with BaseLib
  WhitleyOpenBoardPkg: Replace BaseCrcLib with BaseLib

 Features/Ext4Pkg/Ext4Dxe/Crc16.c              | 75 -----------------
 Features/Ext4Pkg/Ext4Dxe/Crc32c.c             | 84 -------------------
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h            | 34 +-------
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf          |  2 -
 .../Include/Library/CrcLib.h                  | 42 ----------
 .../AcpiPlatformLibBdat.c                     | 46 +++-------
 .../Library/BaseCrcLib/BaseCrcLib.c           | 71 ----------------
 .../Library/BaseCrcLib/BaseCrcLib.inf         | 23 -----
 .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc |  1 -
 9 files changed, 13 insertions(+), 365 deletions(-)
 delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
 delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c
 delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h
 delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.c
 delete mode 100644 Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.inf

-- 
2.35.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88075): https://edk2.groups.io/g/devel/message/88075
Mute This Topic: https://groups.io/mt/90054865/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-