From nobody Wed May 15 00:25:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88073+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88073+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1648342673; cv=none; d=zohomail.com; s=zohoarc; b=QT/utwieesiyREl2NgO1SQk99vFJsytRODO1SIrPKzoSiX1Sl9MxlWIDMn/khinn28dgSRFbSZeTAhK2BacbcQYjB5hzmlCwusJHTEfABh1Hd6SEfBQCvbGwsj3e1gwqYsBbVrJT53DdqSxLsXOe+VSTKitbkr1iQJIubYnB72Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648342673; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=67hTokRK00x84KaISt+QIxWQ5yONXe7v/Q4xaZI5bJE=; b=bB9+YHaHj1/2EaNKdiNdV2W1j0XfiJuXVFMWUmY2hp/JkmrNIKsPgjBb6ZIrSCnWRzd3ou+1I4N9AHJBzVxOAGODUfls9n9RyTpPVFNtVBJbVqy3RBhL0X7mIRfkLUDeYqcNUFLeOqshcxlQmRbA2Lp8KIGf8faqTliWxWkr/78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88073+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1648342673956413.39018038740755; Sat, 26 Mar 2022 17:57:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sGg3YY1788612xYQSRFIztAB; Sat, 26 Mar 2022 17:57:53 -0700 X-Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web09.1276.1648342672490147924 for ; Sat, 26 Mar 2022 17:57:52 -0700 X-Received: by mail-wr1-f49.google.com with SMTP id a1so15521977wrh.10 for ; Sat, 26 Mar 2022 17:57:52 -0700 (PDT) X-Gm-Message-State: TaH6uj10dRx4maLmuI1SbJofx1787277AA= X-Google-Smtp-Source: ABdhPJyzOR+NB8LdEBTIamKYmS8Dvx1ydb4ctIt7Qy6UNjIjcG7zdIKIkfTRqxPEsxnZtPMm1EhXxw== X-Received: by 2002:adf:d1cc:0:b0:203:e857:85b4 with SMTP id b12-20020adfd1cc000000b00203e85785b4mr15119215wrd.666.1648342670840; Sat, 26 Mar 2022 17:57:50 -0700 (PDT) X-Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id b3-20020adfd1c3000000b00205820686dasm10143304wrd.5.2022.03.26.17.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 17:57:50 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH 1/2] MdePkg/BaseLib: Add CRC16 and CRC32c implementations Date: Sun, 27 Mar 2022 00:57:47 +0000 Message-Id: <20220327005748.92041-2-pedro.falcato@gmail.com> In-Reply-To: <20220327005748.92041-1-pedro.falcato@gmail.com> References: <20220327005748.92041-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648342673; bh=2wgv76eXh+RmqOEjcB+4cp1Civly1w+Qc6MTP+WamjQ=; h=Cc:Date:From:Reply-To:Subject:To; b=jeOwacbYgbes+aHZOvKqzxbtKJ0AgA5VJhMHYBLMjEC/hS9tGR7RtTWJmZODw9H77CM R9ANLzquhtqGDvZPa2Xmjfp7YjCXD7J4N6FPzXCr+QiSz2lgvzFfJOvd5d4d1frGMzA1c mHFVqkLbapiKJl3cmpNA8XoOMaNo667xoVg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648342674149100002 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 Add the crc16 and crc32c implementations previously found at Features/Ext4Pkg/Ext4Dxe/Crc{16,32c}.c to BaseLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Pedro Falcato --- MdePkg/Include/Library/BaseLib.h | 35 +++++++- MdePkg/Library/BaseLib/CheckSum.c | 144 ++++++++++++++++++++++++++++++ 2 files changed, 178 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/Base= Lib.h index 6aa0d972186e..c2819fdfc3f0 100644 --- a/MdePkg/Include/Library/BaseLib.h +++ b/MdePkg/Include/Library/BaseLib.h @@ -4503,6 +4503,40 @@ CalculateCrc32 ( IN UINTN Length ); =20 +/** + Calculates the CRC16 checksum of the given buffer. + + @param[in] Buffer Pointer to the buffer. + @param[in] Length Length of the buffer, in bytes. + @param[in] InitialValue Initial value of the CRC. + + @return The CRC16 checksum. +**/ +UINT16 +EFIAPI +CalculateCrc16 ( + IN CONST VOID *Buffer, + IN UINTN Length, + IN UINT16 InitialValue + ); + +/** + Calculates the CRC32c checksum of the given buffer. + + @param[in] Buffer Pointer to the buffer. + @param[in] Length Length of the buffer, in bytes. + @param[in] InitialValue Initial value of the CRC. + + @return The CRC32c checksum. +**/ +UINT32 +EFIAPI +CalculateCrc32c ( + IN CONST VOID *Buffer, + IN UINTN Length, + IN UINT32 InitialValue + ); + // // Base Library CPU Functions // @@ -4512,7 +4546,6 @@ CalculateCrc32 ( =20 @param Context1 Context1 parameter passed into SwitchStack(). @param Context2 Context2 parameter passed into SwitchStack(). - **/ typedef VOID diff --git a/MdePkg/Library/BaseLib/CheckSum.c b/MdePkg/Library/BaseLib/Che= ckSum.c index 28dee5ac6a15..b4ec72bbadf7 100644 --- a/MdePkg/Library/BaseLib/CheckSum.c +++ b/MdePkg/Library/BaseLib/CheckSum.c @@ -3,6 +3,7 @@ algorithm. =20 Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2022, Pedro Falcato. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -618,3 +619,146 @@ CalculateCrc32 ( =20 return Crc ^ 0xffffffff; } + +GLOBAL_REMOVE_IF_UNREFERENCED STATIC CONST UINT16 mCrc16LookupTable[256] = =3D +{ + 0x0000, 0x1189, 0x2312, 0x329b, 0x4624, 0x57ad, 0x6536, 0x74bf, + 0x8c48, 0x9dc1, 0xaf5a, 0xbed3, 0xca6c, 0xdbe5, 0xe97e, 0xf8f7, + 0x0919, 0x1890, 0x2a0b, 0x3b82, 0x4f3d, 0x5eb4, 0x6c2f, 0x7da6, + 0x8551, 0x94d8, 0xa643, 0xb7ca, 0xc375, 0xd2fc, 0xe067, 0xf1ee, + 0x1232, 0x03bb, 0x3120, 0x20a9, 0x5416, 0x459f, 0x7704, 0x668d, + 0x9e7a, 0x8ff3, 0xbd68, 0xace1, 0xd85e, 0xc9d7, 0xfb4c, 0xeac5, + 0x1b2b, 0x0aa2, 0x3839, 0x29b0, 0x5d0f, 0x4c86, 0x7e1d, 0x6f94, + 0x9763, 0x86ea, 0xb471, 0xa5f8, 0xd147, 0xc0ce, 0xf255, 0xe3dc, + 0x2464, 0x35ed, 0x0776, 0x16ff, 0x6240, 0x73c9, 0x4152, 0x50db, + 0xa82c, 0xb9a5, 0x8b3e, 0x9ab7, 0xee08, 0xff81, 0xcd1a, 0xdc93, + 0x2d7d, 0x3cf4, 0x0e6f, 0x1fe6, 0x6b59, 0x7ad0, 0x484b, 0x59c2, + 0xa135, 0xb0bc, 0x8227, 0x93ae, 0xe711, 0xf698, 0xc403, 0xd58a, + 0x3656, 0x27df, 0x1544, 0x04cd, 0x7072, 0x61fb, 0x5360, 0x42e9, + 0xba1e, 0xab97, 0x990c, 0x8885, 0xfc3a, 0xedb3, 0xdf28, 0xcea1, + 0x3f4f, 0x2ec6, 0x1c5d, 0x0dd4, 0x796b, 0x68e2, 0x5a79, 0x4bf0, + 0xb307, 0xa28e, 0x9015, 0x819c, 0xf523, 0xe4aa, 0xd631, 0xc7b8, + 0x48c8, 0x5941, 0x6bda, 0x7a53, 0x0eec, 0x1f65, 0x2dfe, 0x3c77, + 0xc480, 0xd509, 0xe792, 0xf61b, 0x82a4, 0x932d, 0xa1b6, 0xb03f, + 0x41d1, 0x5058, 0x62c3, 0x734a, 0x07f5, 0x167c, 0x24e7, 0x356e, + 0xcd99, 0xdc10, 0xee8b, 0xff02, 0x8bbd, 0x9a34, 0xa8af, 0xb926, + 0x5afa, 0x4b73, 0x79e8, 0x6861, 0x1cde, 0x0d57, 0x3fcc, 0x2e45, + 0xd6b2, 0xc73b, 0xf5a0, 0xe429, 0x9096, 0x811f, 0xb384, 0xa20d, + 0x53e3, 0x426a, 0x70f1, 0x6178, 0x15c7, 0x044e, 0x36d5, 0x275c, + 0xdfab, 0xce22, 0xfcb9, 0xed30, 0x998f, 0x8806, 0xba9d, 0xab14, + 0x6cac, 0x7d25, 0x4fbe, 0x5e37, 0x2a88, 0x3b01, 0x099a, 0x1813, + 0xe0e4, 0xf16d, 0xc3f6, 0xd27f, 0xa6c0, 0xb749, 0x85d2, 0x945b, + 0x65b5, 0x743c, 0x46a7, 0x572e, 0x2391, 0x3218, 0x0083, 0x110a, + 0xe9fd, 0xf874, 0xcaef, 0xdb66, 0xafd9, 0xbe50, 0x8ccb, 0x9d42, + 0x7e9e, 0x6f17, 0x5d8c, 0x4c05, 0x38ba, 0x2933, 0x1ba8, 0x0a21, + 0xf2d6, 0xe35f, 0xd1c4, 0xc04d, 0xb4f2, 0xa57b, 0x97e0, 0x8669, + 0x7787, 0x660e, 0x5495, 0x451c, 0x31a3, 0x202a, 0x12b1, 0x0338, + 0xfbcf, 0xea46, 0xd8dd, 0xc954, 0xbdeb, 0xac62, 0x9ef9, 0x8f70 +}; + +/** + Calculates the CRC16 checksum of the given buffer. + + @param[in] Buffer Pointer to the buffer. + @param[in] Length Length of the buffer, in bytes. + @param[in] InitialValue Initial value of the CRC. + + @return The CRC16 checksum. +**/ +UINT16 +EFIAPI +CalculateCrc16 ( + IN CONST VOID *Buffer, + IN UINTN Length, + IN UINT16 InitialValue + ) +{ + CONST UINT8 *Buf; + UINT16 Crc; + + Buf =3D Buffer; + + Crc =3D ~InitialValue; + + while (Length-- !=3D 0) { + Crc =3D mCrc16LookupTable[(Crc & 0xFF) ^ *(Buf++)] ^ (Crc >> 8); + } + + return ~Crc; +} + +GLOBAL_REMOVE_IF_UNREFERENCED STATIC CONST UINT32 mCrc32cLookupTable[256]= =3D { + 0x00000000, 0xf26b8303, 0xe13b70f7, 0x1350f3f4, 0xc79a971f, 0x35f1141c, + 0x26a1e7e8, 0xd4ca64eb, 0x8ad958cf, 0x78b2dbcc, 0x6be22838, 0x9989ab3b, + 0x4d43cfd0, 0xbf284cd3, 0xac78bf27, 0x5e133c24, 0x105ec76f, 0xe235446c, + 0xf165b798, 0x030e349b, 0xd7c45070, 0x25afd373, 0x36ff2087, 0xc494a384, + 0x9a879fa0, 0x68ec1ca3, 0x7bbcef57, 0x89d76c54, 0x5d1d08bf, 0xaf768bbc, + 0xbc267848, 0x4e4dfb4b, 0x20bd8ede, 0xd2d60ddd, 0xc186fe29, 0x33ed7d2a, + 0xe72719c1, 0x154c9ac2, 0x061c6936, 0xf477ea35, 0xaa64d611, 0x580f5512, + 0x4b5fa6e6, 0xb93425e5, 0x6dfe410e, 0x9f95c20d, 0x8cc531f9, 0x7eaeb2fa, + 0x30e349b1, 0xc288cab2, 0xd1d83946, 0x23b3ba45, 0xf779deae, 0x05125dad, + 0x1642ae59, 0xe4292d5a, 0xba3a117e, 0x4851927d, 0x5b016189, 0xa96ae28a, + 0x7da08661, 0x8fcb0562, 0x9c9bf696, 0x6ef07595, 0x417b1dbc, 0xb3109ebf, + 0xa0406d4b, 0x522bee48, 0x86e18aa3, 0x748a09a0, 0x67dafa54, 0x95b17957, + 0xcba24573, 0x39c9c670, 0x2a993584, 0xd8f2b687, 0x0c38d26c, 0xfe53516f, + 0xed03a29b, 0x1f682198, 0x5125dad3, 0xa34e59d0, 0xb01eaa24, 0x42752927, + 0x96bf4dcc, 0x64d4cecf, 0x77843d3b, 0x85efbe38, 0xdbfc821c, 0x2997011f, + 0x3ac7f2eb, 0xc8ac71e8, 0x1c661503, 0xee0d9600, 0xfd5d65f4, 0x0f36e6f7, + 0x61c69362, 0x93ad1061, 0x80fde395, 0x72966096, 0xa65c047d, 0x5437877e, + 0x4767748a, 0xb50cf789, 0xeb1fcbad, 0x197448ae, 0x0a24bb5a, 0xf84f3859, + 0x2c855cb2, 0xdeeedfb1, 0xcdbe2c45, 0x3fd5af46, 0x7198540d, 0x83f3d70e, + 0x90a324fa, 0x62c8a7f9, 0xb602c312, 0x44694011, 0x5739b3e5, 0xa55230e6, + 0xfb410cc2, 0x092a8fc1, 0x1a7a7c35, 0xe811ff36, 0x3cdb9bdd, 0xceb018de, + 0xdde0eb2a, 0x2f8b6829, 0x82f63b78, 0x709db87b, 0x63cd4b8f, 0x91a6c88c, + 0x456cac67, 0xb7072f64, 0xa457dc90, 0x563c5f93, 0x082f63b7, 0xfa44e0b4, + 0xe9141340, 0x1b7f9043, 0xcfb5f4a8, 0x3dde77ab, 0x2e8e845f, 0xdce5075c, + 0x92a8fc17, 0x60c37f14, 0x73938ce0, 0x81f80fe3, 0x55326b08, 0xa759e80b, + 0xb4091bff, 0x466298fc, 0x1871a4d8, 0xea1a27db, 0xf94ad42f, 0x0b21572c, + 0xdfeb33c7, 0x2d80b0c4, 0x3ed04330, 0xccbbc033, 0xa24bb5a6, 0x502036a5, + 0x4370c551, 0xb11b4652, 0x65d122b9, 0x97baa1ba, 0x84ea524e, 0x7681d14d, + 0x2892ed69, 0xdaf96e6a, 0xc9a99d9e, 0x3bc21e9d, 0xef087a76, 0x1d63f975, + 0x0e330a81, 0xfc588982, 0xb21572c9, 0x407ef1ca, 0x532e023e, 0xa145813d, + 0x758fe5d6, 0x87e466d5, 0x94b49521, 0x66df1622, 0x38cc2a06, 0xcaa7a905, + 0xd9f75af1, 0x2b9cd9f2, 0xff56bd19, 0x0d3d3e1a, 0x1e6dcdee, 0xec064eed, + 0xc38d26c4, 0x31e6a5c7, 0x22b65633, 0xd0ddd530, 0x0417b1db, 0xf67c32d8, + 0xe52cc12c, 0x1747422f, 0x49547e0b, 0xbb3ffd08, 0xa86f0efc, 0x5a048dff, + 0x8ecee914, 0x7ca56a17, 0x6ff599e3, 0x9d9e1ae0, 0xd3d3e1ab, 0x21b862a8, + 0x32e8915c, 0xc083125f, 0x144976b4, 0xe622f5b7, 0xf5720643, 0x07198540, + 0x590ab964, 0xab613a67, 0xb831c993, 0x4a5a4a90, 0x9e902e7b, 0x6cfbad78, + 0x7fab5e8c, 0x8dc0dd8f, 0xe330a81a, 0x115b2b19, 0x020bd8ed, 0xf0605bee, + 0x24aa3f05, 0xd6c1bc06, 0xc5914ff2, 0x37faccf1, 0x69e9f0d5, 0x9b8273d6, + 0x88d28022, 0x7ab90321, 0xae7367ca, 0x5c18e4c9, 0x4f48173d, 0xbd23943e, + 0xf36e6f75, 0x0105ec76, 0x12551f82, 0xe03e9c81, 0x34f4f86a, 0xc69f7b69, + 0xd5cf889d, 0x27a40b9e, 0x79b737ba, 0x8bdcb4b9, 0x988c474d, 0x6ae7c44e, + 0xbe2da0a5, 0x4c4623a6, 0x5f16d052, 0xad7d5351 +}; + +/** + Calculates the CRC32c checksum of the given buffer. + + @param[in] Buffer Pointer to the buffer. + @param[in] Length Length of the buffer, in bytes. + @param[in] InitialValue Initial value of the CRC. + + @return The CRC32c checksum. +**/ +UINT32 +EFIAPI +CalculateCrc32c ( + IN CONST VOID *Buffer, + IN UINTN Length, + IN UINT32 InitialValue + ) +{ + CONST UINT8 *Buf; + UINT32 Crc; + + Buf =3D Buffer; + Crc =3D ~InitialValue; + + while (Length-- !=3D 0) { + Crc =3D mCrc32cLookupTable[(Crc & 0xFF) ^ *(Buf++)] ^ (Crc >> 8); + } + + return ~Crc; +} --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88073): https://edk2.groups.io/g/devel/message/88073 Mute This Topic: https://groups.io/mt/90054843/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 00:25:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88074+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88074+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1648342674; cv=none; d=zohomail.com; s=zohoarc; b=hUN26Y9o/C5lGkhebn7UxLJfe6JPrm2YcrUmdIr8TLgOl7I76yKKvzR+6/Vvx9O72vR/7N8tOoGiYjiSagHNAAESFb1kGAWVaXjW7CfPNoTd+thf3fNmADAXuNowKh0G/zypBX4md10QuMX9Id41LjLRJZSkL+YU6JjUVOeTB6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648342674; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=oZVwCNv1b5ZEH1l0sNsjN3qnDvAny4wdDf24ExIEb7A=; b=B0zGDRI/sAv2/R3sJr4wmjZCdnE3rTEj2njnMCCX7uW+CG0kXA13SX7CQ9/pR/A0ibH9A9W1p1ZjqyCSVelvTsuM+0tU+7Uz1eVoWRSx8wURTbhLqznMVfrE/Pf06IgIC2O4l2JW8rFDOgURwgssnooAdcEQTjnOtA1SxpaCbJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88074+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1648342674883954.9320706586776; Sat, 26 Mar 2022 17:57:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AMmsYY1788612xGsjncgg2bT; Sat, 26 Mar 2022 17:57:54 -0700 X-Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web09.1277.1648342673314600036 for ; Sat, 26 Mar 2022 17:57:53 -0700 X-Received: by mail-wr1-f46.google.com with SMTP id h23so15525085wrb.8 for ; Sat, 26 Mar 2022 17:57:53 -0700 (PDT) X-Gm-Message-State: W8RRiIOWdUz9dkDhVtPJkwpZx1787277AA= X-Google-Smtp-Source: ABdhPJzOqb7kVag+E5KN33g347ZXn9wExw0Nif1X4Uxpdl2f5HUYKMm+LFOR5hl8N5wB2ZLqVLf+8w== X-Received: by 2002:adf:ec41:0:b0:1ed:beee:6f8f with SMTP id w1-20020adfec41000000b001edbeee6f8fmr14884218wrn.110.1648342671506; Sat, 26 Mar 2022 17:57:51 -0700 (PDT) X-Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id b3-20020adfd1c3000000b00205820686dasm10143304wrd.5.2022.03.26.17.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 17:57:51 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Hao A Wu Subject: [edk2-devel] [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 implementation Date: Sun, 27 Mar 2022 00:57:48 +0000 Message-Id: <20220327005748.92041-3-pedro.falcato@gmail.com> In-Reply-To: <20220327005748.92041-1-pedro.falcato@gmail.com> References: <20220327005748.92041-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648342674; bh=IZd1RLTltSDm7Ai2fo3QZDd7NLCKT85zAEgIROAXSo4=; h=Cc:Date:From:Reply-To:Subject:To; b=gVKR0hDhZgUXaGEr/7/FINbuNivfGnplsIjZh0++hN1ISRvckrIGGocl7p70lE5ic4D jsGIf6Iy1oxXvQmKyTYYiJ+5TapvVKf3v1Wd2xA8rYYwtxHwtvJ4otVYhRr8YGDheJruG rHvFHdDVvg6XBTiMiv9IASzBrfS8inBJkfk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648342676156100009 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 Deletes the CRC16 implementation as CalculateCrc16() is being merged into BaseLib. Cc: Hao A Wu Signed-off-by: Pedro Falcato --- .../DebugAgent/DebugAgentCommon/DebugAgent.c | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA= gent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent= .c index a1e61a6ef90e..62c6a235d425 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c @@ -126,41 +126,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_VECTOR_HANDOFF_INFO = mVectorHandoffInfoDebugAg =20 GLOBAL_REMOVE_IF_UNREFERENCED UINTN mVectorHandoffInfoCount =3D sizeof (m= VectorHandoffInfoDebugAgent) / sizeof (EFI_VECTOR_HANDOFF_INFO); =20 -/** - Calculate CRC16 for target data. - - @param[in] Data The target data. - @param[in] DataSize The target data size. - @param[in] Crc Initial CRC. - - @return UINT16 The CRC16 value. - -**/ -UINT16 -CalculateCrc16 ( - IN UINT8 *Data, - IN UINTN DataSize, - IN UINT16 Crc - ) -{ - UINTN Index; - UINTN BitIndex; - - for (Index =3D 0; Index < DataSize; Index++) { - Crc ^=3D (UINT16)Data[Index]; - for (BitIndex =3D 0; BitIndex < 8; BitIndex++) { - if ((Crc & 0x8000) !=3D 0) { - Crc <<=3D 1; - Crc ^=3D 0x1021; - } else { - Crc <<=3D 1; - } - } - } - - return Crc; -} - /** Read IDT entry to check if IDT entries are setup by Debug Agent. =20 --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88074): https://edk2.groups.io/g/devel/message/88074 Mute This Topic: https://groups.io/mt/90054844/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-