1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

Ayush Singh posted 3 patches 2 years, 1 month ago
Failed in applying to current master (apply log)
RustPkg/Library/UefiRustAllocationLib/src/lib.rs |  53 ++--
RustPkg/Library/UefiRustIntrinsicLib/src/lib.rs  |   8 -
RustPkg/Test/HelloWorld/.cargo/config.toml       |   3 +
RustPkg/Test/HelloWorld2/.cargo/config.toml      |   3 +
RustPkg/Test/TestRustLangApp/.cargo/config.toml  |   3 +
RustPkg/Test/TestRustLangApp/src/main.rs         |  95 +++----
RustPkg/Test/TestRustLangLib/.cargo/config.toml  |   3 +
RustPkg/Test/TestRustLangLib/src/lib.rs          | 264 ++++++++------------
8 files changed, 186 insertions(+), 246 deletions(-)
create mode 100644 RustPkg/Test/HelloWorld/.cargo/config.toml
create mode 100644 RustPkg/Test/HelloWorld2/.cargo/config.toml
create mode 100644 RustPkg/Test/TestRustLangApp/.cargo/config.toml
create mode 100644 RustPkg/Test/TestRustLangLib/.cargo/config.toml
[edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging
Posted by Ayush Singh 2 years, 1 month ago 
CC Jiewen Yao

This is my 2nd email about this patch to fix edkii-rust branch in
edk2-staging repo, this time hopefully following contributing procedure
better.

I have tried to to fix RustPkg/Test/HelloWorld,
RustPkg/Test/HelloWorld2, RustPkg/Test/TestRustLangApp, and
RustPkg/Test/TestRustLangLib. This also meant fixing
RustPkg/Library/UefiRustIntrinsicLib and
RustPkg/Library/UefiRustAllocationLib.

It is also not possible to build this branch with gcc-11 since that will
require a rebase to edk2/master, but I am not sure how that can be done
since edk2-staging/master does not track edk2/master like it is supposed
to according to the edk2-staging/about branch.

My working repository for these commits can be found at: 
https://github.com/Ayush1325/edk2-staging/tree/edkii-rust-fix-v1

Ayush Singh (3):
  RustPkg/Test: Replace cargo-xbuild with build-std
  RustPkg/Test/TestRustLangLib: Fix Building
  RustPkg/Test/TestRustLangApp: Fix building

 RustPkg/Library/UefiRustAllocationLib/src/lib.rs |  53 ++--
 RustPkg/Library/UefiRustIntrinsicLib/src/lib.rs  |   8 -
 RustPkg/Test/HelloWorld/.cargo/config.toml       |   3 +
 RustPkg/Test/HelloWorld2/.cargo/config.toml      |   3 +
 RustPkg/Test/TestRustLangApp/.cargo/config.toml  |   3 +
 RustPkg/Test/TestRustLangApp/src/main.rs         |  95 +++----
 RustPkg/Test/TestRustLangLib/.cargo/config.toml  |   3 +
 RustPkg/Test/TestRustLangLib/src/lib.rs          | 264 ++++++++------------
 8 files changed, 186 insertions(+), 246 deletions(-)
 create mode 100644 RustPkg/Test/HelloWorld/.cargo/config.toml
 create mode 100644 RustPkg/Test/HelloWorld2/.cargo/config.toml
 create mode 100644 RustPkg/Test/TestRustLangApp/.cargo/config.toml
 create mode 100644 RustPkg/Test/TestRustLangLib/.cargo/config.toml

-- 
2.35.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87753): https://edk2.groups.io/g/devel/message/87753
Mute This Topic: https://groups.io/mt/89884782/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging
Posted by Marvin Häuser 2 years, 1 month ago 

> On 19. Mar 2022, at 08:06, Ayush Singh <ayushdevel1325@gmail.com> wrote:
> 
> CC Jiewen Yao

You didn’t actually CC, done.

Best regards,
Marvin

> 
> This is my 2nd email about this patch to fix edkii-rust branch in
> edk2-staging repo, this time hopefully following contributing procedure
> better.
> 
> I have tried to to fix RustPkg/Test/HelloWorld,
> RustPkg/Test/HelloWorld2, RustPkg/Test/TestRustLangApp, and
> RustPkg/Test/TestRustLangLib. This also meant fixing
> RustPkg/Library/UefiRustIntrinsicLib and
> RustPkg/Library/UefiRustAllocationLib.
> 
> It is also not possible to build this branch with gcc-11 since that will
> require a rebase to edk2/master, but I am not sure how that can be done
> since edk2-staging/master does not track edk2/master like it is supposed
> to according to the edk2-staging/about branch.
> 
> My working repository for these commits can be found at: 
> https://github.com/Ayush1325/edk2-staging/tree/edkii-rust-fix-v1
> 
> Ayush Singh (3):
>  RustPkg/Test: Replace cargo-xbuild with build-std
>  RustPkg/Test/TestRustLangLib: Fix Building
>  RustPkg/Test/TestRustLangApp: Fix building
> 
> RustPkg/Library/UefiRustAllocationLib/src/lib.rs |  53 ++--
> RustPkg/Library/UefiRustIntrinsicLib/src/lib.rs  |   8 -
> RustPkg/Test/HelloWorld/.cargo/config.toml       |   3 +
> RustPkg/Test/HelloWorld2/.cargo/config.toml      |   3 +
> RustPkg/Test/TestRustLangApp/.cargo/config.toml  |   3 +
> RustPkg/Test/TestRustLangApp/src/main.rs         |  95 +++----
> RustPkg/Test/TestRustLangLib/.cargo/config.toml  |   3 +
> RustPkg/Test/TestRustLangLib/src/lib.rs          | 264 ++++++++------------
> 8 files changed, 186 insertions(+), 246 deletions(-)
> create mode 100644 RustPkg/Test/HelloWorld/.cargo/config.toml
> create mode 100644 RustPkg/Test/HelloWorld2/.cargo/config.toml
> create mode 100644 RustPkg/Test/TestRustLangApp/.cargo/config.toml
> create mode 100644 RustPkg/Test/TestRustLangLib/.cargo/config.toml
> 
> -- 
> 2.35.1
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87757): https://edk2.groups.io/g/devel/message/87757
Mute This Topic: https://groups.io/mt/89884782/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging
Posted by Ayush Singh 2 years, 1 month ago 
I see. While the other mails got the CC from the commits, the cover letter also needs to do a CC separately. Will keep this in mind from the next commit.

Ayush Singh


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87758): https://edk2.groups.io/g/devel/message/87758
Mute This Topic: https://groups.io/mt/89884782/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging
Posted by Yao, Jiewen 2 years, 1 month ago 
Thank you very much Marvin and Ayush.
Glad you have interest on Rust.

May I know what is your goal for this patch? Do you just want to make it pass build?
Or want to work on something more?

Currently, we did not work actively on https://github.com/tianocore/edk2-staging/tree/edkii-rust.

Instead we are thinking an EDKII independent lightweight rust-based firmware - https://github.com/jyao1/rust-firmware.

Would you mind let me know what is your purpose? I am happy to discuss more.

Thank you
Yao Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marvin
> Häuser
> Sent: Saturday, March 19, 2022 4:40 PM
> To: devel@edk2.groups.io; ayushdevel1325@gmail.com
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch
> edk2-staging
> 
> 
> 
> > On 19. Mar 2022, at 08:06, Ayush Singh <ayushdevel1325@gmail.com> wrote:
> >
> > CC Jiewen Yao
> 
> You didn’t actually CC, done.
> 
> Best regards,
> Marvin
> 
> >
> > This is my 2nd email about this patch to fix edkii-rust branch in
> > edk2-staging repo, this time hopefully following contributing procedure
> > better.
> >
> > I have tried to to fix RustPkg/Test/HelloWorld,
> > RustPkg/Test/HelloWorld2, RustPkg/Test/TestRustLangApp, and
> > RustPkg/Test/TestRustLangLib. This also meant fixing
> > RustPkg/Library/UefiRustIntrinsicLib and
> > RustPkg/Library/UefiRustAllocationLib.
> >
> > It is also not possible to build this branch with gcc-11 since that will
> > require a rebase to edk2/master, but I am not sure how that can be done
> > since edk2-staging/master does not track edk2/master like it is supposed
> > to according to the edk2-staging/about branch.
> >
> > My working repository for these commits can be found at:
> > https://github.com/Ayush1325/edk2-staging/tree/edkii-rust-fix-v1
> >
> > Ayush Singh (3):
> >  RustPkg/Test: Replace cargo-xbuild with build-std
> >  RustPkg/Test/TestRustLangLib: Fix Building
> >  RustPkg/Test/TestRustLangApp: Fix building
> >
> > RustPkg/Library/UefiRustAllocationLib/src/lib.rs |  53 ++--
> > RustPkg/Library/UefiRustIntrinsicLib/src/lib.rs  |   8 -
> > RustPkg/Test/HelloWorld/.cargo/config.toml       |   3 +
> > RustPkg/Test/HelloWorld2/.cargo/config.toml      |   3 +
> > RustPkg/Test/TestRustLangApp/.cargo/config.toml  |   3 +
> > RustPkg/Test/TestRustLangApp/src/main.rs         |  95 +++----
> > RustPkg/Test/TestRustLangLib/.cargo/config.toml  |   3 +
> > RustPkg/Test/TestRustLangLib/src/lib.rs          | 264 ++++++++------------
> > 8 files changed, 186 insertions(+), 246 deletions(-)
> > create mode 100644 RustPkg/Test/HelloWorld/.cargo/config.toml
> > create mode 100644 RustPkg/Test/HelloWorld2/.cargo/config.toml
> > create mode 100644 RustPkg/Test/TestRustLangApp/.cargo/config.toml
> > create mode 100644 RustPkg/Test/TestRustLangLib/.cargo/config.toml
> >
> > --
> > 2.35.1
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87759): https://edk2.groups.io/g/devel/message/87759
Mute This Topic: https://groups.io/mt/89884782/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.