From nobody Fri May 17 06:07:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86455+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86455+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1644360762; cv=none; d=zohomail.com; s=zohoarc; b=Fro9ocJ+tcpfUm/4rusfW+otnUi0u/rL3wOdQRwZuxNl/iXoJit1v3qm1jivu5bkh/ORO8BQzmHTWgP4djrrnCEPd05IF2k+CB71xjQwKHeSjs7zIW87fwAVEoYJnA/EPQiGN95KQY3RIldkxZqNgjDinN2Rb/7nLs2vSOYc+nw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644360762; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=YvwxdkX+F1rXOIQgO3yzfVRF3ZWq2g3nl4qE3V68h2U=; b=NLRA3SOtAwmvC/X6tlJ7XVpitz7US6vtNQWuXKslXPxdq3VstGZYFlCIuB56hRx4M9F4FWepu710hWwG4ANtTLvs5mPBAj4nWz7FtdOL/zBPxgscojki7AuUpjIt6sVWrlXBLEXCzf92Fvnk62Rd308zvnxhZSk8kc7Jy67rOdw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86455+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1644360762164216.98109633470528; Tue, 8 Feb 2022 14:52:42 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id A2MIYY1788612xBAbhMYz2ts; Tue, 08 Feb 2022 14:52:41 -0800 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.18991.1644360760334944517 for ; Tue, 08 Feb 2022 14:52:40 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="335471981" X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="335471981" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 14:52:31 -0800 X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="633010884" X-Received: from gdong1-mobl1.amr.corp.intel.com ([10.213.162.217]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 14:52:30 -0800 From: "Guo Dong" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Maurice Ma , Benjamin You Subject: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix build error Date: Tue, 8 Feb 2022 15:51:55 -0700 Message-Id: <20220208225155.189-1-guo.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guo.dong@intel.com X-Gm-Message-State: mw47Pw8wCkW9GV9er1SY5ICYx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1644360761; bh=fYD5QHvK3pyirTjDc0mINxw0tD3cdDzsNu2vsim+57U=; h=Cc:Date:From:Reply-To:Subject:To; b=ZpC3hwKvmAQcCP/cesU68xCvE4O6QNIO7SMujSx5HKpH/hqCqhbQUgWpcV7+ttwQ8yZ uziXN9ySRq3r1NtSW+SkyCOI0MdDdOA4KUo1wY1+mzOdeC4SAVK22iG/cSDYRRH5K0dwn Stu50fFovbQaxwjdPuPqnzCm/Qugd+o9bYY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1644360763021100001 Content-Type: text/plain; charset="utf-8" From: Guo Dong On windows build, need add "-DPLATFORMX64_ENABLE=3DTRUE" in the build command line beside -DNETWORK_DRIVER_ENABLE=3DTRUE in order build network features. So update DSC to set PLATFORMX64_ENABLE to TRUE when building network feature. On Linux build, DSC file should not have PcdAllowHttpConnections without building network feature, else it would cause build error. Signed-off-by: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 1ce96a51c1..fd5739499a 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -402,7 +402,9 @@ [PcdsPatchableInModule.X64] gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER) gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER) +!if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE +!endif =20 [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c= , 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0= x31 } @@ -525,6 +527,8 @@ # UEFI network modules # !if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE +[Defines] + DEFINE PLATFORMX64_ENABLE =3D TRUE !include NetworkPkg/Network.dsc.inc !endif =20 --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86455): https://edk2.groups.io/g/devel/message/86455 Mute This Topic: https://groups.io/mt/89009263/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-