From nobody Fri May 10 19:03:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84192+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84192+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1638331940533213.42767368553962; Tue, 30 Nov 2021 20:12:20 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id r3f1YY1788612xiqEPgClIM9; Tue, 30 Nov 2021 20:12:20 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.139]) by mx.groups.io with SMTP id smtpd.web10.87971.1638331938078374612 for ; Tue, 30 Nov 2021 20:12:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wc07je31oQs8ix6YoQaWMprFTqHpaAZMJY0lp1GuWYdprxB6UGrnNO25R0En520E7KG+xWjp3AWWPT99c4gz4NHhaQ/6EL5W1n35gRU2GytyQBlrlO/JDlx28qDfUD1pk8RxmmroYc1V2489Y5lo2KRJ6kIprPJLl5r9UvFuQp4RsAMuiKcIXEBw295ozRcU5dL0P2I/HT6iU/nrQwiLy0wE98mfS8bsJDdEdJkvZdbz11jsy0ed8fyuqH0WerRRzFMxe0kmj0qCnL5DWQLx2cZYSKpsDpQU3At++6bNdJ4jxlM8MyXDrgbDRk/GSi9pTDnWj3i8sPpKHn64etnSOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UpHRgPY2DLJ68GfR9UmwXEyWpU3D4r1mYcwgWNgGbTI=; b=j+lnM9kvb6PYq5z8Xr2HylVdhUmOBNslgHW8Ot3tpsQNcGhiFhQJfa98woUycstwTp83z+fa+rSbvUVOwcnifa95ehFzojvHQVKWxlmmld5KyWXgc3w8vom++Pzd0v5Gpd3RVZeopc0J5C3ObsjAmKSPkz5S0LaTbsxfml5f4QKl+lZ0lQ8PaThywqvvhMPGYHmGxc5BccnGBCf0DF53LOH1FL5ovNPxJZnq8B7UL8DdtOiD+Vem7RkfzE+6NMmcPnMrT10WhCMH0nnPsNs/iMCc9Dk2PnYJ61F33FkdTLti9F0rGUFLcxll+FGNzOnkre7PG2b+8R3Jy+8JdUZATA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6539.prod.exchangelabs.com (2603:10b6:510:96::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec 2021 04:12:17 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021 04:12:17 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io Cc: patches@amperecomputing.com, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Rebecca Cran Subject: [edk2-devel] [PATCH 1/3] ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition Date: Wed, 1 Dec 2021 11:10:29 +0700 Message-Id: <20211201041031.31824-2-nhi@os.amperecomputing.com> In-Reply-To: <20211201041031.31824-1-nhi@os.amperecomputing.com> References: <20211201041031.31824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-Received: from sw004.amperecomputing.com (118.69.219.201) by SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 04:12:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d8df0ab-492f-4d1f-0760-08d9b480c2fa X-MS-TrafficTypeDiagnostic: PH0PR01MB6539: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: NSE0lzXq1iy9PQbAmsHvGJl1ZZmMpvo9HVxYOuq7hJjMUu8dOwaV3mK+Y9nehzdZ1t7XKncgZfNm7YRM/bDxxP1kntAKSJafpnqxyICcO0o8keRYGEBbSV3mzG87NWA2SN16Q8omCCV28+EhmXsufmw76x0HQNNnbL5xIpfHrRrWua5rG3IYBdK21BFbGgRtKM1rEzF7bInjka9lE260vFvNprnFSTOy2JAs1lsTgRwTVm0Pd1rMJ/CgL/BXtlYa8aX6tzquVjG2c2mXG//idn9OSJgk9A+f//0vUmsj0VrGfuNq4CpNhya9altUVbsAK5PX9mGacajVsmhz5QPhzZeFjEWwdpHetgP2t85NvnnjvgME7qPXe2aP/CMEJbSo1JLanfoUzttvQgTw2VSS9s2anIvoNJZrok9c2QOkCo3UnyCE7ZBBXUMs3YtT1CVmEA7akVTyQxTTYmxQIjZrRyVS+6pO9SPgD39fUvSVwrVq3GuvzS5yBt1EA48zE5J47rSDZ2T+UZOdr2ZjicW7XahPdTWPDVoO24IdKSaq+5Y9cIZNySyFV2FnQGkjyi66WN74rsCWYmkmYO/5DQgwt955Uy5wNV51K4y++u4KQBvRu0jTkoTKW5UZFXOHqlwCI4OfACcg0asitUUbjMqG1JyMNCNjLa44rUmyyzbAAWnWqzP5dhpDdFIv3poaj8z9mT//37k1fLBGnQIxPnUtrw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L9S+qT0MpD1qeiKpMHL2g0ahJIbykxKaaUjBCOkqLpudCMZKx96Ji+Viillq?= =?us-ascii?Q?PvJnLl/whes633O3egNYVu3Af06ddgwPezf/q8duHDgYSFKC5JWX1RXUaGY2?= =?us-ascii?Q?9hi6sA86chvcL/scgcClcVjgYfnlW/TPKUNjN+tNYy8KSi9S82eX8xRbPSdN?= =?us-ascii?Q?OYGkcC0ORi6tXXCH7aeJkbZC6pxj4j50IVJ+s2+G5hOqbfQOOhS1Gl6hENQj?= =?us-ascii?Q?lu5syx5C4DCboZ+GsfJXE3CVTP8xdECXyZgtVVSSidP0EgocO3Nb9D5WGPD7?= =?us-ascii?Q?pY9xMQZI3no1qHN0PDfVcx8ZkdzQtbbQOUV8Pll6kYNyENP+zYZn2KNI95ig?= =?us-ascii?Q?W8tkoxhHowGoGPB4TwkO4Sgo8aWP1cJA9NTIvZxM4Hnh86Xi/ljYkCon+ICU?= =?us-ascii?Q?yB0+EO+qk6NkiOA/W+U5qH9VQki6Tq5PFkJyJECRq4HtA3nm5iZDVFynHhsH?= =?us-ascii?Q?/mX/GVjednO4WCNZ0DDi1Rb8ae/XqNcBgDz3KNHR8SEaq9FeN7mmYBCAX1XX?= =?us-ascii?Q?dPcqHLIXYPU9QIyLXx3u2ecUP0DZd2lNQ94MnRPAr1o9IPPOq2cXzrYDYP+A?= =?us-ascii?Q?5tVSTHPn3bgPOZcHbwOY6lJCSD3rl7kOFWCkmDdWqjvHxrqLWWspxbZWkOyY?= =?us-ascii?Q?hCZvUJYxreF/BelzefV+oHERsSD6MHrpM+K3qNrl6GQAkaTYijuXsPO/FV98?= =?us-ascii?Q?h2Nb1kaTy898VFDSIse0nMzhP1/fcbmRrYoU7/Crneo4a2N8WcAa35drreFf?= =?us-ascii?Q?CxjU1Zq590DCSIwYnjd02mHaggTiiucra/hvPwCwhsPitTCMTPWb5Pl1/Etz?= =?us-ascii?Q?cBXdLHTq2dfEqKC07G711UIvYnGDyXo+PS+MYsDizWFFWoXkzdSy6tGEH8Nl?= =?us-ascii?Q?bcRk3vTEblWkNUTqX1jDeDKDIpjNvDUzOC71R5Kx7BGRC62cSl2MiS3Iq9n2?= =?us-ascii?Q?EdeuuYWO006/DQcUQjfY722CzOc3hh44wK22XIvNiHqSMoxeOpZ9GJxnbW0w?= =?us-ascii?Q?CNTYRwgMHEjXm7mdzoaqrBMxGMYFdo/ahnSPVIOtsdwCOXzw1hukYEaUdEt1?= =?us-ascii?Q?cylaCySb8MPT9kQ/Whm4odgVyFNRafi3cFbQUO4BwJyPysyspyjMhio3qAL5?= =?us-ascii?Q?98gRAkaTVZ+7mEHL02zZMIMLi6Spfsq9Qy8tQRYfZrV2ToDfeRwahg4ueoUT?= =?us-ascii?Q?GnMSSkxl0V/ddqEUvVP0KxZc2MfVen0+HWd3FJahE+BhUBbal94XwDQIRVYF?= =?us-ascii?Q?HvgTwm4dzrcgZJzKY/eQ3GpqgOPvtootgc3EOX7l3zEwbvNy+Mk5X2UPnUk+?= =?us-ascii?Q?F9clYxctx8hx1qo7Bx4p5K9sYaoZy8hQU08lEgn7YtXxoS8AQXfWWEl+uXYi?= =?us-ascii?Q?r4CwAUUg64zbuDTdUVmynF/Av7t5Dq2VMj6Y4uV7MuUDI65fVVYBoJkIby68?= =?us-ascii?Q?vl2bZsMoKhp8uYm4SiNX7bmX4lJJAMLPKj/wclqQgu7xnU463wcrcfOIb9Ta?= =?us-ascii?Q?uPrfc9MR1xfC6klOecmKcszhT1LAJ7a4YvZ4pLTa53kwXLKddp/LRxJ6pwcr?= =?us-ascii?Q?WU3qb6AuHF5RkADE5mqi6S1yd+lFtZ5JfO57fthwEAdZ1utH1B2yUA7Kxdsk?= =?us-ascii?Q?rQvNG1LzHF1HfVmduqDu6YaFxdBEyxq2qvsBIGKaPUll1LZyId8zF/nGyUup?= =?us-ascii?Q?5xWjXZ7kQ5WPc2KiHzWcDEgtZ7c=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d8df0ab-492f-4d1f-0760-08d9b480c2fa X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 04:12:17.4274 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ysxUhMCuxm9SQjmDCUFcOAQJhwx5/1JxxcYMelKFb2gpLX1//W54NqWely5FBQEJDuqYoMzZYL8jym9Gg1SnsyxjY8aAkQ4MsAdgj6kpic0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6539 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: SfZNDu87PyaNSCcXRKm1XLSYx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1638331940; bh=yiGqBE7MQauX8iA4VZi+MOCKpfRZ1G7lwpL30DSH5s0=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=jBQkCX1/tYdD/LvXEdAtPiSKguvvFh3uI8np5ssMTtVEy443IhRfShWaB2K8H6aPQsO ifV8lWPX5UJoqgT1nRxVxyI6vV6vypU3jygJEOFRNMazOH2UEn5iHgHj/c/ThCMZ+xtbm sYU159kk8jJ0SlPKeJOifl+8Qhav8CXiIzQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1638331940943100004 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch removes duplicate HII string definition in the MiscSystemManufacturer.uni. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Rebecca Cran Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | = 1 - 1 file changed, 1 deletion(-) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufact= urer.uni index 8038f0e4b0bf..2b3b19cab2ea 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni @@ -13,7 +13,6 @@ =20 #string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" #string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" #string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" #string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" #string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified" --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84192): https://edk2.groups.io/g/devel/message/84192 Mute This Topic: https://groups.io/mt/87420726/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 10 19:03:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84193+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84193+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1638331942905134.03049092181664; Tue, 30 Nov 2021 20:12:22 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id XrBaYY1788612x34epQYJWiW; Tue, 30 Nov 2021 20:12:22 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.139]) by mx.groups.io with SMTP id smtpd.web11.87219.1638331941356440176 for ; Tue, 30 Nov 2021 20:12:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lUH38ftRq+QeUXG2sEfqSjmzYD1XxpaH+LECmKrC2chyD0QyLMJZwtBvq6myyd/QNrdZYuE4pjtAZ1FobcvKeSj/y+TKNonUUEk0YI30A8wBPn/pRtbQ2133uhVIGc/TEu5tDxGcJB3MAWukYQQFzIQ2MSQeDaU6JPQVstAr+qLrBXYoIlRfyYncnjlp5HyBfa7maGY06qnjDUQG6lH9SAlVaied2vXfpp/xeqxguHAUIfw/K9fXjtkiNQu31W3YompR7P5T3vfSkGWvMk3DGByAwbBkOM+YeB5xY0MR3qAfe5VmHg9yaOG/iCMWOCVslkNfomlyvwrH4aMW2dkPpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wIeCotFKoZFcYIjw2Rm/hKH/GsPJqQN5YsrYUBIC70o=; b=jfGDes107IZBbdMFmB00qCljqmT/MB9d6ZzZLlvT2W/w5b+C5BTRMWCP1fdAzqRU9kef8R4gSHzxO70Pdg5cvI5P5oVteErJrDmO1DLeadaXAgAjYI9JOJ9aiHYaUI2c4OBlF6mymdMElXoAJls8mUlD0vkqHdEZoO2ysDWTyB6Ncsu019Vk+IH7fRMlOfgFeW6u8olhdxojRTwkET+YGSEp5cee1OY8HEQ1ZChOEq6PnH3V6oWNwxWiywfC3tvaPV4JnW5SdiXXEAPenvL6sfii7xF7CFwRfrIhHhS9q8Ff9JTDozemPk5iTU7vfbtlkMy3By5Z+OFcfO4XOYwR4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6539.prod.exchangelabs.com (2603:10b6:510:96::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec 2021 04:12:20 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021 04:12:20 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io Cc: patches@amperecomputing.com, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Rebecca Cran Subject: [edk2-devel] [PATCH 2/3] ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib Date: Wed, 1 Dec 2021 11:10:30 +0700 Message-Id: <20211201041031.31824-3-nhi@os.amperecomputing.com> In-Reply-To: <20211201041031.31824-1-nhi@os.amperecomputing.com> References: <20211201041031.31824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-Received: from sw004.amperecomputing.com (118.69.219.201) by SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 04:12:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58dbc4f2-724f-4ae4-fb9b-08d9b480c48d X-MS-TrafficTypeDiagnostic: PH0PR01MB6539: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: cJmNhQmna8EAO9erX9wj+SN3SuBKjgJuTabcX+19V1eVyU6tx9dweeRt1by0d8YKohcaxDor48a+x/BSQ7v6Z1A7XOgKXiCOiE0+pK0V8FImMTKUWK2z5+zmMnesCyL75+yTYKrfZXBJCI19F7HMR154KQJj4YPIhH445do8Aloou0X1exaENU45GGL+qM6W0UXMBDTMRXwsuIjHIbcYGL/gG8H8zOItzXq/oF0Qavr1cwHi6WMKOw/pwF5kpIjvzxyEOWMCYW5iNhhSw5Oq0Zds31AvvSONuhXX/rOqnKtk8OHTfAFhFrzQA8oseRw2iyMbHxV5g8hlLzzyuOeagI5r0C1ktRZYoGHPP5GSI+nGY2YjvMzIeYpEoRj+DGTQ0Pz77ZaOy8wuDLZJ5pwUdP1zPKb6zfL5ntfaWyxhEZYVi5p+swHlr/7iBfcrTHe8+BE7vs2JA1uv3CKa29XfrKpQoB7aUWXOxzj2B5UuxiOQCCjksV0Vn3ogIuN9ctgA+awAeuqg5pTNN9VYef0RiyOWyZf0H6KXxMHE3n1m2KZ4Mc9vaADm7V2vMiKcFX4BUUnXMwtNXqL2y3OY99s+drkvnjtzHsG2p5dr+qJqhmYCGgwYIsRy0Gl2abmi1Co8BnoW/SqY1qhet0XmL2Ugps5uyMXq7kHQgKwJnoOQEHqzatfo8ZwU1JwATbKrCHwuf+JXvZCFcMPVODsHj8TtRA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+JQFaeUtjRp8k6Q+wVi58nOFOTfR23ZW94SsYpYx/aeJ5uUf6C3ngUsTZVeo?= =?us-ascii?Q?K56GWuEuN0iKIVlEhperC9BUrNgGL9uBMVTU3MnGhE0zJfCgCZ+L3doOFwxX?= =?us-ascii?Q?81IlzlXiTzo/hHHyOIo4C/jlplW47D/OgIqr1dwX+TUNA5sMPPhZC8EUnF5+?= =?us-ascii?Q?hyykkhYIUGHR2AbljLKKFqUkFPfUUchcD/f+2h0gToxMUZE5UxgGoyrZtoWE?= =?us-ascii?Q?jjdRNK/WDlcEdakvbOu5MZQJu2w/YiSWUh3JuiTc8WhCO1/jxvD+uRkgOV6v?= =?us-ascii?Q?nXnDThzNgyaayV78FfEhlk0IztxcgN2ObWQDfeF9XiUKThbX015ajV4vi2RZ?= =?us-ascii?Q?1A8C6xyPwhLvaEokc6n+PnOvCbpXlnBcrX3oCoOaV2zYQOly1V5mwexaXE6e?= =?us-ascii?Q?izSuZEE+kj8Qe6hAzsQSxhlISYapFabx80/9dgTHtI+sAsUhx9VMqM+vsMJm?= =?us-ascii?Q?rsiOGK5eJGrkB5YAJWJHeqgOmaXAAQ57llmJO/MDgDZRsCt69NMGfMRNRSpb?= =?us-ascii?Q?ztGWTKYLRnttf960a/kiELUSg9CHxP1bbw8nXBaVeOVaSfrK7RGkra9Q+Jx2?= =?us-ascii?Q?xjYVtekJQ2gewlsGnM1o+GchaLnhsR3D8O6b//j5ClEhXu1qCRYmfavOjXlG?= =?us-ascii?Q?UcUOU9vI3fxBJWsrfBLXGs9gHCzmWYb4Ni3OrduSzRpKql0p1MR7eUpZT2VA?= =?us-ascii?Q?has+DVdJ0Bgkumcr/O6YOXApSzC0MEDfp9tbTEfPwbNLGsa2OTsT5FtOTvkZ?= =?us-ascii?Q?HM2gC9CY1GqENK8FLiOtzKUdAcBr6hAIw9G93lAmixa/eHxaqA3gzGmM2q2q?= =?us-ascii?Q?bks+rzOkUtFCDTT6QV0GnKxupME+GE72eGGEknGJztFY7CpnWaLq+wZr1IU4?= =?us-ascii?Q?79bkcs24rGLKT/A3kHZEYgSIZeEoGwjqz6o9Yw5zNVFkEkkhD8AmUOCjKW7K?= =?us-ascii?Q?Z/B4qf4e+e2o1Znm+tq3ayOxJzQqOzLUfDA6Fn/emL79Ev6CNmMge4NyN5Y6?= =?us-ascii?Q?+R4aRWnYN9Bz4u6Q8ynG5n7QGaK7Jfpq5OlZDEnRXOeZUsTbaIW4S2C7zQwa?= =?us-ascii?Q?BVn8YXZ2x4ShMRBwCDrRPgQr6iTr3WL5YECpx47r9kY1zrZh5bGDJnY/AR4s?= =?us-ascii?Q?QFO2mmxysB6aE+Hl33h+f67qVbz+umADCz2+8eDwublW6SOKBZvGbRm6TlNj?= =?us-ascii?Q?IFz1vTTtjxh96sOs1EU+i6b1N6h3mnJI8B9jNHjzWM//JxoPvD2roScLWAhW?= =?us-ascii?Q?uq5CMAVSYbMmSnBEs4YGFaFMmOYzf1G/QqfUxr28Tk3qJ9z7FWS4KSOBa7Tc?= =?us-ascii?Q?1m7ceuVpS1286d4adFu/d0iuTlFxcfLcu9ENHNRuChkAuvU8jOsaJqNBfmC2?= =?us-ascii?Q?rFljbs5JI5N19WqC/RqlyGgfyej3Y6TSINNBthCRpdhhqhgEmK6C7z25JOZA?= =?us-ascii?Q?5XPb9h1+seLaeoQRZM0w4x4j5Al85LgSxW/ZBv/gHjiB2wOWMem4lKgPl7F1?= =?us-ascii?Q?lM3luio8Tmm+YsKMeZ1K599wBzAT8Rtn6aApnTVC+js1eQBUZpujrPtSbvnn?= =?us-ascii?Q?JUNzaHCkMwucvg+9eCNC47DGHIaL8+jy1lca1pGnNACBcFEhBvOjufIlAs50?= =?us-ascii?Q?wH44SDII03k69TiZMSv7EFVWQ7dERTeMzyOwnQVwKWJuJMsb/lADKtzM1+iC?= =?us-ascii?Q?bAlDRgrCuQ/aHgvBcsNQCmgDews=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58dbc4f2-724f-4ae4-fb9b-08d9b480c48d X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 04:12:19.8647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dkkk388GZqrFijeNznrVdCw86unhI0mCJ55wQyy5waXJcYffMmTngUiHfuMZ3sDBpXah/SzE0SqkUox1OlKGwwU2AwG7c7jyJlrOCY5KOf4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6539 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: hDDRfBrEKDn3fwfSRRf6nhIvx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1638331942; bh=aHEOrIX30T37n6G1yB0VvBwUVaHXiF27FZBuRdFP6qM=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=GJhyj7mjiNcsIrmXJ8WmPBohiuO+R7skkXm3FmkVIktn+sccelU8ASFgmx4iUGEiSag 2n/4FRmqCgzd4KK9jVerv24oLEYkS8QVDGIqac69JR7nuuWtniKc/mvE5kVAghnAO1LMf flA9OkgRbQOOqtQUma/ClyFbi1CyisvyyN0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1638331943186100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Typically, the information of the SMBIOS type 1/2/3 is fetched from an FRU device during UEFI booting intead of fixed PCDs. Therefore, this patch is to add more HII string fields in the OemMiscLib and support updating these SMBIOS types with the strings provided by the OemMiscLib if the PCDs are empty. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Rebecca Cran Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h = | 3 +++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunctio= n.c | 10 ++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 15 +++++++++++++++ 3 files changed, 28 insertions(+) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 0b03fe8d4de3..aa68c0a92632 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -44,11 +44,14 @@ typedef enum SerialNumType01, UuidType01, SystemManufacturerType01, + VersionType01, SkuNumberType01, FamilyType01, AssertTagType02, SerialNumberType02, BoardManufacturerType02, + ProductNameType02, + VersionType02, SkuNumberType02, ChassisLocationType02, AssetTagType03, diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemMa= nufacturerFunction.c index 2c69c2593f5d..2c73d63444fe 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c @@ -75,12 +75,22 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscSystemManufacturer) if (StrLen (Product) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_SYSTEM_PRODUCT_NAME); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Product, NULL); + } else { + OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_SYSTEM_PRODUCT_NAME), + ProductNameType01 + ); } =20 pVersion =3D (CHAR16 *) PcdGetPtr (PcdSystemVersion); if (StrLen (pVersion) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_SYSTEM_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, pVersion, NULL); + } else { + OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_SYSTEM_VERSION), + VersionType01 + ); } =20 OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index 097777a23904..7f397d8d2aaa 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -79,18 +79,33 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscBaseBoardManufacturer) if (StrLen (BaseBoardManufacturer) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, BaseBoardManufactur= er, NULL); + } else { + OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER), + BoardManufacturerType02 + ); } =20 BaseBoardProductName =3D (CHAR16 *) PcdGetPtr (PcdBaseBoardProductName); if (StrLen (BaseBoardProductName) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BASE_BOARD_PRODUCT_NAME); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, BaseBoardProductNam= e, NULL); + } else { + OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BASE_BOARD_PRODUCT_NAME), + ProductNameType02 + ); } =20 Version =3D (CHAR16 *) PcdGetPtr (PcdBaseBoardVersion); if (StrLen (Version) > 0) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BASE_BOARD_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); + } else { + OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BASE_BOARD_VERSION), + VersionType02 + ); } =20 OemUpdateSmbiosInfo (mSmbiosMiscHiiHandle, --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84193): https://edk2.groups.io/g/devel/message/84193 Mute This Topic: https://groups.io/mt/87420727/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 10 19:03:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84194+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84194+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1638331944670826.6605407731664; Tue, 30 Nov 2021 20:12:24 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5myjYY1788612xd3kNMdLHW5; Tue, 30 Nov 2021 20:12:24 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.136]) by mx.groups.io with SMTP id smtpd.web11.87220.1638331943491250419 for ; Tue, 30 Nov 2021 20:12:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmsNbWBsOpCkBT6galUmectIBStzQU1nIvfCtazqJ3zjsmG6SzDDJRn3scNvWLpmZLdi7fZVK1vTKSMZm+f+bG3/xq49oz/oOpv1S2twL31HcbENp/jmZ7sqhetkpfofCCwVQ8qIcBawVKu0KABOvQ7ChRWn1C0KaVkRHjvCmUNapf2Tcb9Fq/+zR6v0a1QTrieYNQteiZ9jy0IHSjmoZR0cdCgsiL0en88PyqOK22+Sy+gf7PufOtNn5crgod7ntgysH35ud3A5XPcABqlL9zIp7jOBJdwUbQXwCGBZD8CIsS5kpd6p5IucFGJK8k2079zFOPx3+DCyiMipYDTlDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H5g9UG3ZUvDedFaFjWQjg3ZHgHZfzty4MBiia+BLsr8=; b=OOL8v2gzYnx51gozTKgwkMPTozjXHUUVO0l10IEMDRDxnNljor80BOyPBroY5pW0yIgPs5wDDjokL1B9j1eRnujOU2R9Qu8kiY8e5zCbYKBRlogAuIdFzJp2Mv3FzwU3RkU77T6C2+T7LSzgTNFONlzjGQ2wniNxZa2rK7ZqqvhydhZr2ZFDPqFFq8Qr89RaE7Zk6d0mu/80r4s/FiU2YR51yfJftH8DL6k3FaPNBrV5i2eIvwEKX4yQy+aQZdcj6Lm6VnYMk3UrTPhoR5zveot9dgRevjmhG38S9J+fOG3bGcSw3uhR3VnjbtLUAS9wDFJO8aFh8m+aN1DxxMljHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6539.prod.exchangelabs.com (2603:10b6:510:96::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec 2021 04:12:22 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021 04:12:22 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io Cc: patches@amperecomputing.com, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Rebecca Cran Subject: [edk2-devel] [PATCH 3/3] ArmPkg/ProcessorSubClassDxe: Get serial and part number from OemMiscLib Date: Wed, 1 Dec 2021 11:10:31 +0700 Message-Id: <20211201041031.31824-4-nhi@os.amperecomputing.com> In-Reply-To: <20211201041031.31824-1-nhi@os.amperecomputing.com> References: <20211201041031.31824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-Received: from sw004.amperecomputing.com (118.69.219.201) by SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 04:12:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 286f3ac8-1f23-4a74-44e4-08d9b480c5dd X-MS-TrafficTypeDiagnostic: PH0PR01MB6539: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Hi6i8FYBEQAEwNsVTFMP1n7njQsFyuTW/DOZWeYAvrt8DraJwCIqirUJAncP3XxtJH/9gPW0mGofqqqTYCSOhWO0osvzpItdH0xAk+dEx1SUFNzgiQ24MU5d2dRkAJS2BQWSHSR5kFig+SauDn/ePu0O+rzsbHxv3WjDeDE0SwNQFmxTXYJWabtQWXzC4Ek8r8SdgytPRF9BhjHwnuiUObmUkr7mjrIzY//Xu2mHOerBxims8n58Cj/lH2gjcG/V1/KhYvDRmblaOMrxvJ+l2kqoAMS4EWubaHtqPy7akSZCVyv3ARnNpp9o+DhApfBe7zKbZWtDbwabYIAMBoCj80YBIbbsPS6NjvLwbJ6TnVjUw1UGKEeQ1OoSOPlUsjNyUWU2mL2Eny6xIzd6sqB5qCVF8hkvhhd06j21Ka97q11Ro93ossbbuXhvSdyDThigAbeEhyoRmUnQuOrb7IqHa7T153L2X4rqazJvPxyuDWgByGZjIN8/hAeo5QVzSwzs7iIujgWj6xg5nvH4fLAKRs17nUCzQ3OKeEcitxvqi9peNwvbT+iQVVyFZlx9iozqWYWwnUNyy7faZfqu+MCqZttuQdHBNDWnO5E1cpjN9fkK2wyVe3nYGJ9+y+TqsocRAoxdAGGlKBtZpzU2A6kj1FL15n9/xsJuKsqb7Pv+uNawHoVO8BZjCqMd9eYhWzMQqwnNerzz2xxTFkd7dbwvmQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1oJkfKEdiHZujGjuKalnFIfuHCoouNHOg/kWseEJpdubMKDoWhB6yojlBimp?= =?us-ascii?Q?rfUIIV8h+UoNanHQEFvsIb7Y/chJYcR8h4kohADR35AAWBPMjlOD3C0WCHhz?= =?us-ascii?Q?OpG2OHL4jmooLQPkqoT0cxy3SDPhBdN/2Szmu0rm6QdapJyF03VjhuMs/4+N?= =?us-ascii?Q?cyhnDIEHAsu8NBAyAyKkvlABdkN7oyqBgtJYoiGaEfQnrMrgqTHrcozRfL7z?= =?us-ascii?Q?YEq93IusMuuuYrImYTftBOAvymvQYc88wQ32Ze9xnEwmRB3wM8ZXX0EN0INM?= =?us-ascii?Q?sBJcwvoKeRvbfH6YegkxEWnO79cCczeQyLX6/cmCeVoDS10xNz0gtf3HBvb2?= =?us-ascii?Q?/cAeEMvnYBDhFr7jGqFxh2EcgS7MVgukPBkuu2qx3aszCmzST07JL2qIyMUT?= =?us-ascii?Q?8u/BeR6PP/kQEH/+UjSYA+wgzolPDCSXdPD2ljTnZsb5kicp6oXnXCPs/V7h?= =?us-ascii?Q?Zv8himiK6nOP2J5K2ytlZ5FbZiO3Synk7gLosP7PiRdOx9LwH91W913X6o9E?= =?us-ascii?Q?UufjQFIblwjY/zt4jdhMVHW9H7AepUtSKpGlRXsvdHYI9UJEsLPBbbNqQpMY?= =?us-ascii?Q?YGmy93HlWzMIx1lOBJJXt7d1rDwVh44YJ1zh1ElNoo0QryEXgNn2+Q5k+TYh?= =?us-ascii?Q?zwUsQQ6X45HvVKW8o1WgD3Oa12bbf3yIHBRE0In+D6aBfmOpGbsS5hevWa6E?= =?us-ascii?Q?hfFO7UWNVs+WDli90QztX0P3LvkhrvUGK8lO5myGQ8Q+DbXhOXbh1FPx8E/2?= =?us-ascii?Q?XYEaTbAMpPY0IdZOb4tUhxqmUCJSuhNdu8tldRzNtZZxvKiivtISpPyET4mq?= =?us-ascii?Q?IssQRJq0O8l64LbwabE/BSDNsLC0VhV1SY5BIe+GEn29S2vxX5J2uYfaWpsJ?= =?us-ascii?Q?DeWnfjXfdYziYTJLp52uOR2tRPQwc5iBuIF7LxhDKJhM4dzz1+7u4/oJDTkB?= =?us-ascii?Q?Dpdd2k3J89UZA7lMZcq62GMiuB+1EB7NPF7W5Jb44WRxgJUZ9ctjcdRtW1Kk?= =?us-ascii?Q?o61otavt1jurQ0cOVwKUD8FEfbzbh/yRMWwPJ1sEyF/RIQuhwOXN6trqOZ8o?= =?us-ascii?Q?nH2lFlhtw2PiFfIFAtnlk2pn9S1uatr5DZkJId7w6LnF3CFCgli5dnExvG1i?= =?us-ascii?Q?DBY97bjXPpzsSNyC7beLc6DqrO2QUMEPBDVrD4DGxt06fSCL6duqtpTXXNaR?= =?us-ascii?Q?kyFlfINAsAAOpdVR5jODCutiRH/L6n47TI16JJdWO4tsVP94uZCs5PJxFv8W?= =?us-ascii?Q?LR13xFQ3xvSkGyVPlNrZ2ItpGUgNhcjnkmVtdA3zvqhsBF8BnuXBIuL7LNR/?= =?us-ascii?Q?1/WImqUtSWyucL4rT4pI5kENE3/+z+shLxcBsXyeBmh7I1WE4QM1AlE78OIW?= =?us-ascii?Q?D50q0zK1EYdAQoB+K2+uUNxB9Z8dSfcRy2fteh+FaP64ipdd/QoQGVfTwW4t?= =?us-ascii?Q?pBsSBwOrCY20qIyZl/Z7qFEfgHL2YaPveZckwCfchqrK+L8ZdJvQgdnW5tLj?= =?us-ascii?Q?QXyEfeHuU0GM6uzWdMJGi7bT7A5qOiJgbcm5n5aOOu9pn+Y5Txkz5Q/HsoW4?= =?us-ascii?Q?gLlMxkOQs3yGx9KaPX0np5Vg5UkzQlX2MUipAoNv9k1ESXJSd+oLDX8tG/zz?= =?us-ascii?Q?E4pPUkwAhNUsc9Xakrxq9BjxUgeWnoz16lBIQQ61YJScLMnmbcSbcRrlxcvP?= =?us-ascii?Q?OSdKQw=3D=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 286f3ac8-1f23-4a74-44e4-08d9b480c5dd X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 04:12:22.1208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0WdAXMErYrvLSSGBIHlwqqZ7MKfBT1dsp3NTZ3G27lYXGxNSO7gehpD+YX3o0vovJ/Ae08u8LrOAt8AiDNd5Sv1A0MrXTCvkCi2F5TTj/Q8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6539 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: zzriAPb8EqQxrbrw6HfqtASTx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1638331944; bh=GtT4xgDUpEccKPn/IuXb0Aj9lDL7RAsZucU5OnLpJjc=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=SMRSJMa3LFY47vR5Rz5Bp8I6Nlzf8AuLAUn5P3ImXBwV66R73ZqjTb7C+R3JS9lqP0m uOAP7jeG2RleVIPil2nKem4w/uWb6mFZELhP6tDQ9xhRADXmrrVpiulnJ+r7QFEBzR4zs 9lkXJaGbPytpmXClkZJDfx36N+u+5c2CO3E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1638331945337100006 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, the serial and part number of a processor are filled with fixed PCDs. However, they may be updated dynamically according to the information being passed from a the pre-UEFI firmware during booting. So, this patch is to support updating these string fields from OemMiscLib if the PCDs are empty. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Rebecca Cran Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h | 2 ++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++= ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index aa68c0a92632..5f0effa9cc17 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -60,6 +60,8 @@ typedef enum ChassisTypeType03, ManufacturerType03, SkuNumberType03, + ProcessorPartNumType04, + ProcessorSerialNumType04, SmbiosHiiStringFieldMax } OEM_MISC_SMBIOS_HII_STRING_FIELD; =20 diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass= .c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c index fb484086a457..8d884d313bd4 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c @@ -493,9 +493,19 @@ AllocateType4AndSetProcessorInformationStrings ( =20 SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorManufacturer, ProcessorManu= ); SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorVersion, ProcessorVersion); - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorSerialNumber, SerialNumber); SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorAssetTag, AssetTag); - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorPartNumber, PartNumber); + + if (StrLen ((CHAR16 *)PcdGetPtr (PcdProcessorSerialNumber)) > 0) { + HiiSetString (mHiiHandle, SerialNumber, (CHAR16 *)PcdGetPtr (PcdProces= sorSerialNumber), NULL); + } else { + OemUpdateSmbiosInfo (mHiiHandle, SerialNumber, ProcessorSerialNumType0= 4); + } + + if (StrLen ((CHAR16 *)PcdGetPtr (PcdProcessorPartNumber)) > 0) { + HiiSetString (mHiiHandle, PartNumber, (CHAR16 *)PcdGetPtr (PcdProcesso= rPartNumber), NULL); + } else { + OemUpdateSmbiosInfo (mHiiHandle, PartNumber, ProcessorPartNumType04); + } =20 // Processor Designation StringBufferSize =3D sizeof (CHAR16) * SMBIOS_STRING_MAX_LENGTH; --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84194): https://edk2.groups.io/g/devel/message/84194 Mute This Topic: https://groups.io/mt/87420728/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-