.../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
In the success case we should return EFI_SUCCESS rather than returning
a potentially unitialized value of Status.
Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Signed-off-by: Moritz Fischer <moritzf@google.com>
---
.../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
index 0bdb6c24c5bb..e9e1a85ede63 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
@@ -91,7 +91,7 @@ LinkRdNode (
*NewRdNode = RdNode;
}
- return Status;
+ return EFI_SUCCESS;
error_handler:
Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);
--
2.33.0.1079.g6e70778dc9-goog
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82412): https://edk2.groups.io/g/devel/message/82412
Mute This Topic: https://groups.io/mt/86458612/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Hi Moritz, Thank you for this fix. Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 20/10/2021 06:21 AM, Moritz Fischer wrote: > In the success case we should return EFI_SUCCESS rather than returning > a potentially unitialized value of Status. > > Cc: Sami Mujawar <Sami.Mujawar@arm.com> > Cc: Alexei Fedorov <Alexei.Fedorov@arm.com> > Signed-off-by: Moritz Fischer <moritzf@google.com> > --- > .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > index 0bdb6c24c5bb..e9e1a85ede63 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > @@ -91,7 +91,7 @@ LinkRdNode ( > *NewRdNode = RdNode; > } > > - return Status; > + return EFI_SUCCESS; > > error_handler: > Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode); -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82417): https://edk2.groups.io/g/devel/message/82417 Mute This Topic: https://groups.io/mt/86458612/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Merged as 37a33f02aa1a..4fdf843c75d2 Thanks. Regards, Sami Mujawar On 20/10/2021 10:40 AM, Sami Mujawar wrote: > Hi Moritz, > > Thank you for this fix. > > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> > > Regards, > > Sami Mujawar > > On 20/10/2021 06:21 AM, Moritz Fischer wrote: >> In the success case we should return EFI_SUCCESS rather than returning >> a potentially unitialized value of Status. >> >> Cc: Sami Mujawar <Sami.Mujawar@arm.com> >> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com> >> Signed-off-by: Moritz Fischer <moritzf@google.com> >> --- >> .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> >> index 0bdb6c24c5bb..e9e1a85ede63 100644 >> --- >> a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> +++ >> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> @@ -91,7 +91,7 @@ LinkRdNode ( >> *NewRdNode = RdNode; >> } >> - return Status; >> + return EFI_SUCCESS; >> error_handler: >> Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode); > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82418): https://edk2.groups.io/g/devel/message/82418 Mute This Topic: https://groups.io/mt/86458612/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.