From nobody Tue May 14 14:38:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+81829+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81829+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1634044324; cv=none; d=zohomail.com; s=zohoarc; b=bRHDgW+AxlbZByED3MpwgK9TM3znuT7OjUkv5pOesqAHzSUzhjRJgEJ1he8AAOQOt+R7wq+mLUycuVzqdjL+acNQ3RYHRm0uJ+Srv6VDdoBe0FMWc21gz6xQpvm72a65QnVPWTFdZXv3VWnu2k7ZaRubZ216Wj52PnOWlLvUOMQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634044324; h=Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=mfVYg4kpZz/SVZ4ENk2p7f/WXvV+1z98YxdDoIHGyzc=; b=McXJkO6t/XuZQR2/jC4a8AXqdPNqAzeHUP9g0Emid+8CZ6TYaPLa2MUFQUusHgf5AlhESRdfasQiLOuhmpxEEXBVCSRtD+iaf8CPS9VxGgdc8whBBDLB+TCIYXYOI/xY63R7QcBU/AMn2z1fylZjhTbyBlByhXcbmywCMFkc/5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+81829+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 163404432425443.57498538247114; Tue, 12 Oct 2021 06:12:04 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7L1OYY1788612xQh3jLJSNRB; Tue, 12 Oct 2021 06:12:03 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.13787.1634044322892592702 for ; Tue, 12 Oct 2021 06:12:03 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D5AB1ED1; Tue, 12 Oct 2021 06:12:01 -0700 (PDT) X-Received: from u203013-lin.austin.arm.com (u203013-lin.austin.arm.com [10.118.29.243]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC3CC3F70D; Tue, 12 Oct 2021 06:12:01 -0700 (PDT) From: "Joseph Hemann" To: devel@edk2.groups.io Cc: nd@arm.com, Joseph Hemann , Jiewen Yao , Jian J Wang , Min Xu Subject: [edk2-devel] [PATCH] SecurityPkg/DxeImageVerificationLib: Set Action for failed signed image Date: Tue, 12 Oct 2021 08:11:55 -0500 Message-Id: <20211012131155.43788-1-joseph.hemann@arm.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joseph.hemann@arm.com X-Gm-Message-State: IwMiTRQ6FCdlCFyWCRWZZfWHx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634044323; bh=oMcvqp+ga+TEfbAK9Y2JG16WG3izBh/Pr3W8+OQYMqY=; h=Cc:Date:From:Reply-To:Subject:To; b=da6u5oATQTtLdmjGK9KduQWIw/CIxhT1etmh4XJxg3oKpLAlNQiHsH1KygDJ4x7QgHG 9QbAlswTf55Sw8mARY7O4ykXKjthmQxSwWYnY/1BxSL/aIQMkaL3VBS0h7EOWGgMV5SjB kr89sEXL6QS7mV4+WMaisDpF2laJn0P7lQk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634044325361100002 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Joseph Hemann If the image is signed but not allowed by DB and the hash of image is not found in DB/DBX, then the EFI_IMAGE_INFO_ACTION of the load of said image should be set to, EFI_IMAGE_EXECUTION_AUTH_SIG_NOT_FOUND, rather then being left unset as EFI_IMAGE_EXECUTION_AUTH_UNTESTED. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Signed-off-by: Joseph Hemann Change-Id: I271fb61384e5b8bb5ac23ccba5de9ba77adb85ad --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificati= onLib.c b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationL= ib.c index c48861cd64..0a804af216 100644 --- a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c +++ b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c @@ -1957,6 +1957,7 @@ DxeImageVerificationHandler ( if (!EFI_ERROR (DbStatus) && IsFound) { IsVerified =3D TRUE; } else { + Action =3D EFI_IMAGE_EXECUTION_AUTH_SIG_NOT_FOUND; DEBUG ((DEBUG_INFO, "DxeImageVerificationLib: Image is signed but = signature is not allowed by DB and %s hash of image is not found in DB/DBX.= \n", mHashTypeStr)); } } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81829): https://edk2.groups.io/g/devel/message/81829 Mute This Topic: https://groups.io/mt/86261682/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-