1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates

Laszlo Ersek posted 5 patches 6 years, 1 month ago
Failed in applying to current master (apply log)
NetworkPkg/HttpBootDxe/HttpBootDhcp4.c          |  4 +-
NetworkPkg/HttpDxe/HttpDxe.inf                  |  3 +-
NetworkPkg/HttpDxe/HttpsSupport.c               | 74 ++++++++++++++++++--
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++--
4 files changed, 80 insertions(+), 16 deletions(-)
[edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates
Posted by Laszlo Ersek 6 years, 1 month ago 
Repo:   https://github.com/lersek/edk2.git
Branch: http_and_tls_updates

Patch #4 fixes TianoCore BZ#909
<https://bugzilla.tianocore.org/show_bug.cgi?id=909>.

Patches #2 and #3 are cleanups / preparation for patch #4.

Patch #1 fixes an independent typo that I noticed in the code while
configuring my DHCP server for HTTP(S) booting. It's isolated, so I put
it first in the series.

Patch #5 is preparation for future platform enablement, so that a
platform can create both "TlsCaCertificate" and "HttpTlsCipherList"
variables on every boot from scratch as volatile variables (without
flash varstore footprint).

I regression-tested this series with a successful HTTPS boot of an ISO
image from OVMF, using a DER-formatted self-signed certificate that I
enrolled with TlsAuthConfigDxe.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>

Thanks,
Laszlo

Laszlo Ersek (5):
  NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing
  NetworkPkg/HttpDxe: use error handler epilogue in
    TlsConfigCertificate()
  NetworkPkg/HttpDxe: drop misleading comment / status code in cert
    config
  NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before
    use
  NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable
    attributes

 NetworkPkg/HttpBootDxe/HttpBootDhcp4.c          |  4 +-
 NetworkPkg/HttpDxe/HttpDxe.inf                  |  3 +-
 NetworkPkg/HttpDxe/HttpsSupport.c               | 74 ++++++++++++++++++--
 NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++--
 4 files changed, 80 insertions(+), 16 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates
Posted by Laszlo Ersek 6 years ago 
Siyuan, Jiaxin,

do you have any comments please?

Thanks,
Laszlo

On 03/22/18 17:39, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: http_and_tls_updates
> 
> Patch #4 fixes TianoCore BZ#909
> <https://bugzilla.tianocore.org/show_bug.cgi?id=909>.
> 
> Patches #2 and #3 are cleanups / preparation for patch #4.
> 
> Patch #1 fixes an independent typo that I noticed in the code while
> configuring my DHCP server for HTTP(S) booting. It's isolated, so I put
> it first in the series.
> 
> Patch #5 is preparation for future platform enablement, so that a
> platform can create both "TlsCaCertificate" and "HttpTlsCipherList"
> variables on every boot from scratch as volatile variables (without
> flash varstore footprint).
> 
> I regression-tested this series with a successful HTTPS boot of an ISO
> image from OVMF, using a DER-formatted self-signed certificate that I
> enrolled with TlsAuthConfigDxe.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (5):
>   NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing
>   NetworkPkg/HttpDxe: use error handler epilogue in
>     TlsConfigCertificate()
>   NetworkPkg/HttpDxe: drop misleading comment / status code in cert
>     config
>   NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before
>     use
>   NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable
>     attributes
> 
>  NetworkPkg/HttpBootDxe/HttpBootDhcp4.c          |  4 +-
>  NetworkPkg/HttpDxe/HttpDxe.inf                  |  3 +-
>  NetworkPkg/HttpDxe/HttpsSupport.c               | 74 ++++++++++++++++++--
>  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++--
>  4 files changed, 80 insertions(+), 16 deletions(-)
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates
Posted by Wu, Jiaxin 6 years ago 
Series Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>

Thanks,
Jiaxin

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, March 23, 2018 12:39 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [PATCH 0/5] NetworkPkg: HTTP and TLS updates
> 
> Repo:   https://github.com/lersek/edk2.git
> Branch: http_and_tls_updates
> 
> Patch #4 fixes TianoCore BZ#909
> <https://bugzilla.tianocore.org/show_bug.cgi?id=909>.
> 
> Patches #2 and #3 are cleanups / preparation for patch #4.
> 
> Patch #1 fixes an independent typo that I noticed in the code while
> configuring my DHCP server for HTTP(S) booting. It's isolated, so I put
> it first in the series.
> 
> Patch #5 is preparation for future platform enablement, so that a
> platform can create both "TlsCaCertificate" and "HttpTlsCipherList"
> variables on every boot from scratch as volatile variables (without
> flash varstore footprint).
> 
> I regression-tested this series with a successful HTTPS boot of an ISO
> image from OVMF, using a DER-formatted self-signed certificate that I
> enrolled with TlsAuthConfigDxe.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (5):
>   NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing
>   NetworkPkg/HttpDxe: use error handler epilogue in
>     TlsConfigCertificate()
>   NetworkPkg/HttpDxe: drop misleading comment / status code in cert
>     config
>   NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before
>     use
>   NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable
>     attributes
> 
>  NetworkPkg/HttpBootDxe/HttpBootDhcp4.c          |  4 +-
>  NetworkPkg/HttpDxe/HttpDxe.inf                  |  3 +-
>  NetworkPkg/HttpDxe/HttpsSupport.c               | 74 ++++++++++++++++++--
>  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++--
>  4 files changed, 80 insertions(+), 16 deletions(-)
> 
> --
> 2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates
Posted by Laszlo Ersek 6 years ago 
On 03/28/18 07:35, Wu, Jiaxin wrote:
> Series Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>

Thank you both for reviewing this series while being out-of-office!

Pushed: 699a2c30cb6e..b90c335fbbb6.

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates
Posted by Fu, Siyuan 6 years ago 
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>


> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, March 22, 2018 9:39 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [PATCH 0/5] NetworkPkg: HTTP and TLS updates
> 
> Repo:   https://github.com/lersek/edk2.git
> Branch: http_and_tls_updates
> 
> Patch #4 fixes TianoCore BZ#909
> <https://bugzilla.tianocore.org/show_bug.cgi?id=909>.
> 
> Patches #2 and #3 are cleanups / preparation for patch #4.
> 
> Patch #1 fixes an independent typo that I noticed in the code while
> configuring my DHCP server for HTTP(S) booting. It's isolated, so I put
> it first in the series.
> 
> Patch #5 is preparation for future platform enablement, so that a
> platform can create both "TlsCaCertificate" and "HttpTlsCipherList"
> variables on every boot from scratch as volatile variables (without
> flash varstore footprint).
> 
> I regression-tested this series with a successful HTTPS boot of an ISO
> image from OVMF, using a DER-formatted self-signed certificate that I
> enrolled with TlsAuthConfigDxe.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (5):
>   NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing
>   NetworkPkg/HttpDxe: use error handler epilogue in
>     TlsConfigCertificate()
>   NetworkPkg/HttpDxe: drop misleading comment / status code in cert
>     config
>   NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before
>     use
>   NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable
>     attributes
> 
>  NetworkPkg/HttpBootDxe/HttpBootDhcp4.c          |  4 +-
>  NetworkPkg/HttpDxe/HttpDxe.inf                  |  3 +-
>  NetworkPkg/HttpDxe/HttpsSupport.c               | 74 ++++++++++++++++++--
>  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++--
>  4 files changed, 80 insertions(+), 16 deletions(-)
> 
> --
> 2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.