UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as the macro value

[edk2] [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as the macro value

Posted by Liming Gao 6 years, 1 month ago

FixedPcdGetSize() is used as the macro value, PcdGetSize() is used as global
variable or function. Here usage is to access macro value.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Wang Jian J <jian.j.wang@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
---
 UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
index d9ded5977f..ac3650a2a3 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
@@ -1,7 +1,7 @@
 /** @file
   Ia32 arch definition for CPU Exception Handler Library.
 
-  Copyright (c) 2013, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -43,10 +43,10 @@ typedef struct {
 
 #define CPU_TSS_DESC_SIZE \
   (sizeof (IA32_TSS_DESCRIPTOR) * \
-   (PcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
+   (FixedPcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
 
 #define CPU_TSS_SIZE \
   (sizeof (IA32_TASK_STATE_SEGMENT) * \
-   (PcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
+   (FixedPcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
 
 #endif
-- 
2.11.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as the macro value

Posted by Wang, Jian J 6 years, 1 month ago

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, March 16, 2018 9:47 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as
> the macro value
> 
> FixedPcdGetSize() is used as the macro value, PcdGetSize() is used as global
> variable or function. Here usage is to access macro value.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Wang Jian J <jian.j.wang@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> ---
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h | 6 +++-
> --
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> index d9ded5977f..ac3650a2a3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Ia32 arch definition for CPU Exception Handler Library.
> 
> -  Copyright (c) 2013, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be found
> at
> @@ -43,10 +43,10 @@ typedef struct {
> 
>  #define CPU_TSS_DESC_SIZE \
>    (sizeof (IA32_TSS_DESCRIPTOR) * \
> -   (PcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> +   (FixedPcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> 
>  #define CPU_TSS_SIZE \
>    (sizeof (IA32_TASK_STATE_SEGMENT) * \
> -   (PcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> +   (FixedPcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> 
>  #endif
> --
> 2.11.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel