1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable

Jian J Wang posted 1 patch 6 years, 4 months ago
Failed in applying to current master (apply log)
UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++
1 file changed, 2 insertions(+)
[edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable
Posted by Jian J Wang 6 years, 4 months ago 
The purpose of the patch is just to avoid complaining from compiler and
static check tool.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Wu Hao <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
index 56ba026152..61018c9950 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.c
+++ b/UefiCpuPkg/CpuDxe/CpuMp.c
@@ -695,6 +695,8 @@ InitializeMpExceptionStackSwitchHandlers (
   EssData.Ia32.StackSwitchExceptionNumber = ExceptionNumber;
   EssData.Ia32.KnownGoodStackSize = FixedPcdGet32(PcdCpuKnownGoodStackSize);
 
+  Gdtr.Base = 0;
+  Gdtr.Limit = 0;
   MpInitLibWhoAmI (&Bsp);
   for (Index = 0; Index < mNumberOfProcessors; ++Index) {
     //
-- 
2.15.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable
Posted by Dong, Eric 6 years, 4 months ago 
Reviewed-by: Eric Dong <eric.dong@intel.com>

-----Original Message-----
From: Wang, Jian J 
Sent: Tuesday, December 12, 2017 11:28 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric; Wu, Hao A
Subject: [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable

The purpose of the patch is just to avoid complaining from compiler and static check tool.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Wu Hao <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c index 56ba026152..61018c9950 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.c
+++ b/UefiCpuPkg/CpuDxe/CpuMp.c
@@ -695,6 +695,8 @@ InitializeMpExceptionStackSwitchHandlers (
   EssData.Ia32.StackSwitchExceptionNumber = ExceptionNumber;
   EssData.Ia32.KnownGoodStackSize = FixedPcdGet32(PcdCpuKnownGoodStackSize);
 
+  Gdtr.Base = 0;
+  Gdtr.Limit = 0;
   MpInitLibWhoAmI (&Bsp);
   for (Index = 0; Index < mNumberOfProcessors; ++Index) {
     //
--
2.15.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable
Posted by Wu, Hao A 6 years, 4 months ago 
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> -----Original Message-----
> From: Wang, Jian J
> Sent: Tuesday, December 12, 2017 11:28 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Wu, Hao A
> Subject: [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable
> 
> The purpose of the patch is just to avoid complaining from compiler and
> static check tool.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Wu Hao <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
> index 56ba026152..61018c9950 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.c
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c
> @@ -695,6 +695,8 @@ InitializeMpExceptionStackSwitchHandlers (
>    EssData.Ia32.StackSwitchExceptionNumber = ExceptionNumber;
>    EssData.Ia32.KnownGoodStackSize =
> FixedPcdGet32(PcdCpuKnownGoodStackSize);
> 
> +  Gdtr.Base = 0;
> +  Gdtr.Limit = 0;
>    MpInitLibWhoAmI (&Bsp);
>    for (Index = 0; Index < mNumberOfProcessors; ++Index) {
>      //
> --
> 2.15.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable
Posted by Laszlo Ersek 6 years, 4 months ago 
Hello Jian,

On 12/12/17 04:28, Jian J Wang wrote:
> The purpose of the patch is just to avoid complaining from compiler and
> static check tool.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Wu Hao <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
> index 56ba026152..61018c9950 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.c
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c
> @@ -695,6 +695,8 @@ InitializeMpExceptionStackSwitchHandlers (
>    EssData.Ia32.StackSwitchExceptionNumber = ExceptionNumber;
>    EssData.Ia32.KnownGoodStackSize = FixedPcdGet32(PcdCpuKnownGoodStackSize);
>  
> +  Gdtr.Base = 0;
> +  Gdtr.Limit = 0;
>    MpInitLibWhoAmI (&Bsp);
>    for (Index = 0; Index < mNumberOfProcessors; ++Index) {
>      //
> 

(1) Please add a separate comment, in the style that is described in
<https://bugzilla.tianocore.org/show_bug.cgi?id=607>:

  //
  // set Gdtr to suppress incorrect compiler/analyzer warnings
  //
  Gdtr.Base = 0;
  Gdtr.Limit = 0;


(2) I suggest updating the subject line like this:

UefiCpuPkg/CpuDxe: suppress invalid warning about uninitialized variable

(72 characters)

With those changes:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable
Posted by Wang, Jian J 6 years, 4 months ago 
Got it. Thanks for the feedback.

Regards,
Jian

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, December 12, 2017 5:27 PM
> To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local
> variable
> 
> Hello Jian,
> 
> On 12/12/17 04:28, Jian J Wang wrote:
> > The purpose of the patch is just to avoid complaining from compiler and
> > static check tool.
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Wu Hao <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> > ---
> >  UefiCpuPkg/CpuDxe/CpuMp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
> > index 56ba026152..61018c9950 100644
> > --- a/UefiCpuPkg/CpuDxe/CpuMp.c
> > +++ b/UefiCpuPkg/CpuDxe/CpuMp.c
> > @@ -695,6 +695,8 @@ InitializeMpExceptionStackSwitchHandlers (
> >    EssData.Ia32.StackSwitchExceptionNumber = ExceptionNumber;
> >    EssData.Ia32.KnownGoodStackSize =
> FixedPcdGet32(PcdCpuKnownGoodStackSize);
> >
> > +  Gdtr.Base = 0;
> > +  Gdtr.Limit = 0;
> >    MpInitLibWhoAmI (&Bsp);
> >    for (Index = 0; Index < mNumberOfProcessors; ++Index) {
> >      //
> >
> 
> (1) Please add a separate comment, in the style that is described in
> <https://bugzilla.tianocore.org/show_bug.cgi?id=607>:
> 
>   //
>   // set Gdtr to suppress incorrect compiler/analyzer warnings
>   //
>   Gdtr.Base = 0;
>   Gdtr.Limit = 0;
> 
> 
> (2) I suggest updating the subject line like this:
> 
> UefiCpuPkg/CpuDxe: suppress invalid warning about uninitialized variable
> 
> (72 characters)
> 
> With those changes:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks!
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.