[v2] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

[edk2] [PATCH v2 0/5] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

Ard Biesheuvel posted 5 patches 6 years, 4 months ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

ArmPlatformPkg/ArmPlatformPkg.dec                                                                       |  1 +
ArmPlatformPkg/ArmPlatformPkg.dsc                                                                       |  5 +-
ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h                                      | 21 +-----
ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/{PL111LcdGraphicsOutputDxe.inf => LcdGraphicsOutputDxe.inf} | 32 ++++-----
ArmPlatformPkg/Include/Library/LcdHwLib.h                                                               | 68 ++++++++++++++++++
ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.c                                  | 28 +++++++-
ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.h                                  |  0
ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf => Library/HdLcd/HdLcd.inf}     | 32 ++-------
ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.c                                                      | 75 ++++++++++++++++++++
ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.inf                                                    | 28 ++++++++
ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.c                            |  5 +-
ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.h                            |  0
ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf                                                            | 40 +++++++++++
13 files changed, 266 insertions(+), 69 deletions(-)
rename ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/{PL111LcdGraphicsOutputDxe.inf => LcdGraphicsOutputDxe.inf} (73%)
create mode 100644 ArmPlatformPkg/Include/Library/LcdHwLib.h
rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.c (86%)
rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.h (100%)
rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf => Library/HdLcd/HdLcd.inf} (56%)
create mode 100644 ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.c
create mode 100644 ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.inf
rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.c (94%)
rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.h (100%)
create mode 100644 ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf

Expand all Fold all

[edk2] [PATCH v2 0/5] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

Posted by Ard Biesheuvel 6 years, 4 months ago

This is a rework of the patch 'ArmPlatformPkg: Reorganize Lcd Graphics Output'
sent out by Evan on September 26 [0]

I have split it up for easier review, and droppped then changes to VExpress
specific libraries and instead, moved those into edk2-platforms. A separate
series is forthcoming. All patches of this series except the last one can
be merged before the edk2-platforms series.

The purpose is to separate the LCD output graphics driver from ARM VExpress
specific details, so that the core code can be reused more easily, and the
platform specific code moved out of the main EDK2 repository.

v2: the VExpress specific bits are already gone, so what remains is the
    refactoring of LcdGraphicsOutputDxe itself.

Cc: Girish Pathak <girish.pathak@arm.com>
Cc: Evan Lloyd <evan.lloyd@arm.com>

[0] https://lists.01.org/pipermail/edk2-devel/2017-September/015337.html

Ard Biesheuvel (5):
  ArmPlatformPkg: introduce LcdHwLib library class
  ArmPlatformPkg: implement LcdHwLib for PL111
  ArmPlatformPkg: implement LcdHwLib for HdLcd
  ArmPlatformPkg: create hw-agnostic LcdGraphicsOutputDxe driver
  ArmPlatformPkg: remove old PL111/HdLcd driver code

 ArmPlatformPkg/ArmPlatformPkg.dec                                                                       |  1 +
 ArmPlatformPkg/ArmPlatformPkg.dsc                                                                       |  5 +-
 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h                                      | 21 +-----
 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/{PL111LcdGraphicsOutputDxe.inf => LcdGraphicsOutputDxe.inf} | 32 ++++-----
 ArmPlatformPkg/Include/Library/LcdHwLib.h                                                               | 68 ++++++++++++++++++
 ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.c                                  | 28 +++++++-
 ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.h                                  |  0
 ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf => Library/HdLcd/HdLcd.inf}     | 32 ++-------
 ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.c                                                      | 75 ++++++++++++++++++++
 ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.inf                                                    | 28 ++++++++
 ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.c                            |  5 +-
 ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.h                            |  0
 ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf                                                            | 40 +++++++++++
 13 files changed, 266 insertions(+), 69 deletions(-)
 rename ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/{PL111LcdGraphicsOutputDxe.inf => LcdGraphicsOutputDxe.inf} (73%)
 create mode 100644 ArmPlatformPkg/Include/Library/LcdHwLib.h
 rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.c (86%)
 rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/HdLcd}/HdLcd.h (100%)
 rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf => Library/HdLcd/HdLcd.inf} (56%)
 create mode 100644 ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.c
 create mode 100644 ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.inf
 rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.c (94%)
 rename ArmPlatformPkg/{Drivers/LcdGraphicsOutputDxe => Library/PL111Lcd}/PL111Lcd.h (100%)
 create mode 100644 ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/5] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

Posted by Ard Biesheuvel 6 years, 4 months ago

On 8 December 2017 at 17:31, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> This is a rework of the patch 'ArmPlatformPkg: Reorganize Lcd Graphics Output'
> sent out by Evan on September 26 [0]
>
> I have split it up for easier review, and droppped then changes to VExpress
> specific libraries and instead, moved those into edk2-platforms. A separate
> series is forthcoming. All patches of this series except the last one can
> be merged before the edk2-platforms series.
>
> The purpose is to separate the LCD output graphics driver from ARM VExpress
> specific details, so that the core code can be reused more easily, and the
> platform specific code moved out of the main EDK2 repository.
>
> v2: the VExpress specific bits are already gone, so what remains is the
>     refactoring of LcdGraphicsOutputDxe itself.
>
> Cc: Girish Pathak <girish.pathak@arm.com>
> Cc: Evan Lloyd <evan.lloyd@arm.com>
>
> [0] https://lists.01.org/pipermail/edk2-devel/2017-September/015337.html
>
> Ard Biesheuvel (5):
>   ArmPlatformPkg: introduce LcdHwLib library class
>   ArmPlatformPkg: implement LcdHwLib for PL111
>   ArmPlatformPkg: implement LcdHwLib for HdLcd
>   ArmPlatformPkg: create hw-agnostic LcdGraphicsOutputDxe driver
>   ArmPlatformPkg: remove old PL111/HdLcd driver code
>

Patches #1 - #4 pushed as e3e40c83fd2c..2671d8989004
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/5] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

Posted by Ard Biesheuvel 6 years, 4 months ago

On 12 December 2017 at 17:44, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 8 December 2017 at 17:31, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> This is a rework of the patch 'ArmPlatformPkg: Reorganize Lcd Graphics Output'
>> sent out by Evan on September 26 [0]
>>
>> I have split it up for easier review, and droppped then changes to VExpress
>> specific libraries and instead, moved those into edk2-platforms. A separate
>> series is forthcoming. All patches of this series except the last one can
>> be merged before the edk2-platforms series.
>>
>> The purpose is to separate the LCD output graphics driver from ARM VExpress
>> specific details, so that the core code can be reused more easily, and the
>> platform specific code moved out of the main EDK2 repository.
>>
>> v2: the VExpress specific bits are already gone, so what remains is the
>>     refactoring of LcdGraphicsOutputDxe itself.
>>
>> Cc: Girish Pathak <girish.pathak@arm.com>
>> Cc: Evan Lloyd <evan.lloyd@arm.com>
>>
>> [0] https://lists.01.org/pipermail/edk2-devel/2017-September/015337.html
>>
>> Ard Biesheuvel (5):
>>   ArmPlatformPkg: introduce LcdHwLib library class
>>   ArmPlatformPkg: implement LcdHwLib for PL111
>>   ArmPlatformPkg: implement LcdHwLib for HdLcd
>>   ArmPlatformPkg: create hw-agnostic LcdGraphicsOutputDxe driver
>>   ArmPlatformPkg: remove old PL111/HdLcd driver code
>>
>
> Patches #1 - #4 pushed as e3e40c83fd2c..2671d8989004

Patch #5 pushed as ab3886f02da (after the prerequisites have been
merged into edk2-platforms)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel