ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

[edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

Posted by Ruiyu Ni 6 years, 5 months ago

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
 ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index d343f3352e..b7b0246ac9 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
         break;
       }
       if (Temp != NULL) {
-        Temp2 = CatSPrint(RetVal, L"%s", Temp);
+        Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
         FreePool(Temp);
         FreePool(RetVal);
         RetVal = Temp2;
@@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
       }
 
       Temp2 = CatSPrint(RetVal,
-        L"\r\n%%H%02x    %016lx  %016lx  %02x%%N",
+        L"%%H%02x    %016lx  %016lx  %02x%%N",
         Configuration->SpecificFlag,
         Configuration->AddrRangeMin,
         Configuration->AddrRangeMax,
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

Posted by Carsey, Jaben 6 years, 5 months ago

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, November 06, 2017 11:35 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping
> PciRootBridgeIo
> Importance: High
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index d343f3352e..b7b0246ac9 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
>          break;
>        }
>        if (Temp != NULL) {
> -        Temp2 = CatSPrint(RetVal, L"%s", Temp);
> +        Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
>          FreePool(Temp);
>          FreePool(RetVal);
>          RetVal = Temp2;
> @@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
>        }
> 
>        Temp2 = CatSPrint(RetVal,
> -        L"\r\n%%H%02x    %016lx  %016lx  %02x%%N",
> +        L"%%H%02x    %016lx  %016lx  %02x%%N",
>          Configuration->SpecificFlag,
>          Configuration->AddrRangeMin,
>          Configuration->AddrRangeMax,
> --
> 2.12.2.windows.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel