[v1] ShellPkg/HexEdit: Fix EBC build failure

[edk2] [PATCH] ShellPkg/HexEdit: Fix EBC build failure

Posted by Ruiyu Ni 6 years, 5 months ago

EfiCpuIoWidthUint8 should be used in HMemImageRead and HMemImageSave.
Because CpuIo protocol is now used for memory access.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
index fce9bbe0e6..12f1492583 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
@@ -139,7 +139,7 @@ HMemImageRead (
 
   Status = HMemImage.IoFncs->Mem.Read (
                                   HMemImage.IoFncs,
-                                  EfiPciWidthUint8,
+                                  EfiCpuIoWidthUint8,
                                   Offset,
                                   Size,
                                   Buffer
@@ -262,7 +262,7 @@ HMemImageSave (
   //
   Status = HMemImage.IoFncs->Mem.Write (
                                   HMemImage.IoFncs,
-                                  EfiPciWidthUint8,
+                                  EfiCpuIoWidthUint8,
                                   Offset,
                                   Size,
                                   Buffer
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/HexEdit: Fix EBC build failure

Posted by Carsey, Jaben 6 years, 5 months ago

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Friday, November 03, 2017 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/HexEdit: Fix EBC build failure
> Importance: High
> 
> EfiCpuIoWidthUint8 should be used in HMemImageRead and
> HMemImageSave.
> Because CpuIo protocol is now used for memory access.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4
> ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> index fce9bbe0e6..12f1492583 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> @@ -139,7 +139,7 @@ HMemImageRead (
> 
>    Status = HMemImage.IoFncs->Mem.Read (
>                                    HMemImage.IoFncs,
> -                                  EfiPciWidthUint8,
> +                                  EfiCpuIoWidthUint8,
>                                    Offset,
>                                    Size,
>                                    Buffer
> @@ -262,7 +262,7 @@ HMemImageSave (
>    //
>    Status = HMemImage.IoFncs->Mem.Write (
>                                    HMemImage.IoFncs,
> -                                  EfiPciWidthUint8,
> +                                  EfiCpuIoWidthUint8,
>                                    Offset,
>                                    Size,
>                                    Buffer
> --
> 2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel