From nobody Mon Apr 29 05:15:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1508842401155377.26096394804824; Tue, 24 Oct 2017 03:53:21 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id F25D92034CF9C; Tue, 24 Oct 2017 03:49:34 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 955E52034CF60 for ; Tue, 24 Oct 2017 03:49:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E56C734C4; Tue, 24 Oct 2017 10:53:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-52.rdu2.redhat.com [10.10.120.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id F189D18B05; Tue, 24 Oct 2017 10:53:14 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E56C734C4 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Tue, 24 Oct 2017 12:53:12 +0200 Message-Id: <20171024105312.18143-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 24 Oct 2017 10:53:17 +0000 (UTC) Subject: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Eric Dong , Andrew Fish , Leif Lindholm , Michael D Kinney MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" UefiCpuPkg hosts a number of modules (SMM infrastructure, MP-initialization) that may behave differently enough between virtualization guests and physical boards that they merit regression testing and review specifically from a virtualization perspective. Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on all UefiCpuPkg patches. > R: Package Reviewer: Cc address for patches and questions. Reviewers > help maintainers review code, but don't have push access. Cc: Andrew Fish Cc: Eric Dong Cc: Jeff Fan Cc: Leif Lindholm Cc: Michael D Kinney Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Eric Dong Reviewed-by: Leif Lindholm --- Notes: Recently there have been two UefiCpuPkg patches on the list that have each spent hardly more than 24 hours in review: =20 * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 resume finished.", 2017-10-11), =20 * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.", 2017-10-23). =20 Both times, I was out of office, and didn't get a chance to comment. The first commit broke OVMF: =20 http://mid.mail-archive.com/8d678707-fb07-0326-acfd-878bb7e8c5d6@redh= at.com https://github.com/tianocore/edk2/commit/152e8d7670d5 =20 while the second commit has a good chance to break OVMF on at least some virt hosts: =20 https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html =20 I was not CC'd either time. Had I been CC'd, the automated out-of-office reply that I always set up would have been received on the submitter's side, and I could have tested and/or commented on the patches in question, before they were pushed. =20 My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review process for UefiCpuPkg. I should be explicitly CC'd; and my feedback should please be waited upon. I think I've proved myself reasonably responsive; I intend to follow up in a few days every time. My review should definitely not replace Eric's review, but I'd like to get an *official* chance to raise questions before a patch is pushed. Whenever I have nothing to add, I'll send an Acked-by. Thanks. Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index c1a5723af9db..297a9bfd2b56 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -245,6 +245,7 @@ M: Jaben Carsey UefiCpuPkg W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg M: Eric Dong +R: Laszlo Ersek =20 UnixPkg W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel