IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning

[edk2] [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning

Posted by Jian J Wang 8 years, 4 months ago

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
index f42c13cd89..d249479c56 100644
--- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
+++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
@@ -59,9 +59,6 @@ LegacyBiosInt86 (
 {
   UINT16                Segment;
   UINT16                Offset;
-  LEGACY_BIOS_INSTANCE  *Private;
-
-  Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
 
   Regs->X.Flags.Reserved1 = 1;
   Regs->X.Flags.Reserved2 = 0;
-- 
2.14.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning

Posted by Bi, Dandan 8 years, 4 months ago

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

-----Original Message-----
From: Wang, Jian J 
Sent: Thursday, October 12, 2017 9:04 AM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
index f42c13cd89..d249479c56 100644
--- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
+++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
@@ -59,9 +59,6 @@ LegacyBiosInt86 (
 {
   UINT16                Segment;
   UINT16                Offset;
-  LEGACY_BIOS_INSTANCE  *Private;
-
-  Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
 
   Regs->X.Flags.Reserved1 = 1;
   Regs->X.Flags.Reserved2 = 0;
-- 
2.14.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning

Posted by Laszlo Ersek 8 years, 4 months ago

On 10/12/17 04:00, Bi, Dandan wrote:
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> 
> -----Original Message-----
> From: Wang, Jian J 
> Sent: Thursday, October 12, 2017 9:04 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> index f42c13cd89..d249479c56 100644
> --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> @@ -59,9 +59,6 @@ LegacyBiosInt86 (
>  {
>    UINT16                Segment;
>    UINT16                Offset;
> -  LEGACY_BIOS_INSTANCE  *Private;
> -
> -  Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
>  
>    Regs->X.Flags.Reserved1 = 1;
>    Regs->X.Flags.Reserved2 = 0;
> 

Looks like this has been committed already; thank you guys for the quick
action!

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel