Add FPDT Acpi table

[edk2] [PATCH 0/2] Add FPDT Acpi table

Posted by evan.lloyd@arm.com 6 years, 7 months ago

From: EvanLloyd <evan.lloyd@arm.com>


Paired patches for edk2 and edk2-platforms that add an FPDT
acpi table.
This is useful for monitoring firmware performance, etc.


Alexei Fedorov (1):
  ArmPlatformPkg: Store initial timer value

 ArmPlatformPkg/PrePi/PeiMPCore.inf  |  3 ++-
 ArmPlatformPkg/PrePi/PeiUniCore.inf |  3 ++-
 ArmPlatformPkg/PrePi/PrePi.c        | 10 +++++++++-
 3 files changed, 13 insertions(+), 3 deletions(-)

See https://github.com/EvanLloyd/tianocore/tree/164_FPDT_v1

Alexei Fedorov (1):
  ARM/JunoPkg: Add support for FPDT table.

 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++++-
 Platform/ARM/JunoPkg/ArmJuno.dsc             | 9 +++++++++
 Platform/ARM/JunoPkg/ArmJuno.fdf             | 6 ++++++
 3 files changed, 23 insertions(+), 1 deletion(-)

See https://github.com/EvanLloyd/edk2-platforms/tree/164_FPDT_v1

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

Posted by Graeme Gregory 6 years, 6 months ago

On 22 September 2017 at 17:18,  <evan.lloyd@arm.com> wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
>
>
> Paired patches for edk2 and edk2-platforms that add an FPDT
> acpi table.
> This is useful for monitoring firmware performance, etc.
>
From ACPI on ARM point of view this looks fine to me.

Reviewed-by: Graeme Gregory <graeme.gregory@linaro.org>

>
> Alexei Fedorov (1):
>   ArmPlatformPkg: Store initial timer value
>
>  ArmPlatformPkg/PrePi/PeiMPCore.inf  |  3 ++-
>  ArmPlatformPkg/PrePi/PeiUniCore.inf |  3 ++-
>  ArmPlatformPkg/PrePi/PrePi.c        | 10 +++++++++-
>  3 files changed, 13 insertions(+), 3 deletions(-)
>
> See https://github.com/EvanLloyd/tianocore/tree/164_FPDT_v1
>
> Alexei Fedorov (1):
>   ARM/JunoPkg: Add support for FPDT table.
>
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++++-
>  Platform/ARM/JunoPkg/ArmJuno.dsc             | 9 +++++++++
>  Platform/ARM/JunoPkg/ArmJuno.fdf             | 6 ++++++
>  3 files changed, 23 insertions(+), 1 deletion(-)
>
> See https://github.com/EvanLloyd/edk2-platforms/tree/164_FPDT_v1
>
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

Posted by Leif Lindholm 6 years, 6 months ago

On Fri, Sep 22, 2017 at 05:18:05PM +0100, evan.lloyd@arm.com wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
> Paired patches for edk2 and edk2-platforms that add an FPDT
> acpi table.
> This is useful for monitoring firmware performance, etc.

With Graeme's Reviewed-by, I'm happy with thise series.
However, can you confirm your intent was to submit this series
under Tianocore Contribution Agreement 1.1?

I can fold that in when pushing.

Regards,

Leif

> Alexei Fedorov (1):
>   ArmPlatformPkg: Store initial timer value
> 
>  ArmPlatformPkg/PrePi/PeiMPCore.inf  |  3 ++-
>  ArmPlatformPkg/PrePi/PeiUniCore.inf |  3 ++-
>  ArmPlatformPkg/PrePi/PrePi.c        | 10 +++++++++-
>  3 files changed, 13 insertions(+), 3 deletions(-)
> 
> See https://github.com/EvanLloyd/tianocore/tree/164_FPDT_v1
> 
> Alexei Fedorov (1):
>   ARM/JunoPkg: Add support for FPDT table.
> 
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++++-
>  Platform/ARM/JunoPkg/ArmJuno.dsc             | 9 +++++++++
>  Platform/ARM/JunoPkg/ArmJuno.fdf             | 6 ++++++
>  3 files changed, 23 insertions(+), 1 deletion(-)
> 
> See https://github.com/EvanLloyd/edk2-platforms/tree/164_FPDT_v1
> 
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

Posted by Evan Lloyd 6 years, 6 months ago

Hi Leif.
Firstly - sorry I thought we had this sorted.

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: 09 October 2017 12:22
> To: Evan Lloyd <Evan.Lloyd@arm.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [PATCH 0/2] Add FPDT Acpi table
>
> On Fri, Sep 22, 2017 at 05:18:05PM +0100, evan.lloyd@arm.com wrote:
> > From: EvanLloyd <evan.lloyd@arm.com>
> > Paired patches for edk2 and edk2-platforms that add an FPDT acpi
> > table.
> > This is useful for monitoring firmware performance, etc.
>
> With Graeme's Reviewed-by, I'm happy with thise series.
> However, can you confirm your intent was to submit this series under
> Tianocore Contribution Agreement 1.1?

[[Evan Lloyd]] Secondly - yes I did intend to submit under Tianocore Contribution Agreement 1.1.  Frankly, I'm a bit baffled by how this 1.0 got through.

Regards,
Evan
>
> I can fold that in when pushing.
>
> Regards,
>
> Leif
>
> > Alexei Fedorov (1):
> >   ArmPlatformPkg: Store initial timer value
> >
> >  ArmPlatformPkg/PrePi/PeiMPCore.inf  |  3 ++-
> > ArmPlatformPkg/PrePi/PeiUniCore.inf |  3 ++-
> >  ArmPlatformPkg/PrePi/PrePi.c        | 10 +++++++++-
> >  3 files changed, 13 insertions(+), 3 deletions(-)
> >
> > See https://github.com/EvanLloyd/tianocore/tree/164_FPDT_v1
> >
> > Alexei Fedorov (1):
> >   ARM/JunoPkg: Add support for FPDT table.
> >
> >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++++-
> >  Platform/ARM/JunoPkg/ArmJuno.dsc             | 9 +++++++++
> >  Platform/ARM/JunoPkg/ArmJuno.fdf             | 6 ++++++
> >  3 files changed, 23 insertions(+), 1 deletion(-)
> >
> > See https://github.com/EvanLloyd/edk2-platforms/tree/164_FPDT_v1
> >
> > --
> > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

Posted by Leif Lindholm 6 years, 6 months ago

Thanks.

Pushed as a63be426f8 (edk2) and 5d6506e4e9 (edk2-platforms).

(I also deleted a stray "Change-id" tag from each commit message.)

Regards,

Leif

On Tue, Oct 10, 2017 at 04:11:15PM +0000, Evan Lloyd wrote:
> Hi Leif.
> Firstly - sorry I thought we had this sorted.
> 
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: 09 October 2017 12:22
> > To: Evan Lloyd <Evan.Lloyd@arm.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: Re: [PATCH 0/2] Add FPDT Acpi table
> >
> > On Fri, Sep 22, 2017 at 05:18:05PM +0100, evan.lloyd@arm.com wrote:
> > > From: EvanLloyd <evan.lloyd@arm.com>
> > > Paired patches for edk2 and edk2-platforms that add an FPDT acpi
> > > table.
> > > This is useful for monitoring firmware performance, etc.
> >
> > With Graeme's Reviewed-by, I'm happy with thise series.
> > However, can you confirm your intent was to submit this series under
> > Tianocore Contribution Agreement 1.1?
> 
> [[Evan Lloyd]] Secondly - yes I did intend to submit under Tianocore Contribution Agreement 1.1.  Frankly, I'm a bit baffled by how this 1.0 got through.
> 
> Regards,
> Evan
> >
> > I can fold that in when pushing.
> >
> > Regards,
> >
> > Leif
> >
> > > Alexei Fedorov (1):
> > >   ArmPlatformPkg: Store initial timer value
> > >
> > >  ArmPlatformPkg/PrePi/PeiMPCore.inf  |  3 ++-
> > > ArmPlatformPkg/PrePi/PeiUniCore.inf |  3 ++-
> > >  ArmPlatformPkg/PrePi/PrePi.c        | 10 +++++++++-
> > >  3 files changed, 13 insertions(+), 3 deletions(-)
> > >
> > > See https://github.com/EvanLloyd/tianocore/tree/164_FPDT_v1
> > >
> > > Alexei Fedorov (1):
> > >   ARM/JunoPkg: Add support for FPDT table.
> > >
> > >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++++-
> > >  Platform/ARM/JunoPkg/ArmJuno.dsc             | 9 +++++++++
> > >  Platform/ARM/JunoPkg/ArmJuno.fdf             | 6 ++++++
> > >  3 files changed, 23 insertions(+), 1 deletion(-)
> > >
> > > See https://github.com/EvanLloyd/edk2-platforms/tree/164_FPDT_v1
> > >
> > > --
> > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> > >
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel