MdePkg/PciSegmentLibSegmentInfo: fix typo in PciSegmentBitFieldAnd*()

[edk2] [PATCH] MdePkg/PciSegmentLibSegmentInfo: fix typo in PciSegmentBitFieldAnd*()

Posted by Ruiyu Ni 6 years, 7 months ago

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
index 7b7324d673..e0bdb16911 100644
--- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
+++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
@@ -381,7 +381,7 @@ PciSegmentBitFieldAnd8 (
   PCI_SEGMENT_INFO             *SegmentInfo;
 
   SegmentInfo = GetPciSegmentInfo (&Count);
-  return MmioBitFieldOr8 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
+  return MmioBitFieldAnd8 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
 }
 
 /**
@@ -752,7 +752,7 @@ PciSegmentBitFieldAnd16 (
   PCI_SEGMENT_INFO             *SegmentInfo;
 
   SegmentInfo = GetPciSegmentInfo (&Count);
-  return MmioBitFieldOr16 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
+  return MmioBitFieldAnd16 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
 }
 
 /**
@@ -1119,7 +1119,7 @@ PciSegmentBitFieldAnd32 (
   PCI_SEGMENT_INFO             *SegmentInfo;
 
   SegmentInfo = GetPciSegmentInfo (&Count);
-  return MmioBitFieldOr32 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
+  return MmioBitFieldAnd32 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
 }
 
 /**
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg/PciSegmentLibSegmentInfo: fix typo in PciSegmentBitFieldAnd*()

Posted by Ard Biesheuvel 6 years, 7 months ago

On 5 September 2017 at 15:50, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> index 7b7324d673..e0bdb16911 100644
> --- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> +++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> @@ -381,7 +381,7 @@ PciSegmentBitFieldAnd8 (
>    PCI_SEGMENT_INFO             *SegmentInfo;
>
>    SegmentInfo = GetPciSegmentInfo (&Count);
> -  return MmioBitFieldOr8 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> +  return MmioBitFieldAnd8 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
>  }
>
>  /**
> @@ -752,7 +752,7 @@ PciSegmentBitFieldAnd16 (
>    PCI_SEGMENT_INFO             *SegmentInfo;
>
>    SegmentInfo = GetPciSegmentInfo (&Count);
> -  return MmioBitFieldOr16 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> +  return MmioBitFieldAnd16 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
>  }
>
>  /**
> @@ -1119,7 +1119,7 @@ PciSegmentBitFieldAnd32 (
>    PCI_SEGMENT_INFO             *SegmentInfo;
>
>    SegmentInfo = GetPciSegmentInfo (&Count);
> -  return MmioBitFieldOr32 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> +  return MmioBitFieldAnd32 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
>  }
>
>  /**
> --
> 2.12.2.windows.2
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel