From nobody Fri May 3 19:16:43 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 15031788876561014.602937136976; Sat, 19 Aug 2017 14:41:27 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id EC07821E14534; Sat, 19 Aug 2017 14:38:53 -0700 (PDT) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D524221DF9692 for ; Sat, 19 Aug 2017 14:38:51 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DD74320CC9; Sat, 19 Aug 2017 17:41:20 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sat, 19 Aug 2017 17:41:20 -0400 Received: from localhost.localdomain (c-71-226-23-158.hsd1.fl.comcast.net [71.226.23.158]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D61924772; Sat, 19 Aug 2017 17:41:20 -0400 (EDT) X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=miv+aIEn9+4iuCG+xYeufra+GIqE3cpG4w1zmqZeU Xk=; b=FBzwjiI/062eotU/i1SrEs6bdPo2pVqN5k8fyI36K4Hav+BJHFfRFnQbT DHq0obnnQst+LP48Z/THOA3fYvHKTl5iNPI1dyYk9x/8dihlqbYhhIBnUxfLcc1C E4n3ro0CEr7/N3YomGhvBVVuuR0MNzauIeqInQ/ZQMDnvWQMCmjWe808CLDwxL4E hCgdza+eqU1bzciVFMV+KIjnLg8Usf0jNFpbJgGr9ZiXQN8C6v/58RkHusvUuRD8 P7Y6QxH3KYpPtD6ECbe/9Ctt4j5tAX18ASkKa2qEeZfS5XSIG9Nm7JBPkDGcIuyK okuHI/NjDn/gajEepsoX+w1+fV7bg== X-ME-Sender: X-Sasl-enc: tTinl0WFcXNT/Qs1RkQsTDn7Hh33j/7HRDPHcBI3A9gg 1503178880 From: Alan Ott To: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org Date: Sat, 19 Aug 2017 17:41:13 -0400 Message-Id: <20170819214114.8140-2-alan@softiron.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170819214114.8140-1-alan@softiron.com> References: <20170819214114.8140-1-alan@softiron.com> Subject: [edk2] [PATCH edk2-platforms 1/2] Silicon/AMD/Styx: Make PcdSataPortMode 32 bits X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Ott , edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Extra bits are needed to accomodate all 14 SATA ports Signed-off-by: Alan Ott Contributed-under: TianoCore Contribution Agreement 1.0 --- Silicon/AMD/Styx/AmdStyx.dec | 2 +- Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Silicon/AMD/Styx/AmdStyx.dec b/Silicon/AMD/Styx/AmdStyx.dec index ddd5bf4..c6eebe6 100644 --- a/Silicon/AMD/Styx/AmdStyx.dec +++ b/Silicon/AMD/Styx/AmdStyx.dec @@ -54,7 +54,7 @@ gAmdStyxTokenSpaceGuid.PcdSata0CtrlAxiSlvPort|0xE0300000|UINT32|0x000200= 00 gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8|UINT8|0x00020001 gAmdStyxTokenSpaceGuid.PcdSataPi|0xFF|UINT32|0x00020002 - gAmdStyxTokenSpaceGuid.PcdSataPortMode|0|UINT16|0x00020003 + gAmdStyxTokenSpaceGuid.PcdSataPortMode|0|UINT32|0x00020003 gAmdStyxTokenSpaceGuid.PcdSataPortMpsp|TRUE|BOOLEAN|0x00020004 gAmdStyxTokenSpaceGuid.PcdSataSmpsSupport|FALSE|BOOLEAN|0x00020005 gAmdStyxTokenSpaceGuid.PcdSataSssSupport|TRUE|BOOLEAN|0x00020006 diff --git a/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c = b/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c index 1958d91..78c6819 100644 --- a/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c +++ b/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c @@ -110,8 +110,8 @@ InitializeSataController ( SataChPerSerdes =3D FixedPcdGet8 (PcdSataNumChPerSerdes); =20 for (PortNum =3D 0; PortNum < SataPortCount; PortNum +=3D SataChPerSerde= s) { - EvenPort =3D (UINT32)(FixedPcdGet16 (PcdSataPortMode) >> (PortNum * 2)= ) & 3; - OddPort =3D (UINT32)(FixedPcdGet16 (PcdSataPortMode) >> ((PortNum+1) *= 2)) & 3; + EvenPort =3D (UINT32)(FixedPcdGet32 (PcdSataPortMode) >> (PortNum * 2)= ) & 3; + OddPort =3D (UINT32)(FixedPcdGet32 (PcdSataPortMode) >> ((PortNum+1) *= 2)) & 3; SataPhyInit ((StartPort + PortNum) / SataChPerSerdes, EvenPort, OddPor= t); } =20 --=20 2.9.3 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Fri May 3 19:16:43 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1503178890459947.3647217847323; Sat, 19 Aug 2017 14:41:30 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3051621E1453C; Sat, 19 Aug 2017 14:38:54 -0700 (PDT) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10A7A21DFC895 for ; Sat, 19 Aug 2017 14:38:52 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6687D20F38; Sat, 19 Aug 2017 17:41:21 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sat, 19 Aug 2017 17:41:21 -0400 Received: from localhost.localdomain (c-71-226-23-158.hsd1.fl.comcast.net [71.226.23.158]) by mail.messagingengine.com (Postfix) with ESMTPA id D295B2492F; Sat, 19 Aug 2017 17:41:20 -0400 (EDT) X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=JmREatgrIPE424LRDIWF78ZQpQs7Y1wBSC6yzzKIF fU=; b=Z5fMsUnie+uDJlqihLgzCYxIP7Ts6TiijLcVdJMTUiqUQx972N7qVZHuU GpxLnBFIIf9WunFJoaaY07m4DHhxoIMjHc0HLbs4D6sS6GDGsfSl5c7v3xyhJrgo 3VFnH4RoFIqEt52gwyVMHH2WAKZG/+O0LCVXFI7cihlSD/nP30dV+KLIcNchFxMD GlzhTC8IA5oEUQ5XFzeLFMZOpVSEBy0cUxwKwai3oh1TY0zwRrjP2esJTtQeXoXY bbS/Sa92EY9Ta9aeV+G55wn7DUBvH9QvFavjqW2arWT2pMTeWQ+6v5NCWUScDLay LQsNThjiLLLsWbDwI1df6ulKJx2ew== X-ME-Sender: X-Sasl-enc: FziO396kapbGaYMeYvhU44jMyeR0hk/IfzAXJwYH4Db5 1503178881 From: Alan Ott To: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org Date: Sat, 19 Aug 2017 17:41:14 -0400 Message-Id: <20170819214114.8140-3-alan@softiron.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170819214114.8140-1-alan@softiron.com> References: <20170819214114.8140-1-alan@softiron.com> Subject: [edk2] [PATCH edk2-platforms 2/2] Platform/AMD/OverdriveBoard: Re-enable the second SATA Controller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Ott , edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The comment indicating that only the first SATA controller is operational on SoftIron-branded OverDrive 3000 boards is incorrect. Re-enable the second SATA controller. Signed-off-by: Alan Ott Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Ard Biesheuvel --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/= OverdriveBoard/OverdriveBoard.dsc index f256ffb..2881de3 100644 --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc @@ -409,14 +409,10 @@ DEFINE DO_FLASHER =3D FALSE gArmTokenSpaceGuid.PcdGicDistributorBase|0xE1110000 gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xE112F000 =20 - # - # AMD's B1 based Overdrive has 14 SATA ports across 2 controllers. Howev= er, - # it appears that Softiron's Overdrive 3000, which is also B1 based, does - # not have the second SATA controller enabled, and any attempts to use it - # will crash the firmware. So use the first controller only. - # + # SATA Ports gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8 - gAmdStyxTokenSpaceGuid.PcdSataPortMode|0xffff + gAmdStyxTokenSpaceGuid.PcdSata1PortCount|6 + gAmdStyxTokenSpaceGuid.PcdSataPortMode|0x0fffffff =20 # PCIe Support gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xF0000000 --=20 2.9.3 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel