ShellPkg/ShellLib: Remove unused macros

[edk2] [PATCH] ShellPkg/ShellLib: Remove unused macros

Posted by Ruiyu Ni 6 years, 8 months ago

MAX_FILE_NAME_LEN and FIND_XXXXX_FILE_BUFFER_SIZE are not used
by ShellLib so remove them.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 ShellPkg/Include/Library/ShellLib.h          | 5 +----
 ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 --
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/ShellPkg/Include/Library/ShellLib.h b/ShellPkg/Include/Library/ShellLib.h
index 9b611d8016..268a767b70 100644
--- a/ShellPkg/Include/Library/ShellLib.h
+++ b/ShellPkg/Include/Library/ShellLib.h
@@ -1,7 +1,7 @@
 /** @file
   Provides interface to shell functionality for shell commands and applications.
 
-  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -32,9 +32,6 @@
     }                                 \
   } while(FALSE)
 
-// (20 * (6+5+2))+1) unicode characters from EFI FAT spec (doubled for bytes)
-#define MAX_FILE_NAME_LEN 512
-
 extern EFI_SHELL_PARAMETERS_PROTOCOL *gEfiShellParametersProtocol;
 extern EFI_SHELL_PROTOCOL            *gEfiShellProtocol;
 
diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
index c3a67c3be7..64565f81d8 100644
--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
@@ -18,8 +18,6 @@
 #include <Library/SortLib.h>
 #include <Library/BaseLib.h>
 
-#define FIND_XXXXX_FILE_BUFFER_SIZE (SIZE_OF_EFI_FILE_INFO + MAX_FILE_NAME_LEN)
-
 //
 // globals...
 //
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/ShellLib: Remove unused macros

Posted by Gao, Liming 6 years, 8 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ni, Ruiyu
>Sent: Wednesday, July 26, 2017 5:34 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [PATCH] ShellPkg/ShellLib: Remove unused macros
>
>MAX_FILE_NAME_LEN and FIND_XXXXX_FILE_BUFFER_SIZE are not used
>by ShellLib so remove them.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> ShellPkg/Include/Library/ShellLib.h          | 5 +----
> ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 --
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/ShellPkg/Include/Library/ShellLib.h
>b/ShellPkg/Include/Library/ShellLib.h
>index 9b611d8016..268a767b70 100644
>--- a/ShellPkg/Include/Library/ShellLib.h
>+++ b/ShellPkg/Include/Library/ShellLib.h
>@@ -1,7 +1,7 @@
> /** @file
>   Provides interface to shell functionality for shell commands and applications.
>
>-  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
>+  Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>   This program and the accompanying materials
>   are licensed and made available under the terms and conditions of the BSD
>License
>   which accompanies this distribution.  The full text of the license may be
>found at
>@@ -32,9 +32,6 @@
>     }                                 \
>   } while(FALSE)
>
>-// (20 * (6+5+2))+1) unicode characters from EFI FAT spec (doubled for bytes)
>-#define MAX_FILE_NAME_LEN 512
>-
> extern EFI_SHELL_PARAMETERS_PROTOCOL *gEfiShellParametersProtocol;
> extern EFI_SHELL_PROTOCOL            *gEfiShellProtocol;
>
>diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>index c3a67c3be7..64565f81d8 100644
>--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>@@ -18,8 +18,6 @@
> #include <Library/SortLib.h>
> #include <Library/BaseLib.h>
>
>-#define FIND_XXXXX_FILE_BUFFER_SIZE (SIZE_OF_EFI_FILE_INFO +
>MAX_FILE_NAME_LEN)
>-
> //
> // globals...
> //
>--
>2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel