From nobody Fri May 3 09:07:52 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1494310387841748.3994342254905; Mon, 8 May 2017 23:13:07 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C9B1321A0BABE; Mon, 8 May 2017 23:13:05 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9CA2621A0BABD for ; Mon, 8 May 2017 23:13:04 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2017 23:13:04 -0700 Received: from zwei4-mobl.ccr.corp.intel.com ([10.239.198.95]) by FMSMGA003.fm.intel.com with ESMTP; 08 May 2017 23:13:03 -0700 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,312,1491289200"; d="scan'208";a="854571860" From: zwei4 To: edk2-devel@lists.01.org Date: Tue, 9 May 2017 14:12:45 +0800 Message-Id: <20170509061245.19580-1-david.wei@intel.com> X-Mailer: git-send-email 2.11.0.windows.1 Subject: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Clean up ACPI code. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- .../Common/Acpi/AcpiTablesPCAT/ScScc.asl | 27 ++++--------------= ---- .../Common/Acpi/AcpiTablesPCAT/token.asl | 3 +-- 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.a= sl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl index 9432a2562..a7290f76a 100644 --- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl +++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl @@ -1,5 +1,5 @@ /** @file - Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.
+ Copyright (c) 2012 - 2017, Intel Corporation. All rights reserved.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License @@ -532,12 +532,8 @@ scope (\_SB.PCI0) { // // GPIO 183: Set GPIOTXState =3D 0 // + Store (0, \_SB.PCI0.SDC.GPOV) =20 - If (LEqual(BDID,GRBM)) { - Store (1, \_SB.PCI0.SDC.GPOV) - } Else { - Store (0, \_SB.PCI0.SDC.GPOV) - } =20 // // Save GPIO_177 DW0 and DW1 @@ -557,12 +553,8 @@ scope (\_SB.PCI0) { // // GPIO 183: Set GPIOTXState =3D 1 // + Store (1, \_SB.PCI0.SDC.GPOV) =20 - If (LEqual(BDID,GRBM)) { - Store (0, \_SB.PCI0.SDC.GPOV) - } Else { - Store (1, \_SB.PCI0.SDC.GPOV) - } =20 // // Clear Normal Interrupt Status Enable Bit 6 & 7 @@ -667,13 +659,8 @@ scope (\_SB.PCI0) { // Set gpiotxstate =3D1 // =20 - // GPIO 183: Set GPIOTXState =3D 1 - - If (LEqual(BDID,GRBM)) { - Store (0, \_SB.PCI0.SDC.GPOV) - } Else { Store (1, \_SB.PCI0.SDC.GPOV) - } + // Sleep for 50ms Between Powering Off / Powering On Sleep (50) =20 @@ -681,13 +668,7 @@ scope (\_SB.PCI0) { // GPIO 183: // Set gpiotxstate =3D 0 =20 - // GPIO 183: Set GPIOTXState =3D 0 - - If (LEqual(BDID,GRBM)) { - Store (1, \_SB.PCI0.SDC.GPOV) - } Else { Store (0, \_SB.PCI0.SDC.GPOV) - } =20 Return (Buffer(){0x00}) } diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.a= sl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl index 3716dc28d..bdc98ea59 100644 --- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl +++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl @@ -1,5 +1,5 @@ /** @file - Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.
+ Copyright (c) 2012 - 2017, Intel Corporation. All rights reserved.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License @@ -50,6 +50,5 @@ Name(PEER, 0x1) // _OSC: Pci Express Advanced Err= or Reporting control Name(PECS, 0x1) // _OSC: Pci Express Capability Structure control Name(ITKE, 0x0) // This will be overridden by the ITK module. Name(FTBL, 0x4) // Platform Flavor - Tablet flavor for ASL code. -Name(GRBM, 0xF) // Board id for Gordon Ridge BMP MRB Name(MNHL, 0x5) // Board id for Mineral Hill =20 --=20 2.11.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel