Thank you!
From: Fan, Jeff
Sent: Friday, April 7, 2017 8:46 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Tian, Feng <feng.tian@intel.com>
Subject: RE: [PATCH 0/9] Export Dump CPU Context service
Jiewen,
That's fine. If you consider the patch based on module for this case is better your review, I will combine some of them soon.
Thanks!
Jeff
From: Yao, Jiewen
Sent: Friday, April 07, 2017 8:41 AM
To: Fan, Jeff; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Kinney, Michael D; Tian, Feng
Subject: RE: [PATCH 0/9] Export Dump CPU Context service
Hi
I do not think it is necessary to split this simple patch to so many.
It brings burden to me to review the change. For example, there are 4 patches for CpuExceptionHandlerLib.
Can we combine the patch based upon the module?
Thank you
Yao Jiewen
> -----Original Message-----
> From: Fan, Jeff
> Sent: Saturday, April 1, 2017 9:25 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Kinney, Michael D
> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Tian, Feng <feng.tian@intel.com<mailto:feng.tian@intel.com>>
> Subject: [PATCH 0/9] Export Dump CPU Context service
>
> This serial of patches are:
> 1. Export PeCoffSerachImageBase() that could serach PE/COFF image base.
> 2. Export DumpCpuContext that could dump CPU context when exception
> happened.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=242
>
> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Cc: Michael Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> Cc: Feng Tian <feng.tian@intel.com<mailto:feng.tian@intel.com>>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com<mailto:jeff.fan@intel.com>>
>
> Jeff Fan (9):
> MdePkg/PeCoffGetEntryPointLib: Add PeCoffSerachImageBase()
> MdeModulePkg/CpuExceptionHandlerLib: Add DumpCpuContext()
> UefiCpuPkg/CpuExceptionHandlerLib: Rename internal DumpCpuContent()
> UefiCpuPkg/CpuExceptionHandlerLib: Add DumpModuleImageInfo()
> UefiCpuPkg/CpuExceptionHandlerLib: Add DumpCpuContext()
> implementation
> UefiCpuPkg/CpuExceptionHandlerLib: Display PF Excption Data bit
> UefiCpuPkg/PiSmmCpuDxeSmm: Consume PeCoffSerachImageBase()
> UefiCpuPkg/PiSmmCpuDxeSmm: Consume DumpCpuContext()
> SourceLevelDebugPkg/DebugAgent.c: Consume PeCoffSerachImageBase()
>
> .../Include/Library/CpuExceptionHandlerLib.h | 15 ++++-
> .../CpuExceptionHandlerLibNull.c | 16 ++++-
> MdePkg/Include/Library/PeCoffGetEntryPointLib.h | 20 +++++-
> .../PeCoffGetEntryPoint.c | 72
> ++++++++++++++++++++-
> .../DebugAgent/DebugAgentCommon/DebugAgent.c | 50 ++-------------
> .../CpuExceptionHandlerLib/CpuExceptionCommon.c | 75
> ++++++----------------
> .../CpuExceptionHandlerLib/CpuExceptionCommon.h | 27 +++++---
> .../Library/CpuExceptionHandlerLib/DxeException.c | 7 +-
> .../Ia32/ArchExceptionHandler.c | 65
> ++++++++++++-------
> .../CpuExceptionHandlerLib/PeiCpuException.c | 6 +-
> .../CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 +-
> .../CpuExceptionHandlerLib/SecPeiCpuException.c | 8 +--
> .../Library/CpuExceptionHandlerLib/SmmException.c | 7 +-
> .../X64/ArchExceptionHandler.c | 57 ++++++++++------
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 18 ++----
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 37 +----------
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 6 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 18 ++----
> 19 files changed, 265 insertions(+), 247 deletions(-)
>
> --
> 2.9.3.windows.2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel