From nobody Thu May 2 19:14:30 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1490583734966535.3860043927272; Sun, 26 Mar 2017 20:02:14 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7699D20D2C3B9; Sun, 26 Mar 2017 20:02:13 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C15C921BC6ADB for ; Sun, 26 Mar 2017 20:02:09 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 20:02:09 -0700 Received: from jfan12-desk.ccr.corp.intel.com ([10.239.158.57]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2017 20:02:08 -0700 X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490583729; x=1522119729; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=ZS2I0U3bD0bYqXxrcZvz7bz+/obEfhyAPnJ0wzcL9+Q=; b=lTpKMzJMmiKjVd1Aq1vL7YMDUvppHwiVzdRtWZja6+Mayxgv9TIEHhLc al7QxMmBHgZ70ZRhXtYO3o5dj3J7jQ==; X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="1127411317" From: Jeff Fan To: edk2-devel@lists.01.org Date: Mon, 27 Mar 2017 11:02:00 +0800 Message-Id: <20170327030204.13572-2-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20170327030204.13572-1-jeff.fan@intel.com> References: <20170327030204.13572-1-jeff.fan@intel.com> Subject: [edk2] [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Feng Tian MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- .../Include/Library/RegisterCpuFeaturesLib.h | 60 +++++++++++-------= --- .../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +- .../DxeRegisterCpuFeaturesLib.c | 2 +- .../PeiRegisterCpuFeaturesLib.c | 2 +- .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +- .../RegisterCpuFeaturesLib.c | 62 +++++++++++-------= ---- 6 files changed, 67 insertions(+), 63 deletions(-) diff --git a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h b/UefiCpuP= kg/Include/Library/RegisterCpuFeaturesLib.h index 3fb8209..81a1f4b 100644 --- a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h +++ b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h @@ -257,35 +257,37 @@ RETURN_STATUS /** Registers a CPU Feature. =20 - @param GetConfigDataFunc CPU feature get configuration data function. = This - is an optional parameter that may be NULL. I= f NULL, - then the most recently registered function fo= r the - CPU feature is used. If no functions are reg= istered - for a CPU feature, then the CPU configuration= data - for the registered feature is NULL. - @param SupportFunc CPU feature support function. This is an opt= ional - parameter that may be NULL. If NULL, then th= e most - recently registered function for the CPU feat= ure is - used. If no functions are registered for a CPU - feature, then the CPU feature is assumed to be - supported by all CPUs. - @param InitializeFunc CPU feature initialize function. This is an = optional - parameter that may be NULL. If NULL, then th= e most - recently registered function for the CPU feat= ure is - used. If no functions are registered for a CPU - feature, then the CPU feature initialization = is - skipped. - @param ... Variable argument list of UINT32 CPU feature = value. - Values with no modifiers are the features pro= vided - by the registered functions. - Values with CPU_FEATURE_BEFORE modifier are f= eatures - that must be initialized after the features p= rovided - by the registered functions are used. - Values with CPU_FEATURE_AFTER modifier are fe= atures - that must be initialized before the features = provided - by the registered functions are used. - The last argument in this variable argument l= ist must - always be CPU_FEATURE_END. + @param[in] FeatureName A Null-terminated Ascii string indicates = CPU feature + name. + @param[in] GetConfigDataFunc CPU feature get configuration data functi= on. This + is an optional parameter that may be NULL= . If NULL, + then the most recently registered functio= n for the + CPU feature is used. If no functions are= registered + for a CPU feature, then the CPU configura= tion data + for the registered feature is NULL. + @param[in] SupportFunc CPU feature support function. This is an= optional + parameter that may be NULL. If NULL, the= n the most + recently registered function for the CPU = feature is + used. If no functions are registered for = a CPU + feature, then the CPU feature is assumed = to be + supported by all CPUs. + @param[in] InitializeFunc CPU feature initialize function. This is= an optional + parameter that may be NULL. If NULL, the= n the most + recently registered function for the CPU = feature is + used. If no functions are registered for = a CPU + feature, then the CPU feature initializat= ion is + skipped. + @param[in] ... Variable argument list of UINT32 CPU feat= ure value. + Values with no modifiers are the features= provided + by the registered functions. + Values with CPU_FEATURE_BEFORE modifier a= re features + that must be initialized after the featur= es provided + by the registered functions are used. + Values with CPU_FEATURE_AFTER modifier ar= e features + that must be initialized before the featu= res provided + by the registered functions are used. + The last argument in this variable argume= nt list must + always be CPU_FEATURE_END. =20 @retval RETURN_SUCCESS The CPU feature was successfully regis= tered. @retval RETURN_OUT_OF_RESOURCES There are not enough resources to regi= ster diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitializ= e.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index cd689af..e0fe38c 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -18,7 +18,7 @@ Worker function to save PcdCpuFeaturesCapability. =20 @param[in] SupportedFeatureMask The pointer to CPU feature bits mask b= uffer -*/ +**/ VOID SetCapabilityPcd ( IN UINT8 *SupportedFeatureMask diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeatur= esLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesL= ib.c index b5a1de7..c49f556 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c @@ -168,7 +168,7 @@ SwitchNewBsp ( /** Worker function to retrieve the number of logical processor in the platf= orm. =20 - @param[out] NumberOfProcessors Pointer to the total number of l= ogical + @param[out] NumberOfCpus Pointer to the total number of l= ogical processors in the system, includ= ing the BSP and disabled APs. @param[out] NumberOfEnabledProcessors Pointer to the number of enabled= logical diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeatur= esLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesL= ib.c index 12a516a..8fde742 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c @@ -219,7 +219,7 @@ SwitchNewBsp ( /** Worker function to retrieve the number of logical processor in the platf= orm. =20 - @param[out] NumberOfProcessors Pointer to the total number of l= ogical + @param[out] NumberOfCpus Pointer to the total number of l= ogical processors in the system, includ= ing the BSP and disabled APs. @param[out] NumberOfEnabledProcessors Pointer to the number of enabled= logical diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.= h b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h index 2b136b6..11f8eb7 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h @@ -147,7 +147,7 @@ StartupAPsWorker ( /** Worker function to retrieve the number of logical processor in the platf= orm. =20 - @param[out] NumberOfProcessors Pointer to the total number of l= ogical + @param[out] NumberOfCpus Pointer to the total number of l= ogical processors in the system, includ= ing the BSP and disabled APs. @param[out] NumberOfEnabledProcessors Pointer to the number of enabled= logical diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesL= ib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c index 3fec2e6..7ef0155 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c @@ -240,7 +240,7 @@ CheckCpuFeaturesDependency ( /** Worker function to register CPU Feature. =20 - @param[in] CpuFeature Pointer to CPU feature entry + @param[in] CpuFeature Pointer to CPU feature entry =20 @retval RETURN_SUCCESS The CPU feature was successfully regis= tered. @retval RETURN_OUT_OF_RESOURCES There are not enough resources to regi= ster @@ -372,35 +372,37 @@ SetCpuFeaturesBitMask ( /** Registers a CPU Feature. =20 - @param GetConfigDataFunc CPU feature get configuration data function. = This - is an optional parameter that may be NULL. I= f NULL, - then the most recently registered function fo= r the - CPU feature is used. If no functions are reg= istered - for a CPU feature, then the CPU configuration= data - for the registered feature is NULL. - @param SupportFunc CPU feature support function. This is an opt= ional - parameter that may be NULL. If NULL, then th= e most - recently registered function for the CPU feat= ure is - used. If no functions are registered for a CPU - feature, then the CPU feature is assumed to be - supported by all CPUs. - @param InitializeFunc CPU feature initialize function. This is an = optional - parameter that may be NULL. If NULL, then th= e most - recently registered function for the CPU feat= ure is - used. If no functions are registered for a CPU - feature, then the CPU feature initialization = is - skipped. - @param ... Variable argument list of UINT32 CPU feature = value. - Values with no modifiers are the features pro= vided - by the registered functions. - Values with CPU_FEATURE_BEFORE modifier are f= eatures - that must be initialized after the features p= rovided - by the registered functions are used. - Values with CPU_FEATURE_AFTER modifier are fe= atures - that must be initialized before the features = provided - by the registered functions are used. - The last argument in this variable argument l= ist must - always be CPU_FEATURE_END. + @param[in] FeatureName A Null-terminated Ascii string indicates = CPU feature + name. + @param[in] GetConfigDataFunc CPU feature get configuration data functi= on. This + is an optional parameter that may be NULL= . If NULL, + then the most recently registered functio= n for the + CPU feature is used. If no functions are= registered + for a CPU feature, then the CPU configura= tion data + for the registered feature is NULL. + @param[in] SupportFunc CPU feature support function. This is an= optional + parameter that may be NULL. If NULL, the= n the most + recently registered function for the CPU = feature is + used. If no functions are registered for = a CPU + feature, then the CPU feature is assumed = to be + supported by all CPUs. + @param[in] InitializeFunc CPU feature initialize function. This is= an optional + parameter that may be NULL. If NULL, the= n the most + recently registered function for the CPU = feature is + used. If no functions are registered for = a CPU + feature, then the CPU feature initializat= ion is + skipped. + @param[in] ... Variable argument list of UINT32 CPU feat= ure value. + Values with no modifiers are the features= provided + by the registered functions. + Values with CPU_FEATURE_BEFORE modifier a= re features + that must be initialized after the featur= es provided + by the registered functions are used. + Values with CPU_FEATURE_AFTER modifier ar= e features + that must be initialized before the featu= res provided + by the registered functions are used. + The last argument in this variable argume= nt list must + always be CPU_FEATURE_END. =20 @retval RETURN_SUCCESS The CPU feature was successfully regis= tered. @retval RETURN_OUT_OF_RESOURCES There are not enough resources to regi= ster --=20 2.9.3.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Thu May 2 19:14:30 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1490583736741475.87140496357904; Sun, 26 Mar 2017 20:02:16 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A7390203BEBE8; Sun, 26 Mar 2017 20:02:13 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 20B6920D2C3B9 for ; Sun, 26 Mar 2017 20:02:12 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 20:02:10 -0700 Received: from jfan12-desk.ccr.corp.intel.com ([10.239.158.57]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2017 20:02:09 -0700 X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490583732; x=1522119732; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=HRVY+DMfFmNSc3lr+PTS2oXnxuMQ1d92sOZbuapu/60=; b=B66+d0MJ+Pn+6xcTiE2pazW+VW2YkqwdPQPgkC6/xqxo7zR+Dr+EXgVH SyHBBoyJocBPnqxDeMRVPqidziddPQ==; X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="1127411325" From: Jeff Fan To: edk2-devel@lists.01.org Date: Mon, 27 Mar 2017 11:02:01 +0800 Message-Id: <20170327030204.13572-3-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20170327030204.13572-1-jeff.fan@intel.com> References: <20170327030204.13572-1-jeff.fan@intel.com> Subject: [edk2] [PATCH 2/5] UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Feng Tian MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Using one specific name for global variable to save MP services protocol pointer. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- .../Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 10 +++++-= ---- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeatur= esLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesL= ib.c index c49f556..74c658a 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c @@ -19,7 +19,7 @@ #include "RegisterCpuFeatures.h" =20 CPU_FEATURES_DATA mCpuFeaturesData =3D {0}; -static EFI_MP_SERVICES_PROTOCOL *mMpServices =3D NULL; +EFI_MP_SERVICES_PROTOCOL *mCpuFeaturesMpServices =3D NULL; =20 /** Worker function to get CPU_FEATURES_DATA pointer. @@ -46,20 +46,20 @@ GetMpProtocol ( { EFI_STATUS Status; =20 - if (mMpServices =3D=3D NULL) { + if (mCpuFeaturesMpServices =3D=3D NULL) { // // Get MP Services Protocol // Status =3D gBS->LocateProtocol ( &gEfiMpServiceProtocolGuid, NULL, - (VOID **)&mMpServices + (VOID **)&mCpuFeaturesMpServices ); ASSERT_EFI_ERROR (Status); } =20 - ASSERT (mMpServices !=3D NULL); - return mMpServices; + ASSERT (mCpuFeaturesMpServices !=3D NULL); + return mCpuFeaturesMpServices; } =20 /** --=20 2.9.3.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Thu May 2 19:14:30 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1490583739242383.5014046711749; Sun, 26 Mar 2017 20:02:19 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DFC3C203BEBED; Sun, 26 Mar 2017 20:02:13 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4644520D2C3BA for ; Sun, 26 Mar 2017 20:02:12 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 20:02:11 -0700 Received: from jfan12-desk.ccr.corp.intel.com ([10.239.158.57]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2017 20:02:10 -0700 X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490583732; x=1522119732; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=IXWHClPZuEGilZiPZkWCNNvIDVHFAWU2V8AMkOdP5Pk=; b=p1pYdu+Wh9HMhTohATcRC1QSvvnhSxEMETqUpwVoEAxgC0QEwYKmGxy2 yMmGm8Cmy2YKD9zUUvez4rBNn8xZOA==; X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="1127411335" From: Jeff Fan To: edk2-devel@lists.01.org Date: Mon, 27 Mar 2017 11:02:02 +0800 Message-Id: <20170327030204.13572-4-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20170327030204.13572-1-jeff.fan@intel.com> References: <20170327030204.13572-1-jeff.fan@intel.com> Subject: [edk2] [PATCH 3/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Feng Tian MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf | 4 ++-- UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf | 2 +- UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf b/UefiCpuPkg/CpuFeat= ures/CpuFeaturesDxe.inf index 5a3e4f0..dee44e6 100644 --- a/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf +++ b/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf @@ -38,10 +38,10 @@ CpuFeaturesDxe.c =20 [Guids] - gEdkiiCpuFeaturesInitDoneGuid ## PRODU= CES + gEdkiiCpuFeaturesInitDoneGuid ## PRODUCES ## UNDEF= INED # protocol GUID installed =20 [Protocols] - gEfiSmmConfigurationProtocolGuid ## SOMET= IME_CONSUMES + gEfiSmmConfigurationProtocolGuid ## NOTIFY =20 [Pcd] gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitAfterSmmRelocation ## CONSU= MES diff --git a/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf b/UefiCpuPkg/CpuFeat= ures/CpuFeaturesPei.inf index e306bb2..2fb84b1 100644 --- a/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf +++ b/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf @@ -37,7 +37,7 @@ CpuFeaturesPei.c =20 [Guids] - gEdkiiCpuFeaturesInitDoneGuid ## PRODU= CES + gEdkiiCpuFeaturesInitDoneGuid ## PRODUCES ## UNDEF= INED # PPI GUID installed =20 [Pcd] gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitOnS3Resume ## CONSU= MES diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.i= nf b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf index 7287d4e..056b776 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf @@ -62,7 +62,7 @@ LocalApicLib =20 [Pcd] - gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport # CONSUMES - gUefiCpuPkgTokenSpaceGuid.PcdCpuClockModulationDutyCycle # SOMETIME_CO= NSUMES - gUefiCpuPkgTokenSpaceGuid.PcdIsPowerOnReset # SOMETIME_CO= NSUMES + gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport ## CONSUMES + gUefiCpuPkgTokenSpaceGuid.PcdCpuClockModulationDutyCycle ## SOMETIMES_= CONSUMES + gUefiCpuPkgTokenSpaceGuid.PcdIsPowerOnReset ## SOMETIMES_= CONSUMES =20 --=20 2.9.3.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Thu May 2 19:14:30 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1490583741167361.08724905919473; Sun, 26 Mar 2017 20:02:21 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1F12F203BEBE3; Sun, 26 Mar 2017 20:02:17 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A2D4B2041FBC0 for ; Sun, 26 Mar 2017 20:02:13 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 20:02:13 -0700 Received: from jfan12-desk.ccr.corp.intel.com ([10.239.158.57]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2017 20:02:12 -0700 X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490583733; x=1522119733; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=8iEEOaqecLNhwmVpOPPILCu/R9wmfQX5yC1r3mFWRqE=; b=NwgAx76icwfqX52WYNZjJailTy4Lr/gmmNhLv3MITHu2MmwwBE61LPb7 ZrGZjGZaeCMBn4IByXdzTPXsfWYmeQ==; X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="1127411345" From: Jeff Fan To: edk2-devel@lists.01.org Date: Mon, 27 Mar 2017 11:02:03 +0800 Message-Id: <20170327030204.13572-5-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20170327030204.13572-1-jeff.fan@intel.com> References: <20170327030204.13572-1-jeff.fan@intel.com> Subject: [edk2] [PATCH 4/5] UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Feng Tian MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.i= nf b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf index 056b776..4358196 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf @@ -19,7 +19,7 @@ INF_VERSION =3D 0x00010005 BASE_NAME =3D CpuCommonFeaturesLib MODULE_UNI_FILE =3D CpuCommonFeaturesLib.uni - FILE_GUID =3D 387A2490-81FC-4E7C-8E0A-3E58C30FCD0B + FILE_GUID =3D 6D69F79F-9535-4893-9DD7-93929898252C MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D NULL --=20 2.9.3.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Thu May 2 19:14:30 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1490583743593784.9379978087228; Sun, 26 Mar 2017 20:02:23 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4A01F203BEBF1; Sun, 26 Mar 2017 20:02:17 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D4AB2041FBFD for ; Sun, 26 Mar 2017 20:02:14 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 20:02:14 -0700 Received: from jfan12-desk.ccr.corp.intel.com ([10.239.158.57]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2017 20:02:13 -0700 X-Original-To: edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490583734; x=1522119734; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=Fd6dRoNqQ0LrCB1D/LDVWK0kVGsxcrlgFgw6kYBQVR8=; b=wXD+/FhOBucXtk3wKf/jtTcmCUJAxJU+NuJgUwZ4PiwTgpY1R6glGE2O EAT/bKutJNvaEFjtfjZJrgXjdeA3yQ==; X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="1127411354" From: Jeff Fan To: edk2-devel@lists.01.org Date: Mon, 27 Mar 2017 11:02:04 +0800 Message-Id: <20170327030204.13572-6-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20170327030204.13572-1-jeff.fan@intel.com> References: <20170327030204.13572-1-jeff.fan@intel.com> Subject: [edk2] [PATCH 5/5] UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Feng Tian MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Correct PCD declaration comments and add new PCDs in UNI file. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/UefiCpuPkg.dec | 12 ++++++------ UefiCpuPkg/UefiCpuPkg.uni | 31 +++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index 4a679bd..e87f103 100644 --- a/UefiCpuPkg/UefiCpuPkg.dec +++ b/UefiCpuPkg/UefiCpuPkg.dec @@ -192,16 +192,16 @@ # @Prompt MSEG size. gUefiCpuPkgTokenSpaceGuid.PcdCpuMsegSize|0x200000|UINT32|0x32132112 =20 - ## Specifies the supported CPU features bit in array - # @Prompt Supported CPU features + ## Specifies the supported CPU features bit in array. + # @Prompt Supported CPU features. gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport|{0xFF, 0xFF, 0xFF, 0xFF,= 0xFF, 0xFF, 0xFF, 0xFF}|VOID*|0x00000016 =20 - ## Specifies if CPU features will be initialized after SMM relocation - # @Prompt if CPU features will be initialized after SMM relocation + ## Specifies if CPU features will be initialized after SMM relocation. + # @Prompt If CPU features will be initialized after SMM relocation. gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitAfterSmmRelocation|FALSE|BOO= LEAN|0x0000001C =20 - ## Specifies if CPU features will be initialized during S3 resume - # @Prompt if CPU features will be initialized during S3 resume + ## Specifies if CPU features will be initialized during S3 resume. + # @Prompt If CPU features will be initialized during S3 resume. gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitOnS3Resume|FALSE|BOOLEAN|0x0= 000001D =20 [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index f4dd339..cd0ecab 100644 --- a/UefiCpuPkg/UefiCpuPkg.uni +++ b/UefiCpuPkg/UefiCpuPkg.uni @@ -163,3 +163,34 @@ =20 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuMsegSize_HELP #language en-US= "Specifies buffer size in bytes of MSEG. The value should be a multiple of= 4KB." =20 +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSupport_PROMPT #langu= age en-US "Supported CPU features." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSupport_HELP #languag= e en-US "Specifies the supported CPU features bit in array." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitAfterSmmRelocation= _PROMPT #language en-US "If CPU features will be initialized after SMM rel= ocation." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitAfterSmmRelocation= _HELP #language en-US "Specifies if CPU features will be initialized after= SMM relocation." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitOnS3Resume_PROMPT = #language en-US "If CPU features will be initialized during S3 resume." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitOnS3Resume_HELP #= language en-US "Specifies if CPU features will be initialized during S3 res= ume." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesUserConfiguration_PROM= PT #language en-US "User settings for enabling/disabling processor feature= s." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesUserConfiguration_HELP= #language en-US "Specifies user's desired settings for enabling/disabling= processor features." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuClockModulationDutyCycle_PROMP= T #language en-US "The encoded values for target duty cycle modulation." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuClockModulationDutyCycle_HELP = #language en-US "Specifies the On-demand clock modulation duty cycle when = ACPI feature is enabled." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_PROMPT #language = en-US "Current boot is a power-on reset." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_HELP #language en= -US "Indicates if the current boot is a power-on reset." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_PROMPT #la= nguage en-US "Processor feature capabilities." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_HELP #lang= uage en-US "Indicates processor feature capabilities, each bit correspondin= g to a specific feature." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSetting_PROMPT #langu= age en-US "Actual processor feature settings." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSetting_HELP #languag= e en-US "Specifies actual settings for processor features, each bit corresp= onding to a specific feature." --=20 2.9.3.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel