On 02/22/17 02:58, Jordan Justen wrote:
> Good cleanups. Thanks for taking the extra time sort these out!
You made good points, so thanks for those :) Also, stale comments are
sometimes worse than no comments, so I wanted to clean up those too.
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Ha! I for one welcome another one of our ultra fast reviewer overlords! :)
Series committed as b9d56d0b93ae..ed1a2d42d5d5.
> Unfortunately, https://bugzilla.tianocore.org/show_bug.cgi?id=394 may
> not be quite so 'fun'. :)
Stay tuned, I'm already working on that :)
Thanks!
Laszlo
> -Jordan
>
> On 2017-02-21 07:38:06, Laszlo Ersek wrote:
>> Most of these were suggested by Jordan.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>
>> Repo: https://github.com/lersek/edk2.git
>> Branch: write_pointer_followup
>>
>> Thanks!
>> Laszlo
>>
>> Laszlo Ersek (6):
>> OvmfPkg/AcpiPlatformDxe: drop double right shift in ADD/WRITE POINTER
>> cmds
>> OvmfPkg/AcpiPlatformDxe: update PointerValue comments in
>> "BootScript.c"
>> OvmfPkg/QemuFwCfgLib: move types/macros from lib class to
>> IndustryStandard
>> OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_SELECTOR, adapt the package
>> OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_DATA, adapt the package
>> OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_DMA_ADDRESS, adapt the package
>>
>> OvmfPkg/Include/IndustryStandard/QemuFwCfg.h | 104 ++++++++++++++++++++
>> OvmfPkg/Include/Library/QemuFwCfgLib.h | 70 +------------
>> OvmfPkg/AcpiPlatformDxe/BootScript.c | 18 ++--
>> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 8 +-
>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 12 +--
>> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 6 +-
>> 6 files changed, 128 insertions(+), 90 deletions(-)
>> create mode 100644 OvmfPkg/Include/IndustryStandard/QemuFwCfg.h
>>
>> --
>> 2.9.3
>>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel