From nobody Fri May 17 03:13:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92621+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16611852813341.4903711152229562; Mon, 22 Aug 2022 09:21:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id TZTGYY1788612xhL1DnrM8zg; Mon, 22 Aug 2022 09:21:19 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.50]) by mx.groups.io with SMTP id smtpd.web09.20173.1661185278975405512 for ; Mon, 22 Aug 2022 09:21:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=euCyFMIRAaCqSDKLmb2MqVjlm+yL5xJO1/aMBJUT0Lum4vs5F/lHMQWCTJ2BqK3LHipRmmjV0U/BculgTcHEAC9mcN1ewgFd5LHPFXj3YWNupZZu+dVPcoCI3EIKC5mBTtZOGheYXFTA3Wn0BL4HDfunA5/2yARg1ZlS9ihbohNKknw9pM4hZdtnAHGxPE1D02kUm3X+9i1sLUBdFQMn4dyoMQ/9xcW4bfA77FNGntlsKvJ+EncJQqFYKVoo16c3yDuKWaPiIlxcHTfojLwoZrbV5Q+Bz0Gv++4+WevoPV33V5D4uS8V9t6hcV6VoB7GBCgLvrUi12D2HtQZYFCu+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W0t/SWhrCCh9oIVEiU1XjCJbZb1opTsVTtnFhJ3a+o4=; b=O9G5ndZ9zol79RJ39ECpqoM3xceu+INkIBtuvHiNqOqETp9+OMNmKcmgXZ8tZJdH2lc18t8JvBQXWg4i84MCe9odmmZMYbIYJxY0sVG3uG2CS+VGflZFohKu3vm3eKMXZkzq08j2QcV11liTOQ0j2b5QckBv4AfOyMF+S37nmnSvFr7Snbb7vPC94LUSKLAzQNwXfo3IIKgXtNRbJ6LPyyRXcteBTpuJ7giXUpBcWKN6hFJw35ED8tPlfvPWAELhG039Rt4iZYxquBFBEFfbLHcZZgc0upKveHaEG1WwOMRz/W46W1zCnwDwmj1eOWcWFFpUM0Qvmygw9lrOX1lWmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN0PR08CA0004.namprd08.prod.outlook.com (2603:10b6:408:142::22) by DM5PR12MB1241.namprd12.prod.outlook.com (2603:10b6:3:72::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Mon, 22 Aug 2022 16:21:17 +0000 X-Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:142:cafe::82) by BN0PR08CA0004.outlook.office365.com (2603:10b6:408:142::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.20 via Frontend Transport; Mon, 22 Aug 2022 16:21:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92621+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (12.22.5.238) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5546.7 via Frontend Transport; Mon, 22 Aug 2022 16:21:16 +0000 X-Received: from rnnvmail204.nvidia.com (10.129.68.6) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Mon, 22 Aug 2022 16:20:52 +0000 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 22 Aug 2022 09:20:52 -0700 X-Received: from ed7fa55790ac.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.29 via Frontend Transport; Mon, 22 Aug 2022 09:20:51 -0700 From: "Jeff Brasen via groups.io" To: CC: , , , , Jeff Brasen Subject: [edk2-devel] [PATCH] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation Date: Mon, 22 Aug 2022 10:21:01 -0600 Message-ID: <1dc8a5cb9e3965f6adb5b84a722401d70fe11d8e.1661185223.git.jbrasen@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7194ee82-49b4-4b46-278a-08da845a56f9 X-MS-TrafficTypeDiagnostic: DM5PR12MB1241:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: gxpp737MWBygSj8+klWAudBAmVgWlkhsHXj8eFOWfBc5NE1iwgaddmHJF+0+eghKI98F/vL2zQ7NDDaZ79K6OVtLB4004IYEvBpJ6Lod3Qs03OFwCah/xhzmeqgyKDwPHowlmsH6JSnKsxxIeJVgjmC3kmhRxqunTaQ47/363DRsA2qutsLEJOYozA97lvWaNHBe8yfyZ6R0W8Z2g0FAXMqoQRvwA4ie5tJnfo7iehPF+x1luoAtXnfwwsxv4vbFswJqWXnbx05N7pLBR4WHv8yLlU9mh6Jz5p58y1RVb5fF0tfZf3frg+V3hVT/AHxpxDgrz5YY78Lhs9IjTcsYzx/hRiFjE1JQeg0j2p1eRqbYb0Pg9wq3eEDwKmkao/kL5C1yVjSAZ1tkUfXB26+Db/dE5zrQC8GQfH1Kg/+M1W0KLihqJ5bsSWo1csflYAYz7mMSAxbVKTTv/rT6dKIcWf0H4NUW1yLQ2BLg2PRcv4CUymXt1ZAO/rJxRUUOcRk7OyjpNP8lxOyo3dMOiJmhcGt9/t2Ktp65teMFAZ3aSvhyY3/yQ1cUp0whdFtkSaFrSPEstKuQeTEW4yMlTSALq+H+I0mnA8jv1x72/PZUW6VO0ezYHuiPeF8n0A30oI0/SoqjjO846zLQvmLvtnywZpT9S9o1NFfcVSOa/pmHbnoHLOIJTzIL1eJJjnZEM2edOi/mIr9+jTd2qpsI5FHQ6le5Ags03bfLmkhzVgj51OjXEmuOvf+V4GCG4atkmCwkGU55r5eYc2Qdm8Vie+WruvIR1bnJOQ5GmKpn4ZowNmHFy/lt98H5lKekMCS5+E8FApG5NRi2cOG2uXhCYYbHL6gGhvskxZ17MSy1S9Vz3RA5h13j3Ktxp7P9ZkwpbjmXyATH6MhmGXog0QTaCR6l9a7cBxxrvyCJ1ex4yqOAwDw= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 16:21:16.5720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7194ee82-49b4-4b46-278a-08da845a56f9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.238];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1241 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: h5kVJBK7136YV3YlM34yAMOcx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661185279; bh=dmyA9rsHsBxM6IrRZNzFt/47w6iOYZNSvV38vZs8PmQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=rBFnk2tnQmzYIxZwuiBy/qgKn0LJtU+WCtxZxyTLsQATNNVBU5el4ixcBf8pzexgTVN Ev6cXif7xJviOC+TlGpwfGF1tOdegz0PLM2Nt6EJqU4Pj8zzYV3oZbDg+InCD6hFWpDpL l+lqMc5C0B0Ej5NyvEzeU6tCqTqFde0j9AY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661185283160100003 Content-Type: text/plain; charset="utf-8" Expose the UID value to GeneratePciSlots(). This is needed for some cases for example: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-= root-ports#identifying-externally-exposed-pcie-root-ports Signed-off-by: Jeff Brasen Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h | 8 +++++--- .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 ++++- .../Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c | 8 +++++--- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h b/Dynami= cTablesPkg/Include/Library/SsdtPcieSupportLib.h index 85e283a994..4171dabc33 100644 --- a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h +++ b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h @@ -54,9 +54,10 @@ AddOscMethod ( used. It should be possible to enumerate them, but this is additional information. =20 - @param [in] PciInfo Pci device information. - @param [in] MappingTable The mapping table structure. - @param [in, out] PciNode Pci node to amend. + @param [in] PciInfo Pci device information. + @param [in] MappingTable The mapping table structure. + @param [in] Uid Unique Id of the Pci device. + @param [in, out] PciNode Pci node to amend. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER Invalid parameter. @@ -67,6 +68,7 @@ EFIAPI GeneratePciSlots ( IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, IN CONST MAPPING_TABLE *MappingTable, + IN UINT32 Uid, IN OUT AML_OBJECT_NODE_HANDLE PciNode ); =20 diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c index ceffe2838c..24e074ea90 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c @@ -295,6 +295,7 @@ GeneratePciDeviceInfo ( @param [in] CfgMgrProtocol Pointer to the Configuration Manager Protocol interface. @param [in] PciInfo Pci device information. + @param [in] Uid Unique Id of the Pci device. @param [in, out] PciNode Pci node to amend. =20 @retval EFI_SUCCESS The function completed successfully. @@ -308,6 +309,7 @@ GeneratePrt ( IN ACPI_PCI_GENERATOR *Generator, IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST CfgMgrProtoc= ol, IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, + IN UINT32 Uid, IN OUT AML_OBJECT_NODE_HANDLE PciNode ) { @@ -416,7 +418,7 @@ GeneratePrt ( PrtNode =3D NULL; =20 // Generate the Pci slots once all the device have been added. - Status =3D GeneratePciSlots (PciInfo, &Generator->DeviceTable, PciNode); + Status =3D GeneratePciSlots (PciInfo, &Generator->DeviceTable, Uid, PciN= ode); if (EFI_ERROR (Status)) { ASSERT (0); goto exit_handler; @@ -687,6 +689,7 @@ GeneratePciDevice ( Generator, CfgMgrProtocol, PciInfo, + Uid, PciNode ); if (EFI_ERROR (Status)) { diff --git a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSup= portLib.c b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupp= ortLib.c index e5ab3a3ca8..b35fb6a7dd 100644 --- a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib= .c +++ b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib= .c @@ -41,9 +41,10 @@ used. It should be possible to enumerate them, but this is additional information. =20 - @param [in] PciInfo Pci device information. - @param [in] MappingTable The mapping table structure. - @param [in, out] PciNode Pci node to amend. + @param [in] PciInfo Pci device information. + @param [in] MappingTable The mapping table structure. + @param [in] Uid Unique Id of the Pci device. + @param [in, out] PciNode Pci node to amend. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER Invalid parameter. @@ -54,6 +55,7 @@ EFIAPI GeneratePciSlots ( IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, IN CONST MAPPING_TABLE *MappingTable, + IN UINT32 Uid, IN OUT AML_OBJECT_NODE_HANDLE PciNode ) { --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92621): https://edk2.groups.io/g/devel/message/92621 Mute This Topic: https://groups.io/mt/93185094/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-