[edk2-devel] RFC: Adding an alias to format patches with --stat= and --stat-graph-width=

Rebecca Cran posted 1 patch 1 year ago
Failed in applying to current master (apply log)
[edk2-devel] RFC: Adding an alias to format patches with --stat= and --stat-graph-width=
Posted by Rebecca Cran 1 year ago
I've noticed several patches recently which has ellipses at the start of 
the diffstat filenames.

When I started contributing to edk2 I remember being asked to always use 
--stat=1000 --stat-graph-width=20 to avoid that problem: it's mentioned 
in 
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers.

I was wondering if we might want to introduce an alias via SetupGit.py 
to add those parameters automatically?

For example:

diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
index 91814199bf..901d2025ab 100644
--- a/BaseTools/Scripts/SetupGit.py
+++ b/BaseTools/Scripts/SetupGit.py
@@ -82,6 +82,7 @@ OPTIONS = [
      {'section': 'sendemail',   'option': 'chainreplyto', 'value': False},
      {'section': 'sendemail',   'option': 'thread', 'value': True},
      {'section': 'sendemail',   'option': 'transferEncoding', 'value': 
'8bit'},
+    {'section': 'alias',       'option': 'fp', 'value': 'format-patch 
-M --stat=1000 --stat-graph-width=20'},^M
      ]


-- 
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102568): https://edk2.groups.io/g/devel/message/102568
Mute This Topic: https://groups.io/mt/98091795/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] RFC: Adding an alias to format patches with --stat= and --stat-graph-width=
Posted by gaoliming via groups.io 1 year ago
Rebecca:
 I think this is a good solution to setup Edk2 development environment. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2023年4月6日 4:54
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] RFC: Adding an alias to format patches with --stat= and
> --stat-graph-width=
> 
> I've noticed several patches recently which has ellipses at the start of
> the diffstat filenames.
> 
> When I started contributing to edk2 I remember being asked to always use
> --stat=1000 --stat-graph-width=20 to avoid that problem: it's mentioned
> in
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-
> git-guide-for-edk2-contributors-and-maintainers.
> 
> I was wondering if we might want to introduce an alias via SetupGit.py
> to add those parameters automatically?
> 
> For example:
> 
> diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
> index 91814199bf..901d2025ab 100644
> --- a/BaseTools/Scripts/SetupGit.py
> +++ b/BaseTools/Scripts/SetupGit.py
> @@ -82,6 +82,7 @@ OPTIONS = [
>       {'section': 'sendemail',   'option': 'chainreplyto', 'value': False},
>       {'section': 'sendemail',   'option': 'thread', 'value': True},
>       {'section': 'sendemail',   'option': 'transferEncoding', 'value':
> '8bit'},
> +    {'section': 'alias',       'option': 'fp', 'value': 'format-patch
> -M --stat=1000 --stat-graph-width=20'},^M
>       ]
> 
> 
> --
> Rebecca Cran
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102572): https://edk2.groups.io/g/devel/message/102572
Mute This Topic: https://groups.io/mt/98096034/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-