[edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Guo, Gua posted 1 patch 1 year, 7 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Posted by Guo, Gua 1 year, 7 months ago
From: Gua Guo <gua.guo@intel.com>

In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
index 4dd8d4ac67..8623aecb33 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
@@ -19,7 +19,7 @@
   MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.inf
 
 [BuildOptions]
-  GCC:*_*_*_CC_FLAGS = -fno-pie
+  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs
 !ifdef $(UNIT_TESTING_DEBUG)
   MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1
   GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93714): https://edk2.groups.io/g/devel/message/93714
Mute This Topic: https://groups.io/mt/93654981/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Posted by Guo, Gua 1 year, 7 months ago
Hi All

I want to follow below steps to generate code coverage data based the default build. But I notice currently GCC compiler flags won't generate *gcda and *.gcno.
So add the CC flags to generate necessary data that require by "lcov" tool.

I'm not sure whether have any concern to add the flags by default.

Step1. sudo apt-get install lcov
Step2. stuart_ci_build -c .pytool/CISettings.py -p MdePkg -t NOOPT -a IA32,X64 TOOL_CHAIN_TAG=GCC5 --verbose
Step3. lcov -c --rc lcov_branch_coverage=1 -o UnitTest.info -d Build/MdePkg/HostTest/NOOPT_GCC5/X64/MdePkg/
Step4. genhtml UnitTest.info --branch-coverage -o .Build/UnitTestReport
Step5. Open "Build/UnitTestReport/index.html"

Thanks,
Gua

-----Original Message-----
From: Guo, Gua <gua.guo@intel.com> 
Sent: Tuesday, September 13, 2022 9:24 PM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

From: Gua Guo <gua.guo@intel.com>

In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
index 4dd8d4ac67..8623aecb33 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
@@ -19,7 +19,7 @@
   MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.inf  [BuildOptions]-  GCC:*_*_*_CC_FLAGS = -fno-pie+  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs !ifdef $(UNIT_TESTING_DEBUG)   MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1   GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93715): https://edk2.groups.io/g/devel/message/93715
Mute This Topic: https://groups.io/mt/93654981/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Posted by Michael D Kinney 1 year, 7 months ago
Is there a Visual Studio Code plugin to view the code coverage too?

Thanks,

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Tuesday, September 13, 2022 6:28 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret
> <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
> Subject: RE: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
> 
> Hi All
> 
> I want to follow below steps to generate code coverage data based the default build. But I notice currently GCC compiler flags won't
> generate *gcda and *.gcno.
> So add the CC flags to generate necessary data that require by "lcov" tool.
> 
> I'm not sure whether have any concern to add the flags by default.
> 
> Step1. sudo apt-get install lcov
> Step2. stuart_ci_build -c .pytool/CISettings.py -p MdePkg -t NOOPT -a IA32,X64 TOOL_CHAIN_TAG=GCC5 --verbose
> Step3. lcov -c --rc lcov_branch_coverage=1 -o UnitTest.info -d Build/MdePkg/HostTest/NOOPT_GCC5/X64/MdePkg/
> Step4. genhtml UnitTest.info --branch-coverage -o .Build/UnitTestReport
> Step5. Open "Build/UnitTestReport/index.html"
> 
> Thanks,
> Gua
> 
> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Tuesday, September 13, 2022 9:24 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Barkelew,
> Bret <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
> Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to
> generate code coverage report.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> index 4dd8d4ac67..8623aecb33 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> @@ -19,7 +19,7 @@
>    MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.inf  [BuildOptions]-
> GCC:*_*_*_CC_FLAGS = -fno-pie+  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs !ifdef $(UNIT_TESTING_DEBUG)
> MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1   GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1--
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93717): https://edk2.groups.io/g/devel/message/93717
Mute This Topic: https://groups.io/mt/93654981/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Posted by Guo, Gua 1 year, 7 months ago
Yes, we can install gcov viewer on vscode.
[cid:image001.png@01D8C7C7.45B07080]

[cid:image002.png@01D8C7C7.45B07080]











Thanks,

Gua

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Tuesday, September 13, 2022 11:12 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
Subject: RE: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC



Is there a Visual Studio Code plugin to view the code coverage too?



Thanks,



Mike



> -----Original Message-----

> From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>

> Sent: Tuesday, September 13, 2022 6:28 AM

> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>

> Cc: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Sean Brogan

> <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Barkelew, Bret

> <bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>>; Michael Kubacki

> <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>

> Subject: RE: [PATCH] UnitTestFrameworkPkg: Add code coverage support

> for GCC

>

> Hi All

>

> I want to follow below steps to generate code coverage data based the

> default build. But I notice currently GCC compiler flags won't generate *gcda and *.gcno.

> So add the CC flags to generate necessary data that require by "lcov" tool.

>

> I'm not sure whether have any concern to add the flags by default.

>

> Step1. sudo apt-get install lcov

> Step2. stuart_ci_build -c .pytool/CISettings.py -p MdePkg -t NOOPT -a

> IA32,X64 TOOL_CHAIN_TAG=GCC5 --verbose Step3. lcov -c --rc

> lcov_branch_coverage=1 -o UnitTest.info -d

> Build/MdePkg/HostTest/NOOPT_GCC5/X64/MdePkg/

> Step4. genhtml UnitTest.info --branch-coverage -o

> .Build/UnitTestReport Step5. Open "Build/UnitTestReport/index.html"

>

> Thanks,

> Gua

>

> -----Original Message-----

> From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>

> Sent: Tuesday, September 13, 2022 9:24 PM

> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>

> Cc: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Kinney, Michael D

> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>;

> Barkelew, Bret <bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>>; Michael Kubacki

> <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>

> Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for

> GCC

>

> From: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>

>

> In order to collect code coverage after running executable file,

> generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report.

>

> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>

> Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>

> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>

> Cc: Michael Kubacki <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>

> Signed-off-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>

> ---

>  UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc

> b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc

> index 4dd8d4ac67..8623aecb33 100644

> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc

> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc

> @@ -19,7 +19,7 @@

>

> MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.inf  [BuildOptions]- GCC:*_*_*_CC_FLAGS = -fno-pie+  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs !ifdef $(UNIT_TESTING_DEBUG)

> MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1   GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1--

> 2.31.1.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93718): https://edk2.groups.io/g/devel/message/93718
Mute This Topic: https://groups.io/mt/93654981/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Posted by Michael D Kinney 1 year, 7 months ago
Hi,

This change looks safe because it is scoped to host-based unit tests
that include this file in the DSC file that builds host-based tests.

Can you also update the UnitTestFrameworkPkg/ReadMe.md to describe how
a developer can enable/use the code coverage feature for GCC host-based
tests?

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Tuesday, September 13, 2022 6:24 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Barkelew,
> Bret <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
> Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> In order to collect code coverage after running executable
> file, generate *.gcda and *.gcno file that require by lcov tool
> to generate code coverage report.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> index 4dd8d4ac67..8623aecb33 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> @@ -19,7 +19,7 @@
>    MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.inf
> 
> 
> 
>  [BuildOptions]
> 
> -  GCC:*_*_*_CC_FLAGS = -fno-pie
> 
> +  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs
> 
>  !ifdef $(UNIT_TESTING_DEBUG)
> 
>    MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1
> 
>    GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93716): https://edk2.groups.io/g/devel/message/93716
Mute This Topic: https://groups.io/mt/93654981/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC
Posted by Guo, Gua 1 year, 7 months ago
Sure, thanks for replying quickly, let me update readme.md file in my next patch.

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Tuesday, September 13, 2022 11:10 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret <bret.barkelew@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>
Subject: RE: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Hi,

This change looks safe because it is scoped to host-based unit tests that include this file in the DSC file that builds host-based tests.

Can you also update the UnitTestFrameworkPkg/ReadMe.md to describe how a developer can enable/use the code coverage feature for GCC host-based tests?

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Tuesday, September 13, 2022 6:24 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; 
> Barkelew, Bret <bret.barkelew@microsoft.com>; Michael Kubacki 
> <mikuback@linux.microsoft.com>
> Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for 
> GCC
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> In order to collect code coverage after running executable file, 
> generate *.gcda and *.gcno file that require by lcov tool to generate 
> code coverage report.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc 
> b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> index 4dd8d4ac67..8623aecb33 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> @@ -19,7 +19,7 @@
>    
> MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocatio
> nLibPosix/MemoryAllocationLibPosix.inf
> 
> 
> 
>  [BuildOptions]
> 
> -  GCC:*_*_*_CC_FLAGS = -fno-pie
> 
> +  GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs
> 
>  !ifdef $(UNIT_TESTING_DEBUG)
> 
>    MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1
> 
>    GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93719): https://edk2.groups.io/g/devel/message/93719
Mute This Topic: https://groups.io/mt/93654981/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-