FDF spec: Correct the example with SET statement in [FD] section

[edk2] [Patch] FDF spec: Correct the example with SET statement in [FD] section

Posted by Liming Gao 5 years, 10 months ago

Region base address needs to add FD base address as the final value.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
 2_fdf_design_discussion/24_[fd]_sections.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_discussion/24_[fd]_sections.md
index d55b793..04053a0 100644
--- a/2_fdf_design_discussion/24_[fd]_sections.md
+++ b/2_fdf_design_discussion/24_[fd]_sections.md
@@ -212,7 +212,7 @@ gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress | gEfiMyTokenSpaceGuid.PcdFlashFv
 FV = FvMain
 
 0x000000|0x0C0000
-SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000
+SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000 + $(BaseAddress)
 SET gEfiMyTokenSpaceGuid.PcdFlashFvMainSize        = 0x0C0000
 FV = FvMain
 ```
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] FDF spec: Correct the example with SET statement in [FD] section

Posted by Zhu, Yonghong 5 years, 10 months ago

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Gao, Liming 
Sent: Monday, June 04, 2018 5:22 PM
To: edk2-devel@lists.01.org
Cc: Sean Brogan <sean.brogan@microsoft.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [Patch] FDF spec: Correct the example with SET statement in [FD] section

Region base address needs to add FD base address as the final value.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
 2_fdf_design_discussion/24_[fd]_sections.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_discussion/24_[fd]_sections.md
index d55b793..04053a0 100644
--- a/2_fdf_design_discussion/24_[fd]_sections.md
+++ b/2_fdf_design_discussion/24_[fd]_sections.md
@@ -212,7 +212,7 @@ gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress | gEfiMyTokenSpaceGuid.PcdFlashFv  FV = FvMain
 
 0x000000|0x0C0000
-SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000
+SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000 + 
+$(BaseAddress)
 SET gEfiMyTokenSpaceGuid.PcdFlashFvMainSize        = 0x0C0000
 FV = FvMain
 ```
--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel