On 1 June 2018 at 16:32, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi,
>
> Hereby I submit a capsule support for Marvell Armada platforms.
> Capsule preparation must be done in two steps, it requires additional
> build flag (-D CAPSULE_ENABLE), so by default nothing changes. Also the
> solution is using generic EDK2 drivers and libraries, so all
> wiki/howtos from Tianocore are valid. Verified from within UEFI
> (CapsuleApp.efi) and standard distro fwupdate (on Debian and Fedora).
> More details can be found in the commit logs.
>
> The code is also available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/capsule-upstream-r20180601
>
> David Sniatkiwicz (1):
> Marvell/Armada7k8k: Introduce capsule FW update implementation
>
> Marcin Wojtas (3):
> Marvell/Armada70x0Db: Shift main FV from 0x0 address
> Marvell/Aramda7k8k: Enable PEI booting stage
> Marvell/Armada7k8k: Wire up capsule support
>
Very nice!
The code looks mostly fine to me, with a couple of minor comments.
> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 96 ++++++-
> Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.dsc | 46 ++++
> Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.fdf | 70 ++++++
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 81 +++++-
> Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c | 261 ++++++++++++++++++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf | 52 ++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 81 ++++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 50 ++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 74 ++++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 26 ++
> 10 files changed, 829 insertions(+), 8 deletions(-)
> create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.dsc
> create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.fdf
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel