1. Patchew
  2. EDK2
  3. View series

[edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

Liming Gao posted 1 patch 5 years, 10 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol
Posted by Liming Gao 5 years, 10 months ago 
BootLogo protocol is not always required. If it is installed,
BootManagerMenuApp can work.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
 MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
index dd60ef4..392a970 100644
--- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
+++ b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
@@ -4,7 +4,7 @@
 #  The application pops up a menu showing all the boot options referenced by
 #  BootOrder NV variable and user can choose to boot from one of them.
 #  
-#  Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution.  The full text of the license may be found at
@@ -51,7 +51,7 @@
 [Guids]
 
 [Protocols]
-  gEfiBootLogoProtocolGuid                      ## CONSUMES
+  gEfiBootLogoProtocolGuid                      ## SOMETIMES_CONSUMES
   gEfiLoadedImageDevicePathProtocolGuid         ## CONSUMES
 
 [Pcd]
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol
Posted by Ni, Ruiyu 5 years, 10 months ago 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, May 29, 2018 1:54 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] MdeModulePkg BootManagerMenuApp: Update usage info
> for BootLogo protocol
> 
> BootLogo protocol is not always required. If it is installed,
> BootManagerMenuApp can work.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> 
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp
> p.inf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu
> App.inf
> b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu
> App.inf
> index dd60ef4..392a970 100644
> ---
> a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu
> App.inf
> +++
> b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu
> App.inf
> @@ -4,7 +4,7 @@
>  #  The application pops up a menu showing all the boot options referenced
> by
>  #  BootOrder NV variable and user can choose to boot from one of them.
>  #
> -#  Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the
> BSD License
>  #  which accompanies this distribution.  The full text of the license may be
> found at
> @@ -51,7 +51,7 @@
>  [Guids]
> 
>  [Protocols]
> -  gEfiBootLogoProtocolGuid                      ## CONSUMES
> +  gEfiBootLogoProtocolGuid                      ## SOMETIMES_CONSUMES
>    gEfiLoadedImageDevicePathProtocolGuid         ## CONSUMES
> 
>  [Pcd]
> --
> 2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol
Posted by Zeng, Star 5 years, 10 months ago 
Liming,

Should " If it is installed " be " If it is not installed " in the commit message?


Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Tuesday, May 29, 2018 1:54 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

BootLogo protocol is not always required. If it is installed, BootManagerMenuApp can work.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
 MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
index dd60ef4..392a970 100644
--- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
+++ b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
@@ -4,7 +4,7 @@
 #  The application pops up a menu showing all the boot options referenced by  #  BootOrder NV variable and user can choose to boot from one of them.
 #
-#  Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights 
+reserved.<BR>
 #  This program and the accompanying materials  #  are licensed and made available under the terms and conditions of the BSD License  #  which accompanies this distribution.  The full text of the license may be found at @@ -51,7 +51,7 @@  [Guids]
 
 [Protocols]
-  gEfiBootLogoProtocolGuid                      ## CONSUMES
+  gEfiBootLogoProtocolGuid                      ## SOMETIMES_CONSUMES
   gEfiLoadedImageDevicePathProtocolGuid         ## CONSUMES
 
 [Pcd]
--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol
Posted by Gao, Liming 5 years, 10 months ago 
Good catch. I will update the commit message.

>-----Original Message-----
>From: Zeng, Star
>Sent: Monday, June 04, 2018 2:37 PM
>To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update
>usage info for BootLogo protocol
>
>Liming,
>
>Should " If it is installed " be " If it is not installed " in the commit message?
>
>
>Thanks,
>Star
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Liming Gao
>Sent: Tuesday, May 29, 2018 1:54 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update
>usage info for BootLogo protocol
>
>BootLogo protocol is not always required. If it is installed,
>BootManagerMenuApp can work.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>---
>
>MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp
>p.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git
>a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>index dd60ef4..392a970 100644
>---
>a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>+++
>b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>@@ -4,7 +4,7 @@
> #  The application pops up a menu showing all the boot options referenced by
>#  BootOrder NV variable and user can choose to boot from one of them.
> #
>-#  Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR>
>+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights
>+reserved.<BR>
> #  This program and the accompanying materials  #  are licensed and made
>available under the terms and conditions of the BSD License  #  which
>accompanies this distribution.  The full text of the license may be found at
>@@ -51,7 +51,7 @@  [Guids]
>
> [Protocols]
>-  gEfiBootLogoProtocolGuid                      ## CONSUMES
>+  gEfiBootLogoProtocolGuid                      ## SOMETIMES_CONSUMES
>   gEfiLoadedImageDevicePathProtocolGuid         ## CONSUMES
>
> [Pcd]
>--
>2.8.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol
Posted by Zeng, Star 5 years, 10 months ago 
With update, Reviewed-by: Star Zeng <star.zeng@intel.com>.

-----Original Message-----
From: Gao, Liming 
Sent: Monday, June 4, 2018 2:39 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

Good catch. I will update the commit message.

>-----Original Message-----
>From: Zeng, Star
>Sent: Monday, June 04, 2018 2:37 PM
>To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update 
>usage info for BootLogo protocol
>
>Liming,
>
>Should " If it is installed " be " If it is not installed " in the commit message?
>
>
>Thanks,
>Star
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
>Liming Gao
>Sent: Tuesday, May 29, 2018 1:54 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage 
>info for BootLogo protocol
>
>BootLogo protocol is not always required. If it is installed, 
>BootManagerMenuApp can work.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>---
>
>MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp
>p.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git
>a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>index dd60ef4..392a970 100644
>---
>a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>+++
>b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>@@ -4,7 +4,7 @@
> #  The application pops up a menu showing all the boot options 
>referenced by #  BootOrder NV variable and user can choose to boot from one of them.
> #
>-#  Copyright (c) 2011 - 2015, Intel Corporation. All rights 
>reserved.<BR>
>+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights 
>+reserved.<BR>
> #  This program and the accompanying materials  #  are licensed and 
>made available under the terms and conditions of the BSD License  #  
>which accompanies this distribution.  The full text of the license may 
>be found at @@ -51,7 +51,7 @@  [Guids]
>
> [Protocols]
>-  gEfiBootLogoProtocolGuid                      ## CONSUMES
>+  gEfiBootLogoProtocolGuid                      ## SOMETIMES_CONSUMES
>   gEfiLoadedImageDevicePathProtocolGuid         ## CONSUMES
>
> [Pcd]
>--
>2.8.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.