From nobody Fri May 3 08:40:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1523868076444590.6639214239148; Mon, 16 Apr 2018 01:41:16 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1DF4122497F3A; Mon, 16 Apr 2018 01:41:15 -0700 (PDT) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 30A2E22497F27 for ; Mon, 16 Apr 2018 01:41:12 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 01:41:12 -0700 Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.46]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2018 01:41:11 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="37675613" From: Star Zeng To: edk2-devel@lists.01.org Date: Mon, 16 Apr 2018 16:41:08 +0800 Message-Id: <1523868068-143104-1-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 Subject: [edk2] [PATCH] SecurityPkg FmpAuthenticationLibRsa2048Sha256: Remove PCD reference X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao , Chao Zhang , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" PcdRsa2048Sha256PublicKeyBuffer is referenced but not used in the library, that makes me a little confusing. Actually, the PublicKeyData should be from the caller of AuthenticateFmpImage() as input parameter, for example EdkiiSystemCapsuleLib. This patch is to remove the PCD reference in this library instance to be aligned with FmpAuthenticationLibPkcs7 that does not reference PcdPkcs7CertBuffer. Cc: Chao Zhang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jiewen.yao@intel.com --- .../FmpAuthenticationLibRsa2048Sha256.c | 4 += +-- .../FmpAuthenticationLibRsa2048Sha256.inf | 5 += ---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthe= nticationLibRsa2048Sha256.c b/SecurityPkg/Library/FmpAuthenticationLibRsa20= 48Sha256/FmpAuthenticationLibRsa2048Sha256.c index b40993fd1b00..038e12447782 100644 --- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticati= onLibRsa2048Sha256.c +++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticati= onLibRsa2048Sha256.c @@ -10,7 +10,7 @@ FmpAuthenticatedHandlerRsa2048Sha256(), AuthenticateFmpImage() will rece= ive untrusted input and do basic validation. =20 - Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -133,7 +133,7 @@ FmpAuthenticatedHandlerRsa2048Sha256 ( } =20 // - // Fail if the PublicKey is not one of the public keys in PcdRsa2048Sha2= 56PublicKeyBuffer + // Fail if the PublicKey is not one of the public keys in the input Publ= icKeyData. // PublicKey =3D (VOID *)PublicKeyData; PublicKeyBufferSize =3D PublicKeyDataLength; diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthe= nticationLibRsa2048Sha256.inf b/SecurityPkg/Library/FmpAuthenticationLibRsa= 2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf index b190eca8805c..cdd22429c274 100644 --- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticati= onLibRsa2048Sha256.inf +++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticati= onLibRsa2048Sha256.inf @@ -3,7 +3,7 @@ # # Instance of FmpAuthentication Library for DXE/PEI post memory phase. # -# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
# This program and the accompanying materials # are licensed and made available under the terms and conditions of the B= SD License # which accompanies this distribution. The full text of the license may = be found at @@ -45,9 +45,6 @@ [LibraryClasses] MemoryAllocationLib BaseCryptLib =20 -[Pcd] - gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CON= SUMES - [Guids] gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID # = Unique ID for the type of the certificate. gEfiHashAlgorithmSha256Guid ## SOMETIMES_CONSUMES ## GUID --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel