From nobody Wed May 1 23:15:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 152385539200563.53018112868608; Sun, 15 Apr 2018 22:09:52 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C9CE32272960D; Sun, 15 Apr 2018 22:09:49 -0700 (PDT) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3E5AF226EAC8C for ; Sun, 15 Apr 2018 22:09:48 -0700 (PDT) Received: by mail-lf0-x243.google.com with SMTP id n14-v6so2529051lfe.5 for ; Sun, 15 Apr 2018 22:09:48 -0700 (PDT) Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d27-v6sm2683717lfb.6.2018.04.15.22.09.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 15 Apr 2018 22:09:45 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4010:c07::243; helo=mail-lf0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=q9ZLkvPltkGZ1tyEHvueriI1DBnp+lBYbN84pKyp3sA=; b=opXSz1lNuB8QQJ9NW3ZjgC9WwaYHSevnRzqf+OiL7DkLGDymlRPRScUpnwltXLedxu m+YASwJR2QuBqi+hqL/8IzLDOaKbvE7nO5DRp/v9Dgxkwqj2/1Z//PDEvNbQ5yvrPXlK QI4KRILh7iuc3f2RfIGwyr8evHYiCpk5B1oWPBdMVv/F53B9gzrF3xRb2UWyCzvCKS3K l4HSb4yhz8j4lhiGSDxfq8lZFTstG3juJerH9TJhhrqdXNFDp5Lsw5B3NZmd7TqhbV13 HgG7fkr5hEG3gaXLaxDxrIgO7OJXEkhDOQ+3VMELOn57V+hcLKOCiO+qiOwncQKRBB9C OWUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=q9ZLkvPltkGZ1tyEHvueriI1DBnp+lBYbN84pKyp3sA=; b=Ba3htN5HJVYxMVaV3r3kxar01aZHRPMY0unqYpDVAjHSPj6pxG9GE7oK6w/KgODdBm dpDkE7XRcG3MYW9+64qP9tYb0IvAcPhw8B69sd+mBsjv1R0KffFQa5s7AmsbW31dp0sy N7rrjX/0WV1bT28DxCmRDmYbf5BF3Gj5unayMu4pepMeKL5wbLT3LETAuhYsAa2N8RX8 Sem/zPZjrk8GUjQqmjxzLL+OA3f7Olu98/BrZdKAP+9JBzqFemLdGXppDcX9kJH5gatI AitG4ARoNRJW76iWl8xQpXB++8ilzqQAuh8+CBsUaxakrHhLS8gFiv0sBukpvWeRA3ZZ uJWA== X-Gm-Message-State: ALQs6tASJj9+QyI2QZzW659yuQRmPsojl0lIkBAgfLRcwxBMgEe36NHA FuilW24ftJV0EkzgSxZXieBEHz0AD9A= X-Google-Smtp-Source: AIpwx4+CdEZu0POYAmMbWRflebwJnR9UVzQXkOnK63dDDD8XrbQDG/DLZotmB7AF7Hgrjizasr9Aiw== X-Received: by 10.46.158.199 with SMTP id h7mr8654768ljk.103.1523855386047; Sun, 15 Apr 2018 22:09:46 -0700 (PDT) From: Marcin Wojtas To: edk2-devel@lists.01.org Date: Mon, 16 Apr 2018 07:09:12 +0200 Message-Id: <1523855353-9262-2-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523855353-9262-1-git-send-email-mw@semihalf.com> References: <1523855353-9262-1-git-send-email-mw@semihalf.com> Subject: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jinghua@marvell.com, ard.biesheuvel@linaro.org, jaz@semihalf.com, leif.lindholm@linaro.org, nadavh@marvell.com, neta@marvell.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Recent changes in the EDK2 mainline resulted in breaking of compilation and booting of Armada platforms. This patch adjust the MvFvbDxe driver by: * installation of gEdkiiNvVarStoreFormattedGuid in order to signal NvVarStoreFormattedLib to the generic variable runtime driver * making explicit dependency to ArmPkg/Drivers/CpuDxe drivers in order to enable successful calling of gDS->SetMemorySpaceAttributes Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 21 ++++++++++++++++++++ Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf | 7 ++----- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marv= ell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c index 252ef67..6e583a3 100644 --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c @@ -26,6 +26,7 @@ #include #include =20 +#include #include #include =20 @@ -1076,6 +1077,21 @@ MvFvbEntryPoint ( } =20 // + // The driver implementing the variable read service can now be dispatch= ed; + // the varstore headers are in place. + // + Status =3D gBS->InstallProtocolInterface (&gImageHandle, + &gEdkiiNvVarStoreFormattedGuid, + EFI_NATIVE_INTERFACE, + NULL); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to install gEdkiiNvVarStoreFormattedGuid\n", + __FUNCTION__)); + goto ErrorInstallNvVarStoreFormatted; + } + + // // Declare the Non-Volatile storage as EFI_MEMORY_RUNTIME // RuntimeMmioRegionSize =3D mFvbDevice->FvbSize; @@ -1126,6 +1142,11 @@ ErrorSetMemAttr: gDS->RemoveMemorySpace (RegionBaseAddress, RuntimeMmioRegionSize); =20 ErrorAddSpace: + gBS->UninstallProtocolInterface (&gImageHandle, + &gEdkiiNvVarStoreFormattedGuid, + NULL); + +ErrorInstallNvVarStoreFormatted: gBS->UninstallMultipleProtocolInterfaces (&mFvbDevice->Handle, &gEfiDevicePathProtocolGuid, &gEfiFirmwareVolumeBlockProtocolGuid, diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf b/Silicon/Ma= rvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf index 117fe8b..fd3f2f7 100644 --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf @@ -63,6 +63,7 @@ UefiRuntimeServicesTableLib =20 [Guids] + gEdkiiNvVarStoreFormattedGuid gEfiAuthenticatedVariableGuid gEfiEventVirtualAddressChangeGuid gEfiSystemNvDataFvGuid @@ -84,8 +85,4 @@ gMarvellTokenSpaceGuid.PcdSpiMemoryBase =20 [Depex] - # - # MvFvbDxe must be loaded before VariableRuntimeDxe in case empty - # flash needs populating with default values. - # - BEFORE gVariableRuntimeDxeFileGuid + gEfiCpuArchProtocolGuid --=20 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 23:15:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1523855394507767.2177787703458; Sun, 15 Apr 2018 22:09:54 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 0576422742A87; Sun, 15 Apr 2018 22:09:52 -0700 (PDT) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 537022267F0F5 for ; Sun, 15 Apr 2018 22:09:49 -0700 (PDT) Received: by mail-lf0-x243.google.com with SMTP id q9-v6so20117353lfk.9 for ; Sun, 15 Apr 2018 22:09:49 -0700 (PDT) Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d27-v6sm2683717lfb.6.2018.04.15.22.09.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 15 Apr 2018 22:09:46 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4010:c07::243; helo=mail-lf0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6Iv/bP+MdKht7p90MJRLNV3paUHWS7e2ecV8glY6l+Q=; b=fLtyKcsQc9MWHDJXQm9HraoZmp1LKxcV6Yz1OG8VJ6dEiqp/pHs7lwSgwUBPlcghDn TC7r/6KSr0rcbjQ7i3NCm5ouutLVpnYw944SIdJ8JkvxgocTCFr8sNThf8GZKLtQGje0 +TSqcSs+CQnJKnvLT+KQn11UNG9Olao9Bdkrw3tQ/NkD0nWrsd3a0ssFxgM1KZ3Q10WB K7YxA/Y1aXVm7js0mYQ5wElVC57Wxj8cXmR4Inch9ckU/FlT8gBNu04dsnLRgnbKWX5A nwHT9yTw/vY6kHRpZjVISaAlgY1FX/EBEEdM8xU6xDzIc7ZQ73lVUF0QQolhRx8GwK0p QpHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6Iv/bP+MdKht7p90MJRLNV3paUHWS7e2ecV8glY6l+Q=; b=Wx7WnONrwlN1iLI6VZj3k7BqD1qYTm+8uYlgtcbEoj3kNV05z0nR6dG/RTBhcUtBGK 0TP03ZojTesKitEzYlto5cCrv59ynKGE4xxETEmteqXDdFObNcMnTW835a3Txc3R/eKz be8kaEv+Hcvu9f7WAwf2pfzImt3FASUe0iH4VYjxG/5hjhwTO93oRjU/0n99S4fg2M+W ZdC7Y/8hBBpi3QTv7zIWa/0We367QCoLYNrhTMifxklR7ConQ8vNW3RoZcN42/oK/eO6 331zA1QusqkAQhkXRaaTo7tVV4lpV6EQhv3r0yUnXJ39BdfwFvzdfl+eXbQRgcNXIMIC EFaA== X-Gm-Message-State: ALQs6tBFNAy8x6CqChkal0bxwz0dqOfq1DMKoEZePYWam5PzJaCg4x4W LkSsIhCUyuyc8poPjjZG1jIvNmTc+54= X-Google-Smtp-Source: AIpwx4/ZQ1EeBIGJ8Q4qaPdmKdPxqCiWeZWtUdfae/VNMw1k1lBAqkuLR69bxygdaRRRJJvV3tAI+w== X-Received: by 10.46.151.70 with SMTP id f6mr2812127ljj.140.1523855387320; Sun, 15 Apr 2018 22:09:47 -0700 (PDT) From: Marcin Wojtas To: edk2-devel@lists.01.org Date: Mon, 16 Apr 2018 07:09:13 +0200 Message-Id: <1523855353-9262-3-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523855353-9262-1-git-send-email-mw@semihalf.com> References: <1523855353-9262-1-git-send-email-mw@semihalf.com> Subject: [edk2] [platforms PATCH 2/2] Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jinghua@marvell.com, ard.biesheuvel@linaro.org, jaz@semihalf.com, leif.lindholm@linaro.org, nadavh@marvell.com, neta@marvell.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Recent changes in the EDK2 mainline resulted in breaking RTC functionality of Armada platforms. The RealTimeClockLib instance calls gDS->SetMemorySpaceAttributes() in the LibRtcInitialize() public function. This DXE service depends on the CPU Arch Protocol. Add it to the depex. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Acked-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf |= 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeCl= ockLib.inf b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeCl= ockLib.inf index 2f842e8..59c71c4 100644 --- a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.= inf +++ b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.= inf @@ -25,7 +25,7 @@ FILE_GUID =3D fa81e889-045b-4c96-9093-742554fd0588 MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D RealTimeClockLib + LIBRARY_CLASS =3D RealTimeClockLib|DXE_RUNTIME_DRIVER =20 [Sources.common] RealTimeClockLib.c @@ -50,3 +50,6 @@ =20 [Pcd] gMarvellTokenSpaceGuid.PcdRtcEnabled + +[Depex.common.DXE_RUNTIME_DRIVER] + gEfiCpuArchProtocolGuid --=20 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel