From nobody Wed May 8 01:15:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1522720347257966.6925939145614; Mon, 2 Apr 2018 18:52:27 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id ED79E21FB7D3F; Mon, 2 Apr 2018 18:52:24 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C0B7321FB7D36 for ; Mon, 2 Apr 2018 18:52:23 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2018 18:52:13 -0700 Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.46]) by orsmga003.jf.intel.com with ESMTP; 02 Apr 2018 18:52:12 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,398,1517904000"; d="scan'208";a="40225313" From: Star Zeng To: edk2-devel@lists.01.org Date: Tue, 3 Apr 2018 09:52:06 +0800 Message-Id: <1522720327-68812-2-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 In-Reply-To: <1522720327-68812-1-git-send-email-star.zeng@intel.com> References: <1522720327-68812-1-git-send-email-star.zeng@intel.com> Subject: [edk2] [PATCH 1/2] MdeModulePkg SmmMemoryAttribute.h: Refine some comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" 1. Fix some "support" to "supported". 2. Fix some "set" to "clear" in ClearMemoryAttributes interface. 3. Remove redundant comments for GetMemoryAttributes interface. Cc: Jian J Wang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jian J Wang Reviewed-by: Laszlo Ersek --- MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h b/MdeModule= Pkg/Include/Protocol/SmmMemoryAttribute.h index 0700eb51d6e1..012fa2aaec6e 100644 --- a/MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h +++ b/MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h @@ -2,7 +2,7 @@ SMM Memory Attribute Protocol provides retrieval and update service for memory attributes in EFI SMM environment. =20 - Copyright (c) 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -42,7 +42,7 @@ typedef struct _EDKII_SMM_MEMORY_ATTRIBUTE_PROTOCOL EDKII= _SMM_MEMORY_ATTRIBUTE_P @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 @@ -64,17 +64,17 @@ EFI_STATUS @param BaseAddress The physical address that is the start address= of a memory region. @param Length The size in bytes of the memory region. - @param Attributes The bit mask of attributes to set for the memo= ry + @param Attributes The bit mask of attributes to clear for the me= mory region. =20 - @retval EFI_SUCCESS The attributes were set for the memory reg= ion. + @retval EFI_SUCCESS The attributes were clear for the memory r= egion. @retval EFI_INVALID_PARAMETER Length is zero. Attributes specified an illegal combinatio= n of attributes that cannot be set together. @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 @@ -89,7 +89,7 @@ EFI_STATUS ); =20 /** - This function retrieve the attributes of the memory region specified by + This function retrieves the attributes of the memory region specified by BaseAddress and Length. If different attributes are got from different p= art of the memory region, EFI_NO_MAPPING will be returned. =20 @@ -107,9 +107,6 @@ EFI_STATUS @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for - the memory resource range specified by - BaseAddress and Length. =20 **/ typedef --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 8 01:15:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1522720349825536.1177349869697; Mon, 2 Apr 2018 18:52:29 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2558E21FB7D42; Mon, 2 Apr 2018 18:52:25 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DD69121FB7D34 for ; Mon, 2 Apr 2018 18:52:23 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2018 18:52:15 -0700 Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.46]) by orsmga003.jf.intel.com with ESMTP; 02 Apr 2018 18:52:13 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,398,1517904000"; d="scan'208";a="40225319" From: Star Zeng To: edk2-devel@lists.01.org Date: Tue, 3 Apr 2018 09:52:07 +0800 Message-Id: <1522720327-68812-3-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 In-Reply-To: <1522720327-68812-1-git-send-email-star.zeng@intel.com> References: <1522720327-68812-1-git-send-email-star.zeng@intel.com> Subject: [edk2] [PATCH 2/2] UefiCpuPkg PiSmmCpuDxeSmm: Refine some comments about SmmMemoryAttribute X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao , Eric Dong , Star Zeng , Laszlo Ersek MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" 1. Fix some "support" to "supported". 2. Fix some "set" to "clear" in ClearMemoryAttributes interface. 3. Remove redundant comments for GetMemoryAttributes interface. Cc: Jian J Wang Cc: Jiewen Yao Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jian J Wang Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 15 ++++++--------- UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 21 +++++++++---------= --- 2 files changed, 15 insertions(+), 21 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmC= puDxeSmm/PiSmmCpuDxeSmm.h index a2babb987732..af6437ee822b 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1079,7 +1079,7 @@ TransferApToSafeState ( @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 @@ -1101,17 +1101,17 @@ EdkiiSmmSetMemoryAttributes ( @param BaseAddress The physical address that is the start address= of a memory region. @param Length The size in bytes of the memory region. - @param Attributes The bit mask of attributes to set for the memo= ry + @param Attributes The bit mask of attributes to clear for the me= mory region. =20 - @retval EFI_SUCCESS The attributes were set for the memory reg= ion. + @retval EFI_SUCCESS The attributes were clear for the memory r= egion. @retval EFI_INVALID_PARAMETER Length is zero. Attributes specified an illegal combinatio= n of - attributes that cannot be set together. + attributes that cannot be clear together. @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 @@ -1126,7 +1126,7 @@ EdkiiSmmClearMemoryAttributes ( ); =20 /** - This function retrieve the attributes of the memory region specified by + This function retrieves the attributes of the memory region specified by BaseAddress and Length. If different attributes are got from different p= art of the memory region, EFI_NO_MAPPING will be returned. =20 @@ -1144,9 +1144,6 @@ EdkiiSmmClearMemoryAttributes ( @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for - the memory resource range specified by - BaseAddress and Length. =20 **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPk= g/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c index 2a4a29899862..17515fbe079c 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c @@ -604,7 +604,7 @@ SmmClearMemoryAttributesEx ( the memory resource range. @retval EFI_UNSUPPORTED The processor does not support one or more= bytes of the memory resource range specified by BaseAddress an= d Length. - The bit mask of attributes is not support = for the memory resource + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 **/ @@ -632,12 +632,12 @@ SmmSetMemoryAttributes ( BaseAddress and Length cannot be modified. @retval EFI_INVALID_PARAMETER Length is zero. Attributes specified an illegal combinatio= n of attributes that - cannot be set together. + cannot be clear together. @retval EFI_OUT_OF_RESOURCES There are not enough system resources to m= odify the attributes of the memory resource range. @retval EFI_UNSUPPORTED The processor does not support one or more= bytes of the memory resource range specified by BaseAddress an= d Length. - The bit mask of attributes is not support = for the memory resource + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 **/ @@ -1185,7 +1185,7 @@ IsSmmCommBufferForbiddenAddress ( @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 @@ -1210,17 +1210,17 @@ EdkiiSmmSetMemoryAttributes ( @param BaseAddress The physical address that is the start address= of a memory region. @param Length The size in bytes of the memory region. - @param Attributes The bit mask of attributes to set for the memo= ry + @param Attributes The bit mask of attributes to clear for the me= mory region. =20 - @retval EFI_SUCCESS The attributes were set for the memory reg= ion. + @retval EFI_SUCCESS The attributes were clear for the memory r= egion. @retval EFI_INVALID_PARAMETER Length is zero. Attributes specified an illegal combinatio= n of - attributes that cannot be set together. + attributes that cannot be clear together. @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for + The bit mask of attributes is not supporte= d for the memory resource range specified by BaseAddress and Length. =20 @@ -1238,7 +1238,7 @@ EdkiiSmmClearMemoryAttributes ( } =20 /** - This function retrieve the attributes of the memory region specified by + This function retrieves the attributes of the memory region specified by BaseAddress and Length. If different attributes are got from different p= art of the memory region, EFI_NO_MAPPING will be returned. =20 @@ -1256,9 +1256,6 @@ EdkiiSmmClearMemoryAttributes ( @retval EFI_UNSUPPORTED The processor does not support one or more bytes of the memory resource range specifi= ed by BaseAddress and Length. - The bit mask of attributes is not support = for - the memory resource range specified by - BaseAddress and Length. =20 **/ EFI_STATUS --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel