[v2] ArmPkg/TimerDxe: Add ISB for timer compare value reload

[edk2] [PATCH v2 0/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

Heyi Guo posted 1 patch 6 years, 1 month ago

Diff against v3
Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[edk2] [PATCH v2 0/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

Posted by Heyi Guo 6 years, 1 month ago

After rebasing to edk2 commit 5e3719a, we found D05 would hang after printing a
lot of "Spurious interrupt" messages. The issue would gone away if we restored
the removal of "enable interrupt source":
  gInterrupt->EnableInterruptSource (gInterrupt, Source);

It can also be fixed if we add a "ISB" after reloading timer compare value, and
we agree that it makes sense to do that.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>

Heyi Guo (1):
  ArmPkg/TimerDxe: Add ISB for timer compare value reload

 ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel