BaseTools: Get Pcd DatumType from DEC file for --pcd

[edk2] [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd

Posted by Yonghong Zhu 6 years, 1 month ago

It is regression bug that missing the Pcd DatumType info from DEC file
for --pcd .

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 91b3a27..9c43dac 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -964,10 +964,11 @@ class DscBuildData(PlatformBuildClassObject):
                                              AUTOGEN_ERROR,
                                             "The Pcd %s is found under multiple different TokenSpaceGuid: %s and %s." % (DisplayName, PcdItem.TokenSpaceGuidCName, TokenSpaceGuidCNameList[0])
                                             )
                 else:
                     if (TokenCName, TokenSpaceGuidCName) in self.DecPcds:
+                        PcdDatumType = self.DecPcds[(TokenCName, TokenSpaceGuidCName)].DatumType
                         FoundFlag = True
                 if not FoundFlag:
                     if HasTokenSpace:
                         EdkLogger.error('build', AUTOGEN_ERROR, "The Pcd %s.%s is not found in the DEC file." % (TokenSpaceGuidCName, DisplayName))
                     else:
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd

Posted by Gao, Liming 6 years, 1 month ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Monday, March 12, 2018 3:11 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Get Pcd DatumType from DEC file for --pcd
>
>It is regression bug that missing the Pcd DatumType info from DEC file
>for --pcd .
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
>b/BaseTools/Source/Python/Workspace/DscBuildData.py
>index 91b3a27..9c43dac 100644
>--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
>+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
>@@ -964,10 +964,11 @@ class DscBuildData(PlatformBuildClassObject):
>                                              AUTOGEN_ERROR,
>                                             "The Pcd %s is found under multiple different
>TokenSpaceGuid: %s and %s." % (DisplayName,
>PcdItem.TokenSpaceGuidCName, TokenSpaceGuidCNameList[0])
>                                             )
>                 else:
>                     if (TokenCName, TokenSpaceGuidCName) in self.DecPcds:
>+                        PcdDatumType = self.DecPcds[(TokenCName,
>TokenSpaceGuidCName)].DatumType
>                         FoundFlag = True
>                 if not FoundFlag:
>                     if HasTokenSpace:
>                         EdkLogger.error('build', AUTOGEN_ERROR, "The Pcd %s.%s is not
>found in the DEC file." % (TokenSpaceGuidCName, DisplayName))
>                     else:
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel