From nobody Sat Apr 27 23:49:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1520698336380203.1583975982628; Sat, 10 Mar 2018 08:12:16 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 17B5D220C2A7A; Sat, 10 Mar 2018 08:05:54 -0800 (PST) Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com [IPv6:2607:f8b0:400d:c0d::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6F75223DB118 for ; Sat, 10 Mar 2018 08:05:52 -0800 (PST) Received: by mail-qt0-x244.google.com with SMTP id c7so14482346qtn.3 for ; Sat, 10 Mar 2018 08:12:11 -0800 (PST) Received: from clonetrooper.netronome.com (c-67-171-64-245.hsd1.pa.comcast.net. [67.171.64.245]) by smtp.gmail.com with ESMTPSA id f13sm2387119qtf.15.2018.03.10.08.12.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 10 Mar 2018 08:12:08 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c0d::244; helo=mail-qt0-x244.google.com; envelope-from=arvindprasanna@gmail.com; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=epFFBxVkh6BAAmHv8Ip0wfTJvxey0fr5N72qGfAdhik=; b=vfrhx+ZVw1qO9XjpKPizBnMaCxHBoXVq9aOz3mQSfqZperJltUHA2vb6ZL4HudbbKL xG5Q3w6ZGBLRCKjw+dgk/EHgDUhK9pq+VBbig6uokdmQ9zGjnKgdayTHwv1ggFujhl83 GrCVIgtQwhqoplJ7DKAO2ER752dpi3fCe318qahhtTUDMpdrm64eHwovlpc5KQGU6Ei4 bOvsLTpz5yPLeFtze6F9+B3FGKzik1bbnUD9RLCGgSNoqk6JH/+IeLPxeYUVW6YSPo6h Swiazs2EVg/qNy7f6x+VX4D8uM8OaxN/B/6Z2J5FyMnNxDympTXFKQzvEZLKY5MgcgWe 8I8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=epFFBxVkh6BAAmHv8Ip0wfTJvxey0fr5N72qGfAdhik=; b=tcgL0Q1VZ01mmY+BTlxahUZJPW7WdW8t3XOj5iboUeK1T7BjbelZnxBej4xVjk4Pfx MANjp8ypcmAUGwQzLBMvsKxRg1LxWQHrQtHWj78DeOaKhxhhDe7zzjxddr7gpYr66Pp2 Za8KAE9YMZtTvHArxv3FrREJPoWLCu0gaxxKkUoYot0cpPYMQWi6Qm1yQTyunq+y8cY1 4H/LyfY0zTts7Q9KlysOl5rV0dFbPLNPA+ZWRFnrbJ19KK1LFtwxhAXaXoZ7WMvuw9+a ULdXrvUs3euDadjHiMDJra/NiJkcD/bMexqjUfUs1JHcGUNfNm2JZ7UVNLV9CkYkmC+9 5zVA== X-Gm-Message-State: AElRT7F/xWxzPRWXmgcCalPrRKVId5ndpTZX9G4Ukz0Iy1BHo2RL/UlQ JngFYHwe7rjf4US5uN9NnsqWRA== X-Google-Smtp-Source: AG47ELsQwRJ2pCBxrBIrI4by8POoAYd3VR8Yr6oRnObLCW9YycqDIW0CltWXrVcrPWE+hbFjKZQlsw== X-Received: by 10.200.81.215 with SMTP id d23mr3428240qtn.272.1520698329961; Sat, 10 Mar 2018 08:12:09 -0800 (PST) From: Arvind Prasanna To: edk2-devel@lists.01.org Date: Sat, 10 Mar 2018 11:11:58 -0500 Message-Id: <1520698318-9232-1-git-send-email-arvindprasanna@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH] edksetup.sh: Update help section regarding positional X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" It is possible to source edksetup.sh from another script. If the calling/sourcing script has any positional parameters set, those are incorrectly accounted for in edksetup.sh while sourcing it resulting in the the help section always being shown. This patch updates the help section advising the user about these set positional parameters so they can be unset prior to sourcing edksetup.sh. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Arvind Prasanna --- edksetup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/edksetup.sh b/edksetup.sh index 93d6525..a3d5560 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -42,6 +42,8 @@ function HelpMsg() echo Please note: This script must be \'sourced\' so the environment can= be changed. echo ". $SCRIPTNAME" echo "source $SCRIPTNAME" + echo "If this script is being sourced from another script, please ensure= that the" + echo "sourcing/calling script has no set postional parameters." } =20 function SetWorkspace() --=20 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel