MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs

[edk2] [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs

Posted by Star Zeng 6 years, 1 month ago

Current BLOCK IO API code is using TPL_CALLBACK,
but comment is saying TPL_NOTIFY.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
index bb292ed3eba8..448bcc2f80ac 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
@@ -60,7 +60,7 @@ UsbMassReset (
   EFI_STATUS      Status;
 
   //
-  // Raise TPL to TPL_NOTIFY to serialize all its operations
+  // Raise TPL to TPL_CALLBACK to serialize all its operations
   // to protect shared data structures.
   //
   OldTpl  = gBS->RaiseTPL (TPL_CALLBACK);
@@ -114,7 +114,7 @@ UsbMassReadBlocks (
   UINTN               TotalBlock;
 
   //
-  // Raise TPL to TPL_NOTIFY to serialize all its operations
+  // Raise TPL to TPL_CALLBACK to serialize all its operations
   // to protect shared data structures.
   //
   OldTpl  = gBS->RaiseTPL (TPL_CALLBACK);
@@ -230,7 +230,7 @@ UsbMassWriteBlocks (
   UINTN               TotalBlock;
 
   //
-  // Raise TPL to TPL_NOTIFY to serialize all its operations
+  // Raise TPL to TPL_CALLBACK to serialize all its operations
   // to protect shared data structures.
   //
   OldTpl  = gBS->RaiseTPL (TPL_CALLBACK);
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs

Posted by Ni, Ruiyu 6 years, 1 month ago

On 3/3/2018 3:31 PM, Star Zeng wrote:
> Current BLOCK IO API code is using TPL_CALLBACK,
> but comment is saying TPL_NOTIFY.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>   MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> index bb292ed3eba8..448bcc2f80ac 100644
> --- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> +++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> @@ -60,7 +60,7 @@ UsbMassReset (
>     EFI_STATUS      Status;
>   
>     //
> -  // Raise TPL to TPL_NOTIFY to serialize all its operations
> +  // Raise TPL to TPL_CALLBACK to serialize all its operations
>     // to protect shared data structures.
>     //
>     OldTpl  = gBS->RaiseTPL (TPL_CALLBACK);
> @@ -114,7 +114,7 @@ UsbMassReadBlocks (
>     UINTN               TotalBlock;
>   
>     //
> -  // Raise TPL to TPL_NOTIFY to serialize all its operations
> +  // Raise TPL to TPL_CALLBACK to serialize all its operations
>     // to protect shared data structures.
>     //
>     OldTpl  = gBS->RaiseTPL (TPL_CALLBACK);
> @@ -230,7 +230,7 @@ UsbMassWriteBlocks (
>     UINTN               TotalBlock;
>   
>     //
> -  // Raise TPL to TPL_NOTIFY to serialize all its operations
> +  // Raise TPL to TPL_CALLBACK to serialize all its operations
>     // to protect shared data structures.
>     //
>     OldTpl  = gBS->RaiseTPL (TPL_CALLBACK);
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel