From nobody Tue May 7 04:03:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1514169963706764.2650268380444; Sun, 24 Dec 2017 18:46:03 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D701021CB87B4; Sun, 24 Dec 2017 18:41:03 -0800 (PST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DBAA921CB87B3 for ; Sun, 24 Dec 2017 18:41:01 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2017 18:45:54 -0800 Received: from fanwang2-hp.ccr.corp.intel.com ([10.239.9.33]) by orsmga004.jf.intel.com with ESMTP; 24 Dec 2017 18:45:53 -0800 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=fan.wang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,453,1508828400"; d="scan'208";a="161538242" From: fanwang2 To: edk2-devel@lists.01.org Date: Mon, 25 Dec 2017 10:45:46 +0800 Message-Id: <1514169946-6992-1-git-send-email-fan.wang@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 Subject: [edk2] [Patch] MdeModulePkg/NetLib: Refine coding style for API NetLibDetectMediaWaitTimeout X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wang Fan , Dandan Bi MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Wang Fan Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan Reviewed-by: Dandan Bi --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c b/MdeModulePkg/Libr= ary/DxeNetLib/DxeNetLib.c index d75cca2..26a80a7 100644 --- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c +++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c @@ -2526,11 +2526,10 @@ Exit: MediaState pointer is NULL. @retval EFI_DEVICE_ERROR A device error occurred. @retval EFI_TIMEOUT Network is connecting but timeout. =20 **/ - EFI_STATUS EFIAPI NetLibDetectMediaWaitTimeout ( IN EFI_HANDLE ServiceHandle, IN UINT64 Timeout, @@ -2571,11 +2570,11 @@ NetLibDetectMediaWaitTimeout ( if (EFI_ERROR (Status)) { =20 MediaPresent =3D TRUE; Status =3D NetLibDetectMedia (ServiceHandle, &MediaPresent); if (!EFI_ERROR (Status)) { - if (MediaPresent =3D=3D TRUE) { + if (MediaPresent) { *MediaState =3D EFI_SUCCESS; } else { *MediaState =3D EFI_NO_MEDIA; } } @@ -2612,11 +2611,11 @@ NetLibDetectMediaWaitTimeout ( // If gEfiAdapterInfoMediaStateGuid is not supported, call NetLibDet= ectMedia to get media state! // MediaPresent =3D TRUE; Status =3D NetLibDetectMedia (ServiceHandle, &MediaPresent); if (!EFI_ERROR (Status)) { - if (MediaPresent =3D=3D TRUE) { + if (MediaPresent) { *MediaState =3D EFI_SUCCESS; } else { *MediaState =3D EFI_NO_MEDIA; } } --=20 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel