BaseTools: Add object_files.lst as dependency of lib target

[edk2] [Patch] BaseTools: Add object_files.lst as dependency of lib target

Posted by Yonghong Zhu 6 years, 4 months ago

Seems object_files.lst is not added as dependency of lib target, this
patch update BaseTools to generate Makefile with this dependency.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/AutoGen/GenMake.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index 0f3ddd5..410ad59 100644
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -862,10 +862,12 @@ cleanlib:
                         Deps.append(NewFile)
 
                 # Use file list macro as dependency
                 if T.GenFileListMacro:
                     Deps.append("$(%s)" % T.FileListMacro)
+                    if Type in [TAB_OBJECT_FILE, TAB_STATIC_LIBRARY]:
+                        Deps.append("$(%s)" % T.ListFileMacro)
 
                 TargetDict = {
                     "target"    :   self.PlaceMacro(T.Target.Path, self.Macros),
                     "cmd"       :   "\n\t".join(T.Commands),
                     "deps"      :   Deps
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: Add object_files.lst as dependency of lib target

Posted by Gao, Liming 6 years, 4 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Wednesday, December 06, 2017 9:52 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Add object_files.lst as dependency of lib target
>
>Seems object_files.lst is not added as dependency of lib target, this
>patch update BaseTools to generate Makefile with this dependency.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/GenMake.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
>b/BaseTools/Source/Python/AutoGen/GenMake.py
>index 0f3ddd5..410ad59 100644
>--- a/BaseTools/Source/Python/AutoGen/GenMake.py
>+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
>@@ -862,10 +862,12 @@ cleanlib:
>                         Deps.append(NewFile)
>
>                 # Use file list macro as dependency
>                 if T.GenFileListMacro:
>                     Deps.append("$(%s)" % T.FileListMacro)
>+                    if Type in [TAB_OBJECT_FILE, TAB_STATIC_LIBRARY]:
>+                        Deps.append("$(%s)" % T.ListFileMacro)
>
>                 TargetDict = {
>                     "target"    :   self.PlaceMacro(T.Target.Path, self.Macros),
>                     "cmd"       :   "\n\t".join(T.Commands),
>                     "deps"      :   Deps
>--
>2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel