[v3] Armada 7k/8k - misc improvements pt.3

[edk2] [platforms: PATCH v3 0/4] Armada 7k/8k - misc improvements pt.3

Posted by Marcin Wojtas 6 years, 4 months ago

Hi,

The third version of the patchset brings the corrections
requested in the review. Details can be found in the changelog
below.

The patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171205

I'm looking forward to your comments or remarks.

Best regards,
Marcin

Changelog:
v2 -> v3
* 1/4
    - remove hardcoded DEFINE from the dsc file and enable
      passing the argument in a command line during build time
    - Add RB
    
* 3/4
    - Mention additional help information improvements in the
      commit log

* 4/4
    - Add RB

v1 -> v2

* 1/4
    - Add tftp as a build-time selectable option
    - Update commit message

* 2/4
    - Add RB

* 3/4
    - Leave initial file format and reword commit message

* 4/4
    - Leave PHY_AUTONEGOTIATE_TIMEOUT unmodified and
      remove double definition of the timeout.

Marcin Wojtas (4):
  Marvell/Armada: Switch to dynamic tftp command
  Marvell/Armada: Fix watchdog control base
  Marvell/Applications: FirmwareUpdate: Fix usage information
  Marvell/Drivers: MvPhyDxe: Cleanup the header

 Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 5190 bytes
 Platform/Marvell/Armada/Armada.dsc.inc                   |   6 +-
 Platform/Marvell/Armada/Armada70x0.fdf                   |   3 +
 Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.c     |   2 +-
 Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.h     | 152 ++++----------------
 5 files changed, 39 insertions(+), 124 deletions(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [platforms: PATCH v3 0/4] Armada 7k/8k - misc improvements pt.3

Posted by Leif Lindholm 6 years, 4 months ago

Thanks.
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 84c212b1b4..2348894694.

On Tue, Dec 05, 2017 at 06:57:01AM +0100, Marcin Wojtas wrote:
> Hi,
> 
> The third version of the patchset brings the corrections
> requested in the review. Details can be found in the changelog
> below.
> 
> The patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171205
> 
> I'm looking forward to your comments or remarks.
> 
> Best regards,
> Marcin
> 
> Changelog:
> v2 -> v3
> * 1/4
>     - remove hardcoded DEFINE from the dsc file and enable
>       passing the argument in a command line during build time
>     - Add RB
>     
> * 3/4
>     - Mention additional help information improvements in the
>       commit log
> 
> * 4/4
>     - Add RB
> 
> v1 -> v2
> 
> * 1/4
>     - Add tftp as a build-time selectable option
>     - Update commit message
> 
> * 2/4
>     - Add RB
> 
> * 3/4
>     - Leave initial file format and reword commit message
> 
> * 4/4
>     - Leave PHY_AUTONEGOTIATE_TIMEOUT unmodified and
>       remove double definition of the timeout.
> 
> Marcin Wojtas (4):
>   Marvell/Armada: Switch to dynamic tftp command
>   Marvell/Armada: Fix watchdog control base
>   Marvell/Applications: FirmwareUpdate: Fix usage information
>   Marvell/Drivers: MvPhyDxe: Cleanup the header
> 
>  Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 5190 bytes
>  Platform/Marvell/Armada/Armada.dsc.inc                   |   6 +-
>  Platform/Marvell/Armada/Armada70x0.fdf                   |   3 +
>  Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.c     |   2 +-
>  Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.h     | 152 ++++----------------
>  5 files changed, 39 insertions(+), 124 deletions(-)
> 
> -- 
> 2.7.4
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [platforms: PATCH v3 0/4] Armada 7k/8k - misc improvements pt.3

Posted by Marcin Wojtas 6 years, 4 months ago

2017-12-05 15:10 GMT+01:00 Leif Lindholm <leif.lindholm@linaro.org>:
>
> Thanks.
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Pushed as 84c212b1b4..2348894694.
>

Thanks a lot!
Marcin

>
> On Tue, Dec 05, 2017 at 06:57:01AM +0100, Marcin Wojtas wrote:
> > Hi,
> >
> > The third version of the patchset brings the corrections
> > requested in the review. Details can be found in the changelog
> > below.
> >
> > The patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171205
> >
> > I'm looking forward to your comments or remarks.
> >
> > Best regards,
> > Marcin
> >
> > Changelog:
> > v2 -> v3
> > * 1/4
> >     - remove hardcoded DEFINE from the dsc file and enable
> >       passing the argument in a command line during build time
> >     - Add RB
> >
> > * 3/4
> >     - Mention additional help information improvements in the
> >       commit log
> >
> > * 4/4
> >     - Add RB
> >
> > v1 -> v2
> >
> > * 1/4
> >     - Add tftp as a build-time selectable option
> >     - Update commit message
> >
> > * 2/4
> >     - Add RB
> >
> > * 3/4
> >     - Leave initial file format and reword commit message
> >
> > * 4/4
> >     - Leave PHY_AUTONEGOTIATE_TIMEOUT unmodified and
> >       remove double definition of the timeout.
> >
> > Marcin Wojtas (4):
> >   Marvell/Armada: Switch to dynamic tftp command
> >   Marvell/Armada: Fix watchdog control base
> >   Marvell/Applications: FirmwareUpdate: Fix usage information
> >   Marvell/Drivers: MvPhyDxe: Cleanup the header
> >
> >  Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 5190 bytes
> >  Platform/Marvell/Armada/Armada.dsc.inc                   |   6 +-
> >  Platform/Marvell/Armada/Armada70x0.fdf                   |   3 +
> >  Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.c     |   2 +-
> >  Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.h     | 152 ++++----------------
> >  5 files changed, 39 insertions(+), 124 deletions(-)
> >
> > --
> > 2.7.4
> >
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [platforms: PATCH v3 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information

Posted by Marcin Wojtas 6 years, 4 months ago

fupdate command's usage information referred to a deprecated
'-f' flag in 'examples' section. It was a residue from the
initial version of the application, removed during review
before merging to upstream branch. Correct the help information
and also on the occasion improve the message and its style.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 5190 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni b/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni
index 9d52e590c6d239621d226a240a3f9755210f52fe..146f624737d96e2cd354857dbb63390ebe2f347e 100644
GIT binary patch
delta 56
zcmbQGaZF=_h>&<DLmq<yLoh=CgC~$qW5{7hWGH6Hm@FuixVb_of^o76yTD`vb`~(c
HAnXMIdh-p2

delta 28
kcmX@6F-v2Eh|pv`p*Ut;hP27{LYA8k2`Mp7{v+%K0D@Hs0RR91

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel